* [PATCH 2/2] ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15
2019-03-22 19:59 [PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15 Douglas Anderson
@ 2019-03-22 19:59 ` Douglas Anderson
2019-03-24 21:20 ` [PATCH 1/2] dt-bindings: " Rob Herring
2019-03-25 12:25 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Douglas Anderson @ 2019-03-22 19:59 UTC (permalink / raw)
To: Heiko Stuebner
Cc: mka, ryandcase, Douglas Anderson, devicetree, linux-kernel,
linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel
As far as I can tell/remember rev10 was originally created to support
making a SKU of jerry that had a different LCD. rev11-rev15 were
added to give some wiggle room for future builds. Downstream has a
separate device tree for rev10-rev15 (compared to rev3-rev7) with the
expectation that differences relating to the LCD would be accounted
for there but nothing was ever added to the rev10-rev15 making it
identical to the rev3-rev7 one.
It's likely nothing actually shipped with rev10-rev15 but they are
listed in the downstream kernel's device tree and it seems like it
should add a little safety if we match them here just in case
something actually shipped with one of these revisions and that device
will break if we don't claim support.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
arch/arm/boot/dts/rk3288-veyron-jerry.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3288-veyron-jerry.dts b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
index 2ba89895c33a..517c6999a978 100644
--- a/arch/arm/boot/dts/rk3288-veyron-jerry.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
@@ -11,7 +11,10 @@
/ {
model = "Google Jerry";
- compatible = "google,veyron-jerry-rev7", "google,veyron-jerry-rev6",
+ compatible = "google,veyron-jerry-rev15", "google,veyron-jerry-rev14",
+ "google,veyron-jerry-rev13", "google,veyron-jerry-rev12",
+ "google,veyron-jerry-rev11", "google,veyron-jerry-rev10",
+ "google,veyron-jerry-rev7", "google,veyron-jerry-rev6",
"google,veyron-jerry-rev5", "google,veyron-jerry-rev4",
"google,veyron-jerry-rev3", "google,veyron-jerry",
"google,veyron", "rockchip,rk3288";
--
2.21.0.392.gf8f6787159e-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15
2019-03-22 19:59 [PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15 Douglas Anderson
2019-03-22 19:59 ` [PATCH 2/2] " Douglas Anderson
@ 2019-03-24 21:20 ` Rob Herring
2019-03-25 12:25 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2019-03-24 21:20 UTC (permalink / raw)
To: Douglas Anderson
Cc: Heiko Stuebner, Matthias Kaehlcke, Ryan Case, devicetree,
Tomeu Vizoso, Alexis Ballier, linux-kernel,
open list:ARM/Rockchip SoC...,
Robin Murphy, Mark Rutland, Akash Gajjar,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Fri, Mar 22, 2019 at 2:59 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> As far as I can tell/remember rev10 was originally created to support
> making a SKU of jerry that had a different LCD. rev11-rev15 were
> added to give some wiggle room for future builds. Downstream has a
> separate device tree for rev10-rev15 (compared to rev3-rev7) with the
> expectation that differences relating to the LCD would be accounted
> for there but nothing was ever added to the rev10-rev15 making it
> identical to the rev3-rev7 one.
>
> It's likely nothing actually shipped with rev10-rev15 but they are
> listed in the downstream kernel's device tree and it seems like it
> should add a little safety if we match them here just in case
> something actually shipped with one of these revisions and that device
> will break if we don't claim support.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15
2019-03-22 19:59 [PATCH 1/2] dt-bindings: ARM: dts: rockchip: Add rk3288-veyron-jerry rev 10-15 Douglas Anderson
2019-03-22 19:59 ` [PATCH 2/2] " Douglas Anderson
2019-03-24 21:20 ` [PATCH 1/2] dt-bindings: " Rob Herring
@ 2019-03-25 12:25 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2019-03-25 12:25 UTC (permalink / raw)
To: Douglas Anderson
Cc: mka, ryandcase, devicetree, Tomeu Vizoso, Alexis Ballier,
linux-kernel, linux-rockchip, Robin Murphy, Rob Herring,
Mark Rutland, Akash Gajjar, linux-arm-kernel
Am Freitag, 22. März 2019, 20:59:23 CET schrieb Douglas Anderson:
> As far as I can tell/remember rev10 was originally created to support
> making a SKU of jerry that had a different LCD. rev11-rev15 were
> added to give some wiggle room for future builds. Downstream has a
> separate device tree for rev10-rev15 (compared to rev3-rev7) with the
> expectation that differences relating to the LCD would be accounted
> for there but nothing was ever added to the rev10-rev15 making it
> identical to the rev3-rev7 one.
>
> It's likely nothing actually shipped with rev10-rev15 but they are
> listed in the downstream kernel's device tree and it seems like it
> should add a little safety if we match them here just in case
> something actually shipped with one of these revisions and that device
> will break if we don't claim support.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
applied both for 5.2
Thanks
Heiko
^ permalink raw reply [flat|nested] 4+ messages in thread