From: Borislav Petkov <bp@alien8.de>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Yash Shah <yash.shah@sifive.com>,
linux-riscv@lists.infradead.org, linux-edac@vger.kernel.org,
palmer@sifive.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com, aou@eecs.berkeley.edu,
mchehab@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller
Date: Mon, 25 Mar 2019 22:47:31 +0100 [thread overview]
Message-ID: <20190325214731.GT12016@zn.tnic> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1903251211190.8028@viisi.sifive.com>
On Mon, Mar 25, 2019 at 02:18:39PM -0700, Paul Walmsley wrote:
> All of these drivers are for single IP blocks. Mostly DRAM controllers.
> There's no "platform EDAC manager" IP block in these cases.
Maybe because they have RAS functionality in one single IP block. Others
like altera_edac, for example, have added support for more IP blocks
with time.
> So the EDAC "platform," if there is one, would be Xilinx Zynq, not
> Synopsys.
We have IP blocks sharing between drivers, see fsl_ddr_edac and
skx_common, for example.
> 2. We could create a platform driver for the "SiFive FU540-C000 EDAC"
> reporting platform that wouldn't map to any hardware block, but
> would call functions exported by other sources of EDAC data - most
> likely drivers living in separate directories. If, for example, we
> wind up using a Synopsys memory controller in a future product, we
> move the Synopsys code into a separate library, and move the Xilinx
> Zynq-specific code into a zynq_edac driver, etc.
Yes, librarizing is something we do already. So if you wanna share IP
blocks with other vendors, you can abstract it out into compilation
units like in the examples above. And then those compilation units can
be linked into a platform driver.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-03-25 21:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 9:20 [PATCH 0/2] L2 Cache EDAC Support for HiFive Unleashed Yash Shah
2019-03-12 9:21 ` [PATCH 1/2] edac: sifive: Add DT documentation for SiFive L2 cache Controller Yash Shah
2019-03-28 13:16 ` Rob Herring
2019-03-28 18:47 ` James Morse
2019-03-29 14:11 ` Rob Herring
2019-03-29 14:27 ` Borislav Petkov
2019-03-29 19:41 ` Rob Herring
2019-03-29 20:24 ` Borislav Petkov
2019-04-04 1:04 ` Rob Herring
2019-04-01 16:36 ` James Morse
2019-04-04 1:17 ` Rob Herring
2019-03-12 9:21 ` [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller Yash Shah
2019-03-12 9:28 ` Borislav Petkov
2019-03-25 0:16 ` Paul Walmsley
2019-03-25 6:54 ` Borislav Petkov
2019-03-25 21:18 ` Paul Walmsley
2019-03-25 21:47 ` Borislav Petkov [this message]
2019-03-12 16:31 ` Paul Walmsley
2019-03-12 16:32 ` [PATCH 0/2] L2 Cache EDAC Support for HiFive Unleashed Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325214731.GT12016@zn.tnic \
--to=bp@alien8.de \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).