* [PATCH] rcutorture: Select from only online CPUs @ 2019-03-23 3:46 Joel Fernandes (Google) 2019-03-25 15:01 ` Paul E. McKenney 0 siblings, 1 reply; 11+ messages in thread From: Joel Fernandes (Google) @ 2019-03-23 3:46 UTC (permalink / raw) To: linux-kernel Cc: Joel Fernandes (Google), Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Paul E. McKenney, Shuah Khan, Steven Rostedt The rcutorture jitter.sh script selects a random CPU but does not check if it is offline or online. This leads to taskset errors many times. On my machine, hyper threading is disabled so half the cores are offline causing taskset errors a lot of times. Let us fix this by checking from only the online CPUs on the system. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> --- tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh index 3633828375e3..53bf9d99b5cd 100755 --- a/tools/testing/selftests/rcutorture/bin/jitter.sh +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh @@ -47,10 +47,19 @@ do exit 0; fi - # Set affinity to randomly selected CPU + # Set affinity to randomly selected online CPU cpus=`ls /sys/devices/system/cpu/*/online | sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | grep -v '^0*$'` + + for c in $cpus; do + if [ "$(cat /sys/devices/system/cpu/cpu$c/online)" == "1" ]; + then + cpus_tmp="$cpus_tmp $c" + fi + done + cpus=$cpus_tmp + cpumask=`awk -v cpus="$cpus" -v me=$me -v n=$n 'BEGIN { srand(n + me + systime()); ncpus = split(cpus, ca); -- 2.21.0.392.gf8f6787159e-goog ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-23 3:46 [PATCH] rcutorture: Select from only online CPUs Joel Fernandes (Google) @ 2019-03-25 15:01 ` Paul E. McKenney 2019-03-25 16:33 ` Joel Fernandes 0 siblings, 1 reply; 11+ messages in thread From: Paul E. McKenney @ 2019-03-25 15:01 UTC (permalink / raw) To: Joel Fernandes (Google) Cc: linux-kernel, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > The rcutorture jitter.sh script selects a random CPU but does not check > if it is offline or online. This leads to taskset errors many times. On > my machine, hyper threading is disabled so half the cores are offline > causing taskset errors a lot of times. Let us fix this by checking from > only the online CPUs on the system. > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> Good catch! Please see below for one suggestion for simplification. Thanx, Paul > --- > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > index 3633828375e3..53bf9d99b5cd 100755 > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > @@ -47,10 +47,19 @@ do > exit 0; > fi > > - # Set affinity to randomly selected CPU > + # Set affinity to randomly selected online CPU > cpus=`ls /sys/devices/system/cpu/*/online | cpus=`grep 1 /sys/devices/system/cpu/*/online | > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > grep -v '^0*$'` Of course, now I have no idea why I excluded CPU 0... :-/ > + > + for c in $cpus; do > + if [ "$(cat /sys/devices/system/cpu/cpu$c/online)" == "1" ]; > + then > + cpus_tmp="$cpus_tmp $c" > + fi > + done > + cpus=$cpus_tmp > + > cpumask=`awk -v cpus="$cpus" -v me=$me -v n=$n 'BEGIN { > srand(n + me + systime()); > ncpus = split(cpus, ca); > -- > 2.21.0.392.gf8f6787159e-goog > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-25 15:01 ` Paul E. McKenney @ 2019-03-25 16:33 ` Joel Fernandes 2019-03-25 16:42 ` Paul E. McKenney 0 siblings, 1 reply; 11+ messages in thread From: Joel Fernandes @ 2019-03-25 16:33 UTC (permalink / raw) To: Paul E. McKenney Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > > The rcutorture jitter.sh script selects a random CPU but does not check > > if it is offline or online. This leads to taskset errors many times. On > > my machine, hyper threading is disabled so half the cores are offline > > causing taskset errors a lot of times. Let us fix this by checking from > > only the online CPUs on the system. > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > Good catch! > > Please see below for one suggestion for simplification. > > Thanx, Paul > > > --- > > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > > index 3633828375e3..53bf9d99b5cd 100755 > > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > > @@ -47,10 +47,19 @@ do > > exit 0; > > fi > > > > - # Set affinity to randomly selected CPU > > + # Set affinity to randomly selected online CPU > > cpus=`ls /sys/devices/system/cpu/*/online | > > cpus=`grep 1 /sys/devices/system/cpu/*/online | > Yes, this is better. Lets do it this way :) > > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > > grep -v '^0*$'` > > Of course, now I have no idea why I excluded CPU 0... :-/ Yes, I was wondering as well about that :-) thanks, - Joel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-25 16:33 ` Joel Fernandes @ 2019-03-25 16:42 ` Paul E. McKenney 2019-03-25 22:02 ` Joel Fernandes 2019-03-25 22:40 ` Joel Fernandes 0 siblings, 2 replies; 11+ messages in thread From: Paul E. McKenney @ 2019-03-25 16:42 UTC (permalink / raw) To: Joel Fernandes Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Mon, Mar 25, 2019 at 12:33:37PM -0400, Joel Fernandes wrote: > On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > > > The rcutorture jitter.sh script selects a random CPU but does not check > > > if it is offline or online. This leads to taskset errors many times. On > > > my machine, hyper threading is disabled so half the cores are offline > > > causing taskset errors a lot of times. Let us fix this by checking from > > > only the online CPUs on the system. > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > > > Good catch! > > > > Please see below for one suggestion for simplification. > > > > Thanx, Paul > > > > > --- > > > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > index 3633828375e3..53bf9d99b5cd 100755 > > > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > > > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > @@ -47,10 +47,19 @@ do > > > exit 0; > > > fi > > > > > > - # Set affinity to randomly selected CPU > > > + # Set affinity to randomly selected online CPU > > > cpus=`ls /sys/devices/system/cpu/*/online | > > > > cpus=`grep 1 /sys/devices/system/cpu/*/online | > > Yes, this is better. Lets do it this way :) > > > > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > > > grep -v '^0*$'` > > > > Of course, now I have no idea why I excluded CPU 0... :-/ > > Yes, I was wondering as well about that :-) Please feel free to try including CPU 0 and running the set of single-CPU rcutorture scenarios. ;-) Thanx, Paul ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-25 16:42 ` Paul E. McKenney @ 2019-03-25 22:02 ` Joel Fernandes 2019-03-25 22:40 ` Joel Fernandes 1 sibling, 0 replies; 11+ messages in thread From: Joel Fernandes @ 2019-03-25 22:02 UTC (permalink / raw) To: Paul E. McKenney Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Mon, Mar 25, 2019 at 09:42:53AM -0700, Paul E. McKenney wrote: > On Mon, Mar 25, 2019 at 12:33:37PM -0400, Joel Fernandes wrote: > > On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > > > > The rcutorture jitter.sh script selects a random CPU but does not check > > > > if it is offline or online. This leads to taskset errors many times. On > > > > my machine, hyper threading is disabled so half the cores are offline > > > > causing taskset errors a lot of times. Let us fix this by checking from > > > > only the online CPUs on the system. > > > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > > > > > Good catch! > > > > > > Please see below for one suggestion for simplification. > > > > > > Thanx, Paul > > > > > > > --- > > > > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > index 3633828375e3..53bf9d99b5cd 100755 > > > > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > @@ -47,10 +47,19 @@ do > > > > exit 0; > > > > fi > > > > > > > > - # Set affinity to randomly selected CPU > > > > + # Set affinity to randomly selected online CPU > > > > cpus=`ls /sys/devices/system/cpu/*/online | > > > > > > cpus=`grep 1 /sys/devices/system/cpu/*/online | > > > > Yes, this is better. Lets do it this way :) > > > > > > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > > > > grep -v '^0*$'` > > > > > > Of course, now I have no idea why I excluded CPU 0... :-/ > > > > Yes, I was wondering as well about that :-) > > Please feel free to try including CPU 0 and running the set of single-CPU > rcutorture scenarios. ;-) Sounds good, I will test that out on your latest dev branch. Thanks, - Joel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-25 16:42 ` Paul E. McKenney 2019-03-25 22:02 ` Joel Fernandes @ 2019-03-25 22:40 ` Joel Fernandes 2019-03-26 16:01 ` Paul E. McKenney 1 sibling, 1 reply; 11+ messages in thread From: Joel Fernandes @ 2019-03-25 22:40 UTC (permalink / raw) To: Paul E. McKenney Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Mon, Mar 25, 2019 at 12:42 PM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > On Mon, Mar 25, 2019 at 12:33:37PM -0400, Joel Fernandes wrote: > > On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > > > > The rcutorture jitter.sh script selects a random CPU but does not check > > > > if it is offline or online. This leads to taskset errors many times. On > > > > my machine, hyper threading is disabled so half the cores are offline > > > > causing taskset errors a lot of times. Let us fix this by checking from > > > > only the online CPUs on the system. > > > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > > > > > Good catch! > > > > > > Please see below for one suggestion for simplification. > > > > > > Thanx, Paul > > > > > > > --- > > > > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > index 3633828375e3..53bf9d99b5cd 100755 > > > > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > @@ -47,10 +47,19 @@ do > > > > exit 0; > > > > fi > > > > > > > > - # Set affinity to randomly selected CPU > > > > + # Set affinity to randomly selected online CPU > > > > cpus=`ls /sys/devices/system/cpu/*/online | > > > > > > cpus=`grep 1 /sys/devices/system/cpu/*/online | > > > > Yes, this is better. Lets do it this way :) > > > > > > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > > > > grep -v '^0*$'` > > > > > > Of course, now I have no idea why I excluded CPU 0... :-/ > > > > Yes, I was wondering as well about that :-) > > Please feel free to try including CPU 0 and running the set of single-CPU > rcutorture scenarios. ;-) Will do and then will update the patch by adding the CPU back, if all is well. Thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-25 22:40 ` Joel Fernandes @ 2019-03-26 16:01 ` Paul E. McKenney 2019-03-26 18:35 ` Joel Fernandes 0 siblings, 1 reply; 11+ messages in thread From: Paul E. McKenney @ 2019-03-26 16:01 UTC (permalink / raw) To: Joel Fernandes Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Mon, Mar 25, 2019 at 06:40:17PM -0400, Joel Fernandes wrote: > On Mon, Mar 25, 2019 at 12:42 PM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > On Mon, Mar 25, 2019 at 12:33:37PM -0400, Joel Fernandes wrote: > > > On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > > > > > The rcutorture jitter.sh script selects a random CPU but does not check > > > > > if it is offline or online. This leads to taskset errors many times. On > > > > > my machine, hyper threading is disabled so half the cores are offline > > > > > causing taskset errors a lot of times. Let us fix this by checking from > > > > > only the online CPUs on the system. > > > > > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > > > > > > > Good catch! > > > > > > > > Please see below for one suggestion for simplification. > > > > > > > > Thanx, Paul > > > > > > > > > --- > > > > > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > index 3633828375e3..53bf9d99b5cd 100755 > > > > > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > @@ -47,10 +47,19 @@ do > > > > > exit 0; > > > > > fi > > > > > > > > > > - # Set affinity to randomly selected CPU > > > > > + # Set affinity to randomly selected online CPU > > > > > cpus=`ls /sys/devices/system/cpu/*/online | > > > > > > > > cpus=`grep 1 /sys/devices/system/cpu/*/online | > > > > > > Yes, this is better. Lets do it this way :) > > > > > > > > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > > > > > grep -v '^0*$'` > > > > > > > > Of course, now I have no idea why I excluded CPU 0... :-/ > > > > > > Yes, I was wondering as well about that :-) > > > > Please feel free to try including CPU 0 and running the set of single-CPU > > rcutorture scenarios. ;-) > > Will do and then will update the patch by adding the CPU back, if all > is well. Thanks. And rcutorture doesn't like the rcu_is_cpu_rrupt_from_idle() patch on scenarios SRCU-P, TASKS01, and TREE05, which are the Tree RCU scenarios that enable CONFIG_PROVE_RCU. The compiler error is: kernel/rcu/tree.c:391:2: error: implicit declaration of function ‘_this_cpu_read’ [-Werror=implicit-function-declaration] My guess is that the initial underscore needs to go. I will drop these two patches in favor of an update from you. ;-) Thanx, Paul ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-26 16:01 ` Paul E. McKenney @ 2019-03-26 18:35 ` Joel Fernandes 2019-03-26 18:40 ` Joel Fernandes 0 siblings, 1 reply; 11+ messages in thread From: Joel Fernandes @ 2019-03-26 18:35 UTC (permalink / raw) To: Paul E. McKenney Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Tue, Mar 26, 2019 at 09:01:40AM -0700, Paul E. McKenney wrote: > On Mon, Mar 25, 2019 at 06:40:17PM -0400, Joel Fernandes wrote: > > On Mon, Mar 25, 2019 at 12:42 PM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > On Mon, Mar 25, 2019 at 12:33:37PM -0400, Joel Fernandes wrote: > > > > On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > > > > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > > > > > > The rcutorture jitter.sh script selects a random CPU but does not check > > > > > > if it is offline or online. This leads to taskset errors many times. On > > > > > > my machine, hyper threading is disabled so half the cores are offline > > > > > > causing taskset errors a lot of times. Let us fix this by checking from > > > > > > only the online CPUs on the system. > > > > > > > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > > > > > > > > > Good catch! > > > > > > > > > > Please see below for one suggestion for simplification. > > > > > > > > > > Thanx, Paul > > > > > > > > > > > --- > > > > > > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > > > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > index 3633828375e3..53bf9d99b5cd 100755 > > > > > > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > @@ -47,10 +47,19 @@ do > > > > > > exit 0; > > > > > > fi > > > > > > > > > > > > - # Set affinity to randomly selected CPU > > > > > > + # Set affinity to randomly selected online CPU > > > > > > cpus=`ls /sys/devices/system/cpu/*/online | > > > > > > > > > > cpus=`grep 1 /sys/devices/system/cpu/*/online | > > > > > > > > Yes, this is better. Lets do it this way :) > > > > > > > > > > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > > > > > > grep -v '^0*$'` > > > > > > > > > > Of course, now I have no idea why I excluded CPU 0... :-/ > > > > > > > > Yes, I was wondering as well about that :-) > > > > > > Please feel free to try including CPU 0 and running the set of single-CPU > > > rcutorture scenarios. ;-) > > > > Will do and then will update the patch by adding the CPU back, if all > > is well. Thanks. > > And rcutorture doesn't like the rcu_is_cpu_rrupt_from_idle() patch on > scenarios SRCU-P, TASKS01, and TREE05, which are the Tree RCU scenarios > that enable CONFIG_PROVE_RCU. The compiler error is: > > kernel/rcu/tree.c:391:2: error: implicit declaration of function ‘_this_cpu_read’ [-Werror=implicit-function-declaration] > > My guess is that the initial underscore needs to go. I will drop > these two patches in favor of an update from you. ;-) Sorry, I fixed that up and running tests now. By the way, may be you decided to not run the jitter on CPU0 just because on some systems, CPU0 does not have an 'online' file? In this case, the grep may throw errors I guess which troubles the script. From the old cpu hotplug docs, I found that if CONFIG_BOOTPARAM_HOTPLUG_CPU0 or cpu0_hotplug boot command line option is not passed, then cpu0 cannot be offlined in which case, presumably the 'online' file will be missing, like some systems I am testing on. thanks, - Joel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-26 18:35 ` Joel Fernandes @ 2019-03-26 18:40 ` Joel Fernandes 2019-03-26 20:46 ` Paul E. McKenney 0 siblings, 1 reply; 11+ messages in thread From: Joel Fernandes @ 2019-03-26 18:40 UTC (permalink / raw) To: Paul E. McKenney Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Tue, Mar 26, 2019 at 02:35:49PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 09:01:40AM -0700, Paul E. McKenney wrote: > > On Mon, Mar 25, 2019 at 06:40:17PM -0400, Joel Fernandes wrote: > > > On Mon, Mar 25, 2019 at 12:42 PM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > > > On Mon, Mar 25, 2019 at 12:33:37PM -0400, Joel Fernandes wrote: > > > > > On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > > > > > > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > > > > > > > The rcutorture jitter.sh script selects a random CPU but does not check > > > > > > > if it is offline or online. This leads to taskset errors many times. On > > > > > > > my machine, hyper threading is disabled so half the cores are offline > > > > > > > causing taskset errors a lot of times. Let us fix this by checking from > > > > > > > only the online CPUs on the system. > > > > > > > > > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > > > > > > > > > > > Good catch! > > > > > > > > > > > > Please see below for one suggestion for simplification. > > > > > > > > > > > > Thanx, Paul > > > > > > > > > > > > > --- > > > > > > > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > > > > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > > index 3633828375e3..53bf9d99b5cd 100755 > > > > > > > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > > @@ -47,10 +47,19 @@ do > > > > > > > exit 0; > > > > > > > fi > > > > > > > > > > > > > > - # Set affinity to randomly selected CPU > > > > > > > + # Set affinity to randomly selected online CPU > > > > > > > cpus=`ls /sys/devices/system/cpu/*/online | > > > > > > > > > > > > cpus=`grep 1 /sys/devices/system/cpu/*/online | > > > > > > > > > > Yes, this is better. Lets do it this way :) > > > > > > > > > > > > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > > > > > > > grep -v '^0*$'` > > > > > > > > > > > > Of course, now I have no idea why I excluded CPU 0... :-/ > > > > > > > > > > Yes, I was wondering as well about that :-) > > > > > > > > Please feel free to try including CPU 0 and running the set of single-CPU > > > > rcutorture scenarios. ;-) > > > > > > Will do and then will update the patch by adding the CPU back, if all > > > is well. Thanks. > > > > And rcutorture doesn't like the rcu_is_cpu_rrupt_from_idle() patch on > > scenarios SRCU-P, TASKS01, and TREE05, which are the Tree RCU scenarios > > that enable CONFIG_PROVE_RCU. The compiler error is: > > > > kernel/rcu/tree.c:391:2: error: implicit declaration of function ‘_this_cpu_read’ [-Werror=implicit-function-declaration] > > > > My guess is that the initial underscore needs to go. I will drop > > these two patches in favor of an update from you. ;-) > > Sorry, I fixed that up and running tests now. > > By the way, may be you decided to not run the jitter on CPU0 just because on > some systems, CPU0 does not have an 'online' file? In this case, the grep may > throw errors I guess which troubles the script. > > From the old cpu hotplug docs, I found that if CONFIG_BOOTPARAM_HOTPLUG_CPU0 > or cpu0_hotplug boot command line option is not passed, then cpu0 cannot be > offlined in which case, presumably the 'online' file will be missing, like > some systems I am testing on. Never mind, the "*" in your path search would take care of not erroring out :-) The other reason you may have done it is for making the jitter be consistent across systems that can offline CPU0, and the others that can't :-). I am just guessing. Any way, I will just add back CPU0 forcefully to the cpus list in my testing, without checking for the online file existence, and see what happens :-) If there's no smoke, then I'll roll that into a patch and send it out. thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-26 18:40 ` Joel Fernandes @ 2019-03-26 20:46 ` Paul E. McKenney 2019-03-26 23:48 ` Joel Fernandes 0 siblings, 1 reply; 11+ messages in thread From: Paul E. McKenney @ 2019-03-26 20:46 UTC (permalink / raw) To: Joel Fernandes Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Tue, Mar 26, 2019 at 02:40:13PM -0400, Joel Fernandes wrote: > On Tue, Mar 26, 2019 at 02:35:49PM -0400, Joel Fernandes wrote: > > On Tue, Mar 26, 2019 at 09:01:40AM -0700, Paul E. McKenney wrote: > > > On Mon, Mar 25, 2019 at 06:40:17PM -0400, Joel Fernandes wrote: > > > > On Mon, Mar 25, 2019 at 12:42 PM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > > > > > On Mon, Mar 25, 2019 at 12:33:37PM -0400, Joel Fernandes wrote: > > > > > > On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney <paulmck@linux.ibm.com> wrote: > > > > > > > > > > > > > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote: > > > > > > > > The rcutorture jitter.sh script selects a random CPU but does not check > > > > > > > > if it is offline or online. This leads to taskset errors many times. On > > > > > > > > my machine, hyper threading is disabled so half the cores are offline > > > > > > > > causing taskset errors a lot of times. Let us fix this by checking from > > > > > > > > only the online CPUs on the system. > > > > > > > > > > > > > > > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> > > > > > > > > > > > > > > Good catch! > > > > > > > > > > > > > > Please see below for one suggestion for simplification. > > > > > > > > > > > > > > Thanx, Paul > > > > > > > > > > > > > > > --- > > > > > > > > tools/testing/selftests/rcutorture/bin/jitter.sh | 11 ++++++++++- > > > > > > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > > > > > > > > > > > diff --git a/tools/testing/selftests/rcutorture/bin/jitter.sh b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > > > index 3633828375e3..53bf9d99b5cd 100755 > > > > > > > > --- a/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > > > +++ b/tools/testing/selftests/rcutorture/bin/jitter.sh > > > > > > > > @@ -47,10 +47,19 @@ do > > > > > > > > exit 0; > > > > > > > > fi > > > > > > > > > > > > > > > > - # Set affinity to randomly selected CPU > > > > > > > > + # Set affinity to randomly selected online CPU > > > > > > > > cpus=`ls /sys/devices/system/cpu/*/online | > > > > > > > > > > > > > > cpus=`grep 1 /sys/devices/system/cpu/*/online | > > > > > > > > > > > > Yes, this is better. Lets do it this way :) > > > > > > > > > > > > > > sed -e 's,/[^/]*$,,' -e 's/^[^0-9]*//' | > > > > > > > > grep -v '^0*$'` > > > > > > > > > > > > > > Of course, now I have no idea why I excluded CPU 0... :-/ > > > > > > > > > > > > Yes, I was wondering as well about that :-) > > > > > > > > > > Please feel free to try including CPU 0 and running the set of single-CPU > > > > > rcutorture scenarios. ;-) > > > > > > > > Will do and then will update the patch by adding the CPU back, if all > > > > is well. Thanks. > > > > > > And rcutorture doesn't like the rcu_is_cpu_rrupt_from_idle() patch on > > > scenarios SRCU-P, TASKS01, and TREE05, which are the Tree RCU scenarios > > > that enable CONFIG_PROVE_RCU. The compiler error is: > > > > > > kernel/rcu/tree.c:391:2: error: implicit declaration of function ‘_this_cpu_read’ [-Werror=implicit-function-declaration] > > > > > > My guess is that the initial underscore needs to go. I will drop > > > these two patches in favor of an update from you. ;-) > > > > Sorry, I fixed that up and running tests now. Very good. ;-) > > By the way, may be you decided to not run the jitter on CPU0 just because on > > some systems, CPU0 does not have an 'online' file? In this case, the grep may > > throw errors I guess which troubles the script. > > > > From the old cpu hotplug docs, I found that if CONFIG_BOOTPARAM_HOTPLUG_CPU0 > > or cpu0_hotplug boot command line option is not passed, then cpu0 cannot be > > offlined in which case, presumably the 'online' file will be missing, like > > some systems I am testing on. > > Never mind, the "*" in your path search would take care of not erroring out :-) > > The other reason you may have done it is for making the jitter be > consistent across systems that can offline CPU0, and the others that can't :-). > I am just guessing. Or maybe I was just being stupid. If I wasn't being stupid, it might have been that in the uniprocessor case the jitter caused some failure. But the kernel is a lot better about handling preemption these days, so that might well be an obsolete concern. Who knows? ;-) > Any way, I will just add back CPU0 forcefully to the cpus list in my testing, > without checking for the online file existence, and see what happens :-) If > there's no smoke, then I'll roll that into a patch and send it out. Sounds good, especially if you include a few of the uniprocessor tests. ;-) Thanx, Paul ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] rcutorture: Select from only online CPUs 2019-03-26 20:46 ` Paul E. McKenney @ 2019-03-26 23:48 ` Joel Fernandes 0 siblings, 0 replies; 11+ messages in thread From: Joel Fernandes @ 2019-03-26 23:48 UTC (permalink / raw) To: Paul E. McKenney Cc: LKML, Josh Triplett, Lai Jiangshan, linux-kselftest, Mathieu Desnoyers, Shuah Khan, Steven Rostedt On Tue, Mar 26, 2019 at 01:46:13PM -0700, Paul E. McKenney wrote: [snip] > > Any way, I will just add back CPU0 forcefully to the cpus list in my testing, > > without checking for the online file existence, and see what happens :-) If > > there's no smoke, then I'll roll that into a patch and send it out. > > Sounds good, especially if you include a few of the uniprocessor tests. ;-) Yes, I will do those as well. Thanks for the reminder :-). Let us wait on merging until then, then. I will reply back here about the uni processor testing tomorrow. thanks, - Joel ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-03-26 23:49 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-03-23 3:46 [PATCH] rcutorture: Select from only online CPUs Joel Fernandes (Google) 2019-03-25 15:01 ` Paul E. McKenney 2019-03-25 16:33 ` Joel Fernandes 2019-03-25 16:42 ` Paul E. McKenney 2019-03-25 22:02 ` Joel Fernandes 2019-03-25 22:40 ` Joel Fernandes 2019-03-26 16:01 ` Paul E. McKenney 2019-03-26 18:35 ` Joel Fernandes 2019-03-26 18:40 ` Joel Fernandes 2019-03-26 20:46 ` Paul E. McKenney 2019-03-26 23:48 ` Joel Fernandes
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).