From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Ronald Tschalär" <ronald@innovation.ch>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
Federico Lorenzi <federico@travelground.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.
Date: Wed, 27 Mar 2019 11:37:57 +0900 [thread overview]
Message-ID: <20190327023757.GB20766@kroah.com> (raw)
In-Reply-To: <20190327014807.7472-4-ronald@innovation.ch>
On Tue, Mar 26, 2019 at 06:48:06PM -0700, Ronald Tschalär wrote:
> This is the dev_xxx() analog to print_hex_dump(), using dev_printk()
> instead of straight printk() to match other dev_xxx() logging functions.
> ---
> drivers/base/core.c | 43 ++++++++++++++++++++++++++++++++++++++++++
> include/linux/device.h | 15 +++++++++++++++
> 2 files changed, 58 insertions(+)
No signed-off-by?
Anyway, no, please do not do this. Please do not dump large hex values
like this to the kernel log, it does not help anyone.
You can do this while debugging, sure, but not for "real" kernel code.
Worst case, just create a debugfs file for your device that you can read
the binary data from if you really need it. For any "normal" operation,
this is not something that you should ever need.
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-27 2:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 1:48 [PATCH v3 0/4] Add Apple SPI keyboard and trackpad driver Ronald Tschalär
2019-03-27 1:48 ` [PATCH v3 1/4] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it Ronald Tschalär
2019-03-27 14:13 ` Andrzej Hajda
2019-03-28 0:07 ` Life is hard, and then you die
2019-03-28 11:48 ` Andrzej Hajda
2019-03-29 9:22 ` Life is hard, and then you die
2019-03-27 1:48 ` [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse Ronald Tschalär
2019-03-27 7:46 ` Andy Shevchenko
2019-03-28 0:34 ` Life is hard, and then you die
2019-03-28 9:03 ` Andy Shevchenko
2019-03-28 10:29 ` Life is hard, and then you die
2019-03-27 1:48 ` [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function Ronald Tschalär
2019-03-27 2:37 ` Greg Kroah-Hartman [this message]
2019-03-28 0:28 ` Life is hard, and then you die
2019-03-28 5:29 ` Greg Kroah-Hartman
2019-03-28 10:27 ` Life is hard, and then you die
2019-03-28 11:29 ` Greg Kroah-Hartman
2019-03-28 12:30 ` Steven Rostedt
2019-04-02 2:47 ` Life is hard, and then you die
2019-04-02 6:33 ` Greg Kroah-Hartman
2019-04-07 1:46 ` Life is hard, and then you die
2019-04-08 12:07 ` Andy Shevchenko
2019-03-27 1:48 ` [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver Ronald Tschalär
2019-03-27 9:35 ` Andy Shevchenko
2019-03-27 18:45 ` Greg Kroah-Hartman
2019-03-27 19:15 ` Steven Rostedt
2019-03-27 19:22 ` Andy Shevchenko
2019-03-28 0:24 ` Life is hard, and then you die
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327023757.GB20766@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=federico@travelground.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael@kernel.org \
--cc=ronald@innovation.ch \
--cc=rostedt@goodmis.org \
--cc=rydberg@bitmath.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).