From: Steven Rostedt <rostedt@goodmis.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Life is hard, and then you die" <ronald@innovation.ch>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
Federico Lorenzi <federico@travelground.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function.
Date: Thu, 28 Mar 2019 08:30:36 -0400 [thread overview]
Message-ID: <20190328083036.7398db1b@gandalf.local.home> (raw)
In-Reply-To: <20190328112952.GA2232@kroah.com>
On Thu, 28 Mar 2019 12:29:52 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 3. In at least two places we log different types of packets in the
> > same lines of code (protected by a "if (log_mask & PKT_TYPE)") -
> > dynamic-debug would only allow enabling or disabling logging of
> > all packets. This could be worked around by creating a separate
> > (but essentially duplicate) logging function for each packet type
> > and some lookup table to call the appropriate one. Not very
> > pretty IMO, though.
>
> True, but you can use tracepoints as well, that would probably be much
> easier when you are logging data streams. You can also use an ebpf
> program with the tracepoints to log just what you need/want to when you
> want to as well.
And tracepoints have filters where you don't even need ebpf to do such
filtering.
See Documentation/trace/events.rst Section 5: Event Filtering
-- Steve
next prev parent reply other threads:[~2019-03-28 12:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 1:48 [PATCH v3 0/4] Add Apple SPI keyboard and trackpad driver Ronald Tschalär
2019-03-27 1:48 ` [PATCH v3 1/4] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it Ronald Tschalär
2019-03-27 14:13 ` Andrzej Hajda
2019-03-28 0:07 ` Life is hard, and then you die
2019-03-28 11:48 ` Andrzej Hajda
2019-03-29 9:22 ` Life is hard, and then you die
2019-03-27 1:48 ` [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse Ronald Tschalär
2019-03-27 7:46 ` Andy Shevchenko
2019-03-28 0:34 ` Life is hard, and then you die
2019-03-28 9:03 ` Andy Shevchenko
2019-03-28 10:29 ` Life is hard, and then you die
2019-03-27 1:48 ` [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function Ronald Tschalär
2019-03-27 2:37 ` Greg Kroah-Hartman
2019-03-28 0:28 ` Life is hard, and then you die
2019-03-28 5:29 ` Greg Kroah-Hartman
2019-03-28 10:27 ` Life is hard, and then you die
2019-03-28 11:29 ` Greg Kroah-Hartman
2019-03-28 12:30 ` Steven Rostedt [this message]
2019-04-02 2:47 ` Life is hard, and then you die
2019-04-02 6:33 ` Greg Kroah-Hartman
2019-04-07 1:46 ` Life is hard, and then you die
2019-04-08 12:07 ` Andy Shevchenko
2019-03-27 1:48 ` [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver Ronald Tschalär
2019-03-27 9:35 ` Andy Shevchenko
2019-03-27 18:45 ` Greg Kroah-Hartman
2019-03-27 19:15 ` Steven Rostedt
2019-03-27 19:22 ` Andy Shevchenko
2019-03-28 0:24 ` Life is hard, and then you die
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328083036.7398db1b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=federico@travelground.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael@kernel.org \
--cc=ronald@innovation.ch \
--cc=rydberg@bitmath.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).