From: Andrzej Hajda <a.hajda@samsung.com>
To: "Ronald Tschalär" <ronald@innovation.ch>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Henrik Rydberg" <rydberg@bitmath.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Lukas Wunner <lukas@wunner.de>,
Federico Lorenzi <federico@travelground.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Inki Dae <inki.dae@samsung.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3 1/4] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.
Date: Wed, 27 Mar 2019 15:13:37 +0100 [thread overview]
Message-ID: <9fd8af5b-20ed-5dca-7d5c-98f2926b9b0c@samsung.com> (raw)
In-Reply-To: <20190327014807.7472-2-ronald@innovation.ch>
+cc: dri-devel
On 27.03.2019 02:48, Ronald Tschalär wrote:
> commit d6abe6df706c66d803e6dd4fe98c1b6b7f125a56 (drm/bridge:
> sil_sii8620: do not have a dependency of RC_CORE) added a dependency on
> INPUT. However, this causes problems with other drivers, in particular
> an input driver that depends on MFD_INTEL_LPSS_PCI (to be added in a
> future commit):
>
> drivers/clk/Kconfig:9:error: recursive dependency detected!
> drivers/clk/Kconfig:9: symbol COMMON_CLK is selected by MFD_INTEL_LPSS
> drivers/mfd/Kconfig:566: symbol MFD_INTEL_LPSS is selected by MFD_INTEL_LPSS_PCI
> drivers/mfd/Kconfig:580: symbol MFD_INTEL_LPSS_PCI is implied by KEYBOARD_APPLESPI
> drivers/input/keyboard/Kconfig:73: symbol KEYBOARD_APPLESPI depends on INPUT
> drivers/input/Kconfig:8: symbol INPUT is selected by DRM_SIL_SII8620
> drivers/gpu/drm/bridge/Kconfig:83: symbol DRM_SIL_SII8620 depends on DRM_BRIDGE
> drivers/gpu/drm/bridge/Kconfig:1: symbol DRM_BRIDGE is selected by DRM_PL111
> drivers/gpu/drm/pl111/Kconfig:1: symbol DRM_PL111 depends on COMMON_CLK
>
> According to the docs, select should only be used for non-visible
> symbols. Furthermore almost all other references to INPUT throughout the
> kernel config are depends, not selects. Hence this change.
>
> CC: Inki Dae <inki.dae@samsung.com>
> CC: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Ronald Tschalär <ronald@innovation.ch>
This is drm bridge driver, next time please cc it to dri-devel ML also.
Anyway this is not the solution we have agreed to.
Why have you abandoned the patch [1]? It needed just some minor
polishing, as I wrote in response to this mail.
[1]:
https://lore.kernel.org/lkml/20190124082423.23139-1-ronald@innovation.ch/T/#mf620df0b1583096a214d8e2e690387078583472f
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 2fee47b0d50b..eabedc83f25c 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -83,9 +83,9 @@ config DRM_PARADE_PS8622
> config DRM_SIL_SII8620
> tristate "Silicon Image SII8620 HDMI/MHL bridge"
> depends on OF
> + depends on INPUT
> select DRM_KMS_HELPER
> imply EXTCON
> - select INPUT
> select RC_CORE
> help
> Silicon Image SII8620 HDMI/MHL bridge chip driver.
next prev parent reply other threads:[~2019-03-27 14:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 1:48 [PATCH v3 0/4] Add Apple SPI keyboard and trackpad driver Ronald Tschalär
2019-03-27 1:48 ` [PATCH v3 1/4] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it Ronald Tschalär
2019-03-27 14:13 ` Andrzej Hajda [this message]
2019-03-28 0:07 ` Life is hard, and then you die
2019-03-28 11:48 ` Andrzej Hajda
2019-03-29 9:22 ` Life is hard, and then you die
2019-03-27 1:48 ` [PATCH v3 2/4] lib/hexdump.c: factor out generic hexdump formatting for reuse Ronald Tschalär
2019-03-27 7:46 ` Andy Shevchenko
2019-03-28 0:34 ` Life is hard, and then you die
2019-03-28 9:03 ` Andy Shevchenko
2019-03-28 10:29 ` Life is hard, and then you die
2019-03-27 1:48 ` [PATCH v3 3/4] driver core: add dev_print_hex_dump() logging function Ronald Tschalär
2019-03-27 2:37 ` Greg Kroah-Hartman
2019-03-28 0:28 ` Life is hard, and then you die
2019-03-28 5:29 ` Greg Kroah-Hartman
2019-03-28 10:27 ` Life is hard, and then you die
2019-03-28 11:29 ` Greg Kroah-Hartman
2019-03-28 12:30 ` Steven Rostedt
2019-04-02 2:47 ` Life is hard, and then you die
2019-04-02 6:33 ` Greg Kroah-Hartman
2019-04-07 1:46 ` Life is hard, and then you die
2019-04-08 12:07 ` Andy Shevchenko
2019-03-27 1:48 ` [PATCH v3 4/4] Input: add Apple SPI keyboard and trackpad driver Ronald Tschalär
2019-03-27 9:35 ` Andy Shevchenko
2019-03-27 18:45 ` Greg Kroah-Hartman
2019-03-27 19:15 ` Steven Rostedt
2019-03-27 19:22 ` Andy Shevchenko
2019-03-28 0:24 ` Life is hard, and then you die
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fd8af5b-20ed-5dca-7d5c-98f2926b9b0c@samsung.com \
--to=a.hajda@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=federico@travelground.com \
--cc=gregkh@linuxfoundation.org \
--cc=inki.dae@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael@kernel.org \
--cc=ronald@innovation.ch \
--cc=rostedt@goodmis.org \
--cc=rydberg@bitmath.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).