* [PATCH] parport: ieee1284: mark expected switch fall-through
@ 2019-03-29 15:20 Sudip Mukherjee
0 siblings, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2019-03-29 15:20 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, Gustavo A. R. Silva, Sudip Mukherjee
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/parport/ieee1284.c: In function ‘parport_read’:
drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
^
drivers/parport/ieee1284.c:726:2: note: here
case IEEE1284_MODE_NIBBLE:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
drivers/parport/ieee1284.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/parport/ieee1284.c b/drivers/parport/ieee1284.c
index f12b9da69255..90fb73575495 100644
--- a/drivers/parport/ieee1284.c
+++ b/drivers/parport/ieee1284.c
@@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)
if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
return -EIO;
}
- /* fall through to NIBBLE */
+ /* fall through - to NIBBLE */
case IEEE1284_MODE_NIBBLE:
DPRINTK (KERN_DEBUG "%s: Using nibble mode\n", port->name);
fn = port->ops->nibble_read_data;
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] parport: ieee1284: mark expected switch fall-through
@ 2019-02-12 17:43 Gustavo A. R. Silva
2019-02-25 18:23 ` Gustavo A. R. Silva
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-12 17:43 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/parport/ieee1284.c: In function ‘parport_read’:
drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
^
drivers/parport/ieee1284.c:726:2: note: here
case IEEE1284_MODE_NIBBLE:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/parport/ieee1284.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/parport/ieee1284.c b/drivers/parport/ieee1284.c
index f12b9da69255..90fb73575495 100644
--- a/drivers/parport/ieee1284.c
+++ b/drivers/parport/ieee1284.c
@@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)
if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
return -EIO;
}
- /* fall through to NIBBLE */
+ /* fall through - to NIBBLE */
case IEEE1284_MODE_NIBBLE:
DPRINTK (KERN_DEBUG "%s: Using nibble mode\n", port->name);
fn = port->ops->nibble_read_data;
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] parport: ieee1284: mark expected switch fall-through
2019-02-12 17:43 Gustavo A. R. Silva
@ 2019-02-25 18:23 ` Gustavo A. R. Silva
2019-03-20 20:06 ` Gustavo A. R. Silva
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-25 18:23 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: linux-kernel, Kees Cook
Hi,
Friendly ping:
Who can take this, please?
Thanks
--
Gustavo
On 2/12/19 11:43 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/parport/ieee1284.c: In function ‘parport_read’:
> drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
> ^
> drivers/parport/ieee1284.c:726:2: note: here
> case IEEE1284_MODE_NIBBLE:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/parport/ieee1284.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/parport/ieee1284.c b/drivers/parport/ieee1284.c
> index f12b9da69255..90fb73575495 100644
> --- a/drivers/parport/ieee1284.c
> +++ b/drivers/parport/ieee1284.c
> @@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)
> if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
> return -EIO;
> }
> - /* fall through to NIBBLE */
> + /* fall through - to NIBBLE */
> case IEEE1284_MODE_NIBBLE:
> DPRINTK (KERN_DEBUG "%s: Using nibble mode\n", port->name);
> fn = port->ops->nibble_read_data;
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] parport: ieee1284: mark expected switch fall-through
2019-02-25 18:23 ` Gustavo A. R. Silva
@ 2019-03-20 20:06 ` Gustavo A. R. Silva
2019-03-20 20:12 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 20:06 UTC (permalink / raw)
To: Sudip Mukherjee, Greg KH; +Cc: linux-kernel, Kees Cook
Greg,
Can you take this, please?
Thanks
--
Gustavo
On 2/25/19 12:23 PM, Gustavo A. R. Silva wrote:
> Hi,
>
> Friendly ping:
>
> Who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 2/12/19 11:43 AM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/parport/ieee1284.c: In function ‘parport_read’:
>> drivers/parport/ieee1284.c:722:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
>> ^
>> drivers/parport/ieee1284.c:726:2: note: here
>> case IEEE1284_MODE_NIBBLE:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/parport/ieee1284.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/parport/ieee1284.c b/drivers/parport/ieee1284.c
>> index f12b9da69255..90fb73575495 100644
>> --- a/drivers/parport/ieee1284.c
>> +++ b/drivers/parport/ieee1284.c
>> @@ -722,7 +722,7 @@ ssize_t parport_read (struct parport *port, void *buffer, size_t len)
>> if (parport_negotiate (port, IEEE1284_MODE_NIBBLE)) {
>> return -EIO;
>> }
>> - /* fall through to NIBBLE */
>> + /* fall through - to NIBBLE */
>> case IEEE1284_MODE_NIBBLE:
>> DPRINTK (KERN_DEBUG "%s: Using nibble mode\n", port->name);
>> fn = port->ops->nibble_read_data;
>>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] parport: ieee1284: mark expected switch fall-through
2019-03-20 20:06 ` Gustavo A. R. Silva
@ 2019-03-20 20:12 ` Greg KH
2019-03-20 20:21 ` Gustavo A. R. Silva
2019-03-24 18:33 ` Sudip Mukherjee
0 siblings, 2 replies; 7+ messages in thread
From: Greg KH @ 2019-03-20 20:12 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Sudip Mukherjee, linux-kernel, Kees Cook
On Wed, Mar 20, 2019 at 03:06:04PM -0500, Gustavo A. R. Silva wrote:
> Greg,
>
> Can you take this, please?
Will do, give me a week or so to catch up...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] parport: ieee1284: mark expected switch fall-through
2019-03-20 20:12 ` Greg KH
@ 2019-03-20 20:21 ` Gustavo A. R. Silva
2019-03-24 18:33 ` Sudip Mukherjee
1 sibling, 0 replies; 7+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 20:21 UTC (permalink / raw)
To: Greg KH; +Cc: Sudip Mukherjee, linux-kernel, Kees Cook
On 3/20/19 3:12 PM, Greg KH wrote:
> On Wed, Mar 20, 2019 at 03:06:04PM -0500, Gustavo A. R. Silva wrote:
>> Greg,
>>
>> Can you take this, please?
>
> Will do, give me a week or so to catch up...
>
Sure thing.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] parport: ieee1284: mark expected switch fall-through
2019-03-20 20:12 ` Greg KH
2019-03-20 20:21 ` Gustavo A. R. Silva
@ 2019-03-24 18:33 ` Sudip Mukherjee
1 sibling, 0 replies; 7+ messages in thread
From: Sudip Mukherjee @ 2019-03-24 18:33 UTC (permalink / raw)
To: Greg KH; +Cc: Gustavo A. R. Silva, linux-kernel, Kees Cook
Hi Greg,
On Wed, Mar 20, 2019 at 8:12 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Mar 20, 2019 at 03:06:04PM -0500, Gustavo A. R. Silva wrote:
> > Greg,
> >
> > Can you take this, please?
>
> Will do, give me a week or so to catch up...
I will send it to you with the another parport regression fix I have.
Will send you by next week.
--
Regards
Sudip
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-29 15:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-29 15:20 [PATCH] parport: ieee1284: mark expected switch fall-through Sudip Mukherjee
-- strict thread matches above, loose matches on Subject: below --
2019-02-12 17:43 Gustavo A. R. Silva
2019-02-25 18:23 ` Gustavo A. R. Silva
2019-03-20 20:06 ` Gustavo A. R. Silva
2019-03-20 20:12 ` Greg KH
2019-03-20 20:21 ` Gustavo A. R. Silva
2019-03-24 18:33 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).