* [PATCH net-next] rxrpc: Mark expected switch fall-through
@ 2019-04-01 19:39 Gustavo A. R. Silva
2019-04-04 4:39 ` David Miller
2019-04-05 15:15 ` David Howells
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-01 19:39 UTC (permalink / raw)
To: David Howells, David S. Miller
Cc: linux-afs, netdev, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
This patch fixes the following warning:
net/rxrpc/local_object.c: In function ‘rxrpc_open_socket’:
net/rxrpc/local_object.c:175:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (ret < 0) {
^
net/rxrpc/local_object.c:184:2: note: here
case AF_INET:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Currently, GCC is expecting to find the fall-through annotations
at the very bottom of the case and on its own line. That's why
I had to add the annotation, although the intentional fall-through
is already mentioned in a few lines above.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
net/rxrpc/local_object.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c
index 15cf42d5b53a..9157fd00dce3 100644
--- a/net/rxrpc/local_object.c
+++ b/net/rxrpc/local_object.c
@@ -180,7 +180,7 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
/* Fall through and set IPv4 options too otherwise we don't get
* errors from IPv4 packets sent through the IPv6 socket.
*/
-
+ /* Fall through */
case AF_INET:
/* we want to receive ICMP errors */
opt = 1;
--
2.21.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] rxrpc: Mark expected switch fall-through
2019-04-01 19:39 [PATCH net-next] rxrpc: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-04-04 4:39 ` David Miller
2019-04-04 15:31 ` Gustavo A. R. Silva
2019-04-05 15:15 ` David Howells
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2019-04-04 4:39 UTC (permalink / raw)
To: gustavo; +Cc: dhowells, linux-afs, netdev, linux-kernel, keescook
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 1 Apr 2019 14:39:31 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> net/rxrpc/local_object.c: In function ‘rxrpc_open_socket’:
> net/rxrpc/local_object.c:175:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (ret < 0) {
> ^
> net/rxrpc/local_object.c:184:2: note: here
> case AF_INET:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Currently, GCC is expecting to find the fall-through annotations
> at the very bottom of the case and on its own line. That's why
> I had to add the annotation, although the intentional fall-through
> is already mentioned in a few lines above.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] rxrpc: Mark expected switch fall-through
2019-04-04 4:39 ` David Miller
@ 2019-04-04 15:31 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-04 15:31 UTC (permalink / raw)
To: David Miller; +Cc: dhowells, linux-afs, netdev, linux-kernel, keescook
On 4/3/19 11:39 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Mon, 1 Apr 2019 14:39:31 -0500
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> net/rxrpc/local_object.c: In function ‘rxrpc_open_socket’:
>> net/rxrpc/local_object.c:175:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (ret < 0) {
>> ^
>> net/rxrpc/local_object.c:184:2: note: here
>> case AF_INET:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Currently, GCC is expecting to find the fall-through annotations
>> at the very bottom of the case and on its own line. That's why
>> I had to add the annotation, although the intentional fall-through
>> is already mentioned in a few lines above.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied.
>
Thanks, Dave.
--
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] rxrpc: Mark expected switch fall-through
2019-04-01 19:39 [PATCH net-next] rxrpc: Mark expected switch fall-through Gustavo A. R. Silva
2019-04-04 4:39 ` David Miller
@ 2019-04-05 15:15 ` David Howells
1 sibling, 0 replies; 4+ messages in thread
From: David Howells @ 2019-04-05 15:15 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: dhowells, David S. Miller, linux-afs, netdev, linux-kernel, Kees Cook
Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> /* Fall through and set IPv4 options too otherwise we don't get
> * errors from IPv4 packets sent through the IPv6 socket.
> */
> -
> + /* Fall through */
Er, no. Please (a) don't remove the blank line that's providing visual
separation and (b) observe that the previous comment already says "Fall
through" right at the beginning, so NAK.
If the compiler doesn't recognise this, then fix the compiler please.
David
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-05 15:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-01 19:39 [PATCH net-next] rxrpc: Mark expected switch fall-through Gustavo A. R. Silva
2019-04-04 4:39 ` David Miller
2019-04-04 15:31 ` Gustavo A. R. Silva
2019-04-05 15:15 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).