* [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable
@ 2019-04-04 12:44 Antti Keränen
2019-04-04 12:55 ` Sergio Paracuellos
0 siblings, 1 reply; 2+ messages in thread
From: Antti Keränen @ 2019-04-04 12:44 UTC (permalink / raw)
To: matthias.bgg
Cc: gregkh, sergio.paracuellos, benniciemanuel78, neil, devel,
linux-arm-kernel, linux-mediatek, linux-kernel,
Antti Keränen
Do not use uninitialized variable 'port' when printing an error message
Signed-off-by: Antti Keränen <detegr@gmail.com>
---
drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
index 118302c122ee..aa3ae7777632 100644
--- a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
+++ b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
@@ -331,7 +331,7 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
ret = of_address_to_resource(np, 0, &res);
if (ret) {
- dev_err(dev, "failed to get address resource(id-%d)\n", port);
+ dev_err(dev, "failed to get address resource\n");
return ret;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable
2019-04-04 12:44 [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable Antti Keränen
@ 2019-04-04 12:55 ` Sergio Paracuellos
0 siblings, 0 replies; 2+ messages in thread
From: Sergio Paracuellos @ 2019-04-04 12:55 UTC (permalink / raw)
To: Antti Keränen
Cc: Matthias Brugger, Greg KH, benniciemanuel78, NeilBrown, devel,
linux-arm-kernel, linux-mediatek, linux-kernel
On Thu, Apr 4, 2019 at 2:46 PM Antti Keränen <detegr@gmail.com> wrote:
>
> Do not use uninitialized variable 'port' when printing an error message
>
> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
> drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> index 118302c122ee..aa3ae7777632 100644
> --- a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> +++ b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> @@ -331,7 +331,7 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
>
> ret = of_address_to_resource(np, 0, &res);
> if (ret) {
> - dev_err(dev, "failed to get address resource(id-%d)\n", port);
> + dev_err(dev, "failed to get address resource\n");
> return ret;
> }
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Thanks,
Sergio Paracuellos
>
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-04 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 12:44 [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable Antti Keränen
2019-04-04 12:55 ` Sergio Paracuellos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).