[PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('

[PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('

[Caio Salvador Rohwedder]

Fix checkpatch coding style errors on rtl819x_TSProc.c
- space required before the open parenthesis '('
- spaces required around that '=='

Signed-off-by: Caio Salvador Rohwedder <caiosalvador96@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
index c76715ffa08b..0af1a87a5545 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
@@ -373,7 +373,7 @@ bool GetTs(
 			if(!list_empty(pUnusedList)) {
 				(*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);
 				list_del_init(&(*ppTS)->list);
-				if(TxRxSelect==TX_DIR) {
+				if (TxRxSelect == TX_DIR) {
 					struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);
 					ResetTxTsEntry(tmp);
 				} else {
-- 
2.21.0

Re: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('

[YueHaibing]

On 2019/4/5 9:56, Caio Salvador Rohwedder wrote:
> Fix checkpatch coding style errors on rtl819x_TSProc.c
> - space required before the open parenthesis '('
> - spaces required around that '=='
> 
> Signed-off-by: Caio Salvador Rohwedder <caiosalvador96@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> index c76715ffa08b..0af1a87a5545 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> @@ -373,7 +373,7 @@ bool GetTs(
>  			if(!list_empty(pUnusedList)) {
>  				(*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);
>  				list_del_init(&(*ppTS)->list);
> -				if(TxRxSelect==TX_DIR) {
> +				if (TxRxSelect == TX_DIR) {
>  					struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);

This line seems over 80 characters, may also be fixed.

In fact, this file has so many code style issues, see

./scripts/checkpatch.pl --no-tree -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c

>  					ResetTxTsEntry(tmp);
>  				} else {
> 

Re: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('

[Dan Carpenter]

On Fri, Apr 05, 2019 at 10:31:17AM +0800, YueHaibing wrote:
> On 2019/4/5 9:56, Caio Salvador Rohwedder wrote:
> >  			if(!list_empty(pUnusedList)) {
> >  				(*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);
> >  				list_del_init(&(*ppTS)->list);
> > -				if(TxRxSelect==TX_DIR) {
> > +				if (TxRxSelect == TX_DIR) {
> >  					struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);
> 
> This line seems over 80 characters, may also be fixed.
> 

The 80 character problem isn't really related to the "space required"
problem.  Those would need to be fixed in separate patches.

> In fact, this file has so many code style issues, see
> 
> ./scripts/checkpatch.pl --no-tree -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> 

Yes.  Of course it has millions of style issues.  It's staging code.
Leave it.  We'll fix it little by little.

That said, I kind of would prefer to review patches which fix all the
"space[s] required" checkpatch warnings in a file in one go...

regards,
dan carpenter