* [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"
@ 2019-04-15 11:44 Colin King
2019-04-16 6:51 ` Mukesh Ojha
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2019-04-15 11:44 UTC (permalink / raw)
To: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
David S . Miller, netfilter-devel, coreteam, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The appears to be a spelling mistake in one of the entries in the
_SecurityCapabilities array. Fix this.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/netfilter/nf_conntrack_h323_types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
index d880f3523c1d..95a0b3d6b24d 100644
--- a/net/netfilter/nf_conntrack_h323_types.c
+++ b/net/netfilter/nf_conntrack_h323_types.c
@@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
_NonStandardParameter},
{FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
_SecurityServiceMode},
- {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
+ {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
_SecurityServiceMode},
{FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
_SecurityServiceMode},
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"
2019-04-15 11:44 [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication" Colin King
@ 2019-04-16 6:51 ` Mukesh Ojha
2019-04-16 9:12 ` Florian Westphal
0 siblings, 1 reply; 4+ messages in thread
From: Mukesh Ojha @ 2019-04-16 6:51 UTC (permalink / raw)
To: Colin King, Pablo Neira Ayuso, Jozsef Kadlecsik,
Florian Westphal, David S . Miller, netfilter-devel, coreteam,
netdev
Cc: kernel-janitors, linux-kernel
On 4/15/2019 5:14 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The appears to be a spelling mistake in one of the entries in the
> _SecurityCapabilities array. Fix this.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> net/netfilter/nf_conntrack_h323_types.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
> index d880f3523c1d..95a0b3d6b24d 100644
> --- a/net/netfilter/nf_conntrack_h323_types.c
> +++ b/net/netfilter/nf_conntrack_h323_types.c
> @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
> _NonStandardParameter},
> {FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> _SecurityServiceMode},
> - {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> + {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> _SecurityServiceMode},
> {FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> _SecurityServiceMode},
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"
2019-04-16 6:51 ` Mukesh Ojha
@ 2019-04-16 9:12 ` Florian Westphal
2019-04-16 9:18 ` Colin Ian King
0 siblings, 1 reply; 4+ messages in thread
From: Florian Westphal @ 2019-04-16 9:12 UTC (permalink / raw)
To: Mukesh Ojha
Cc: Colin King, Pablo Neira Ayuso, Jozsef Kadlecsik,
Florian Westphal, David S . Miller, netfilter-devel, coreteam,
netdev, kernel-janitors, linux-kernel
On 4/15/2019 5:14 PM, Colin King wrote:
> > diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
> > index d880f3523c1d..95a0b3d6b24d 100644
> > --- a/net/netfilter/nf_conntrack_h323_types.c
> > +++ b/net/netfilter/nf_conntrack_h323_types.c
> > @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
> > _NonStandardParameter},
> > {FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> > _SecurityServiceMode},
> > - {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> > + {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> > _SecurityServiceMode},
> > {FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
> > _SecurityServiceMode},
https://www.itu.int/ITU-T/formal-language/itu-t/h/h225-0/2009/H323-MESSAGES.html says:
...
SecurityCapabilities ::= SEQUENCE {
nonStandard NonStandardParameter OPTIONAL,
encryption SecurityServiceMode,
authenticaton SecurityServiceMode,
integrity SecurityServiceMode,
...
}
so this spelling seems intentional.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"
2019-04-16 9:12 ` Florian Westphal
@ 2019-04-16 9:18 ` Colin Ian King
0 siblings, 0 replies; 4+ messages in thread
From: Colin Ian King @ 2019-04-16 9:18 UTC (permalink / raw)
To: Florian Westphal, Mukesh Ojha
Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, David S . Miller,
netfilter-devel, coreteam, netdev, kernel-janitors, linux-kernel
On 16/04/2019 10:12, Florian Westphal wrote:
> On 4/15/2019 5:14 PM, Colin King wrote:
>>> diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
>>> index d880f3523c1d..95a0b3d6b24d 100644
>>> --- a/net/netfilter/nf_conntrack_h323_types.c
>>> +++ b/net/netfilter/nf_conntrack_h323_types.c
>>> @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
>>> _NonStandardParameter},
>>> {FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>>> - {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> + {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>>> {FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>
> https://www.itu.int/ITU-T/formal-language/itu-t/h/h225-0/2009/H323-MESSAGES.html says:
> ...
> SecurityCapabilities ::= SEQUENCE {
> nonStandard NonStandardParameter OPTIONAL,
> encryption SecurityServiceMode,
> authenticaton SecurityServiceMode,
> integrity SecurityServiceMode,
> ...
> }
>
> so this spelling seems intentional.
>
Ah, thanks for spotting that, my bad.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-16 9:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15 11:44 [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication" Colin King
2019-04-16 6:51 ` Mukesh Ojha
2019-04-16 9:12 ` Florian Westphal
2019-04-16 9:18 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).