From: Tony Luck <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] RAS/CEC: Add debugfs switch to disable at run time
Date: Thu, 18 Apr 2019 15:02:29 -0700 [thread overview]
Message-ID: <20190418220229.32133-1-tony.luck@intel.com> (raw)
Useful when running error injection tests that want to
see all of the MCi_(STATUS|ADDR|MISC) data via /dev/mcelog.
Signed-off-by: Tony Luck <tony.luck@intel.com>
---
drivers/ras/cec.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 2d9ec378a8bc..a2ceedcd8516 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -123,6 +123,9 @@ static u64 dfs_pfn;
/* Amount of errors after which we offline */
static unsigned int count_threshold = COUNT_MASK;
+/* debugfs switch to enable/disable CEC */
+static u64 cec_enabled = 1;
+
/*
* The timer "decays" element count each timer_interval which is 24hrs by
* default.
@@ -400,6 +403,14 @@ static int count_threshold_set(void *data, u64 val)
}
DEFINE_DEBUGFS_ATTRIBUTE(count_threshold_ops, u64_get, count_threshold_set, "%lld\n");
+static int enable_set(void *data, u64 val)
+{
+ ce_arr.disabled = !val;
+ return 0;
+}
+
+DEFINE_DEBUGFS_ATTRIBUTE(enable_ops, u64_get, enable_set, "%lld\n");
+
static int array_dump(struct seq_file *m, void *v)
{
struct ce_array *ca = &ce_arr;
@@ -451,7 +462,7 @@ static const struct file_operations array_ops = {
static int __init create_debugfs_nodes(void)
{
- struct dentry *d, *pfn, *decay, *count, *array;
+ struct dentry *d, *pfn, *decay, *count, *array, *enable;
d = debugfs_create_dir("cec", ras_debugfs_dir);
if (!d) {
@@ -485,6 +496,13 @@ static int __init create_debugfs_nodes(void)
goto err;
}
+ enable = debugfs_create_file("enable", S_IRUSR | S_IWUSR, d,
+ &cec_enabled, &enable_ops);
+ if (!enable) {
+ pr_warn("Error creating enable debugfs node!\n");
+ goto err;
+ }
+
return 0;
--
2.19.1
next reply other threads:[~2019-04-18 22:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 22:02 Tony Luck [this message]
2019-04-18 22:51 ` [PATCH] RAS/CEC: Add debugfs switch to disable at run time Cong Wang
2019-04-18 23:29 ` Borislav Petkov
2019-04-18 23:58 ` Cong Wang
2019-04-19 0:26 ` Borislav Petkov
2019-04-20 5:43 ` Cong Wang
2019-04-20 9:13 ` Borislav Petkov
2019-04-20 18:18 ` Cong Wang
2019-04-20 18:47 ` Borislav Petkov
2019-04-20 19:08 ` Cong Wang
2019-04-22 16:29 ` Luck, Tony
2019-04-22 16:31 ` Borislav Petkov
2019-04-22 16:43 ` Luck, Tony
2019-04-22 17:05 ` Borislav Petkov
2019-04-22 17:23 ` Luck, Tony
2019-04-19 0:07 ` Luck, Tony
2019-04-19 0:29 ` Borislav Petkov
2019-04-19 15:04 ` Luck, Tony
2019-04-20 9:41 ` Borislav Petkov
2019-04-22 15:59 ` Luck, Tony
2019-04-22 17:15 ` Borislav Petkov
2019-04-22 17:44 ` Luck, Tony
2019-04-22 18:08 ` Borislav Petkov
2019-04-20 5:50 ` Cong Wang
2019-04-20 19:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418220229.32133-1-tony.luck@intel.com \
--to=tony.luck@intel.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).