From: Cong Wang <xiyou.wangcong@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RAS/CEC: Add debugfs switch to disable at run time
Date: Fri, 19 Apr 2019 22:50:35 -0700 [thread overview]
Message-ID: <CAM_iQpVgnNPaqN2kyNoPFbrU4pk1U_8=G4GOWJniLAhStMg2AA@mail.gmail.com> (raw)
In-Reply-To: <20190419000745.GA12291@agluck-desk>
On Thu, Apr 18, 2019 at 5:07 PM Luck, Tony <tony.luck@intel.com> wrote:
>
> On Fri, Apr 19, 2019 at 01:29:10AM +0200, Borislav Petkov wrote:
> > Which reminds me, Tony, I think all those debugging files "pfn"
> > and "array" and the one you add now, should all be under a
> > CONFIG_RAS_CEC_DEBUG which is default off and used only for development.
> > Mind adding that too pls?
>
> Patch below, on top of previous patch. Note that I didn't move "enable"
> into the RAS_CEC_DEBUG code. I think it has some value even on
> production systems. It is still in debugfs (which many production
> systems don't mount) so I don't see that people are going to be randomly
> using it to disable the CEC.
For me, "enable" is useful to make mcelog work like before. Please see the
other email from me for all the details.
For debugfs, I believe many productions mount it, as tracing still uses debugfs
rather than tracefs (at least on CentOS7), and rasdaemon also uses trace
events to collect different errors.
Therefore, I believe your patch is fine as it is.
Thanks.
next prev parent reply other threads:[~2019-04-20 5:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 22:02 [PATCH] RAS/CEC: Add debugfs switch to disable at run time Tony Luck
2019-04-18 22:51 ` Cong Wang
2019-04-18 23:29 ` Borislav Petkov
2019-04-18 23:58 ` Cong Wang
2019-04-19 0:26 ` Borislav Petkov
2019-04-20 5:43 ` Cong Wang
2019-04-20 9:13 ` Borislav Petkov
2019-04-20 18:18 ` Cong Wang
2019-04-20 18:47 ` Borislav Petkov
2019-04-20 19:08 ` Cong Wang
2019-04-22 16:29 ` Luck, Tony
2019-04-22 16:31 ` Borislav Petkov
2019-04-22 16:43 ` Luck, Tony
2019-04-22 17:05 ` Borislav Petkov
2019-04-22 17:23 ` Luck, Tony
2019-04-19 0:07 ` Luck, Tony
2019-04-19 0:29 ` Borislav Petkov
2019-04-19 15:04 ` Luck, Tony
2019-04-20 9:41 ` Borislav Petkov
2019-04-22 15:59 ` Luck, Tony
2019-04-22 17:15 ` Borislav Petkov
2019-04-22 17:44 ` Luck, Tony
2019-04-22 18:08 ` Borislav Petkov
2019-04-20 5:50 ` Cong Wang [this message]
2019-04-20 19:50 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpVgnNPaqN2kyNoPFbrU4pk1U_8=G4GOWJniLAhStMg2AA@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).