* [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA
@ 2019-04-23 16:29 Vitaly Chikunov
2019-04-23 20:20 ` Randy Dunlap
2019-04-25 7:52 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Vitaly Chikunov @ 2019-04-23 16:29 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, linux-crypto, linux-kernel
Cc: Randy Dunlap, Stephen Rothwell
Fix undefined symbol issue in ecrdsa_generic module when ASN1
or OID_REGISTRY aren't enabled in the config by selecting these
options for CRYPTO_ECRDSA.
ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
---
crypto/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git crypto/Kconfig crypto/Kconfig
index 4446833f6eca..3d056e7da65f 100644
--- crypto/Kconfig
+++ crypto/Kconfig
@@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
select CRYPTO_ECC
select CRYPTO_AKCIPHER
select CRYPTO_STREEBOG
+ select OID_REGISTRY
+ select ASN1
help
Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA
2019-04-23 16:29 [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA Vitaly Chikunov
@ 2019-04-23 20:20 ` Randy Dunlap
2019-04-25 7:52 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2019-04-23 20:20 UTC (permalink / raw)
To: Vitaly Chikunov, Herbert Xu, David S. Miller, linux-crypto, linux-kernel
Cc: Stephen Rothwell
On 4/23/19 9:29 AM, Vitaly Chikunov wrote:
> Fix undefined symbol issue in ecrdsa_generic module when ASN1
> or OID_REGISTRY aren't enabled in the config by selecting these
> options for CRYPTO_ECRDSA.
>
> ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
> ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
My tools would prefer to see the diff at one tree level higher:
> ---
> crypto/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git crypto/Kconfig crypto/Kconfig
diff --git a/crypto/Kconfig b/crypto/Kconfig
for any spelling of a and b.
> index 4446833f6eca..3d056e7da65f 100644
> --- crypto/Kconfig
> +++ crypto/Kconfig
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
> @@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
> select CRYPTO_ECC
> select CRYPTO_AKCIPHER
> select CRYPTO_STREEBOG
> + select OID_REGISTRY
> + select ASN1
> help
> Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
> RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA
2019-04-23 16:29 [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA Vitaly Chikunov
2019-04-23 20:20 ` Randy Dunlap
@ 2019-04-25 7:52 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-04-25 7:52 UTC (permalink / raw)
To: Vitaly Chikunov
Cc: David S. Miller, linux-crypto, linux-kernel, Randy Dunlap,
Stephen Rothwell
On Tue, Apr 23, 2019 at 07:29:54PM +0300, Vitaly Chikunov wrote:
> Fix undefined symbol issue in ecrdsa_generic module when ASN1
> or OID_REGISTRY aren't enabled in the config by selecting these
> options for CRYPTO_ECRDSA.
>
> ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
> ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> ---
> crypto/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-25 7:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-23 16:29 [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA Vitaly Chikunov
2019-04-23 20:20 ` Randy Dunlap
2019-04-25 7:52 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).