* [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes
@ 2019-04-26 5:54 Ran Wang
2019-05-01 23:54 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Ran Wang @ 2019-04-26 5:54 UTC (permalink / raw)
To: Shawn Guo
Cc: Leo Li, Rob Herring, linux-arm-kernel, devicetree, linux-kernel,
Ran Wang
This patch adds USB dt nodes for LS1028A.
Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
---
Changes in v2:
- Rename node from usb3@... to usb@... to meet DTSpec
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 8dd3501..188cfb8 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -144,6 +144,26 @@
clocks = <&sysclk>;
};
+ usb0:usb@3100000 {
+ compatible= "snps,dwc3";
+ reg= <0x0 0x3100000 0x0 0x10000>;
+ interrupts= <0 80 0x4>;
+ dr_mode= "host";
+ snps,dis_rxdet_inp3_quirk;
+ snps,quirk-frame-length-adjustment = <0x20>;
+ snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+ };
+
+ usb1:usb@3110000 {
+ compatible= "snps,dwc3";
+ reg= <0x0 0x3110000 0x0 0x10000>;
+ interrupts= <0 81 0x4>;
+ dr_mode= "host";
+ snps,dis_rxdet_inp3_quirk;
+ snps,quirk-frame-length-adjustment = <0x20>;
+ snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
+ };
+
i2c0: i2c@2000000 {
compatible = "fsl,vf610-i2c";
#address-cells = <1>;
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes
2019-04-26 5:54 [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes Ran Wang
@ 2019-05-01 23:54 ` Rob Herring
2019-05-07 8:48 ` Ran Wang
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-05-01 23:54 UTC (permalink / raw)
To: Ran Wang; +Cc: Shawn Guo, Leo Li, linux-arm-kernel, devicetree, linux-kernel
On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> This patch adds USB dt nodes for LS1028A.
>
> Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> ---
> Changes in v2:
> - Rename node from usb3@... to usb@... to meet DTSpec
>
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20 ++++++++++++++++++++
> 1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 8dd3501..188cfb8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -144,6 +144,26 @@
> clocks = <&sysclk>;
> };
>
> + usb0:usb@3100000 {
^ space needed
> + compatible= "snps,dwc3";
Needs an SoC specific compatible.
> + reg= <0x0 0x3100000 0x0 0x10000>;
> + interrupts= <0 80 0x4>;
> + dr_mode= "host";
> + snps,dis_rxdet_inp3_quirk;
> + snps,quirk-frame-length-adjustment = <0x20>;
> + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> + };
> +
> + usb1:usb@3110000 {
> + compatible= "snps,dwc3";
> + reg= <0x0 0x3110000 0x0 0x10000>;
> + interrupts= <0 81 0x4>;
> + dr_mode= "host";
> + snps,dis_rxdet_inp3_quirk;
> + snps,quirk-frame-length-adjustment = <0x20>;
> + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> + };
> +
> i2c0: i2c@2000000 {
> compatible = "fsl,vf610-i2c";
> #address-cells = <1>;
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes
2019-05-01 23:54 ` Rob Herring
@ 2019-05-07 8:48 ` Ran Wang
2019-05-07 16:40 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Ran Wang @ 2019-05-07 8:48 UTC (permalink / raw)
To: Rob Herring; +Cc: Shawn Guo, Leo Li, linux-arm-kernel, devicetree, linux-kernel
Hi Rob,
On Thursday, May 02, 2019 07:54 Rob Herring wrote:
>
> On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> > This patch adds USB dt nodes for LS1028A.
> >
> > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > ---
> > Changes in v2:
> > - Rename node from usb3@... to usb@... to meet DTSpec
> >
> > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20
> ++++++++++++++++++++
> > 1 files changed, 20 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > index 8dd3501..188cfb8 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > @@ -144,6 +144,26 @@
> > clocks = <&sysclk>;
> > };
> >
> > + usb0:usb@3100000 {
> ^ space needed
Yes, will update this in next version.
> > + compatible= "snps,dwc3";
>
> Needs an SoC specific compatible.
Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?
As I know, so far there is no SoC specific programming for this IP, so do
you think it's still necessary to add it?
Regards,
Ran
> > + reg= <0x0 0x3100000 0x0 0x10000>;
> > + interrupts= <0 80 0x4>;
> > + dr_mode= "host";
> > + snps,dis_rxdet_inp3_quirk;
> > + snps,quirk-frame-length-adjustment = <0x20>;
> > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > + };
> > +
> > + usb1:usb@3110000 {
> > + compatible= "snps,dwc3";
> > + reg= <0x0 0x3110000 0x0 0x10000>;
> > + interrupts= <0 81 0x4>;
> > + dr_mode= "host";
> > + snps,dis_rxdet_inp3_quirk;
> > + snps,quirk-frame-length-adjustment = <0x20>;
> > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > + };
> > +
> > i2c0: i2c@2000000 {
> > compatible = "fsl,vf610-i2c";
> > #address-cells = <1>;
> > --
> > 1.7.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes
2019-05-07 8:48 ` Ran Wang
@ 2019-05-07 16:40 ` Rob Herring
2019-05-08 2:20 ` Ran Wang
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-05-07 16:40 UTC (permalink / raw)
To: Ran Wang; +Cc: Shawn Guo, Leo Li, linux-arm-kernel, devicetree, linux-kernel
On Tue, May 7, 2019 at 3:48 AM Ran Wang <ran.wang_1@nxp.com> wrote:
>
> Hi Rob,
>
> On Thursday, May 02, 2019 07:54 Rob Herring wrote:
> >
> > On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> > > This patch adds USB dt nodes for LS1028A.
> > >
> > > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > > ---
> > > Changes in v2:
> > > - Rename node from usb3@... to usb@... to meet DTSpec
> > >
> > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20
> > ++++++++++++++++++++
> > > 1 files changed, 20 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > index 8dd3501..188cfb8 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > @@ -144,6 +144,26 @@
> > > clocks = <&sysclk>;
> > > };
> > >
> > > + usb0:usb@3100000 {
> > ^ space needed
>
> Yes, will update this in next version.
>
> > > + compatible= "snps,dwc3";
> >
> > Needs an SoC specific compatible.
>
> Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?
Well, that's the wrong order, but yes.
> As I know, so far there is no SoC specific programming for this IP, so do
> you think it's still necessary to add it?
Yes. All the bugs and quirks are discovered already?
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes
2019-05-07 16:40 ` Rob Herring
@ 2019-05-08 2:20 ` Ran Wang
0 siblings, 0 replies; 5+ messages in thread
From: Ran Wang @ 2019-05-08 2:20 UTC (permalink / raw)
To: Rob Herring; +Cc: Shawn Guo, Leo Li, linux-arm-kernel, devicetree, linux-kernel
Hi Rob,
On Wednesday, May 08, 2019 00:40, Rob Herring wrote:
>
> On Tue, May 7, 2019 at 3:48 AM Ran Wang <ran.wang_1@nxp.com> wrote:
> >
> > Hi Rob,
> >
> > On Thursday, May 02, 2019 07:54 Rob Herring wrote:
> > >
> > > On Fri, Apr 26, 2019 at 05:54:26AM +0000, Ran Wang wrote:
> > > > This patch adds USB dt nodes for LS1028A.
> > > >
> > > > Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> > > > ---
> > > > Changes in v2:
> > > > - Rename node from usb3@... to usb@... to meet DTSpec
> > > >
> > > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20
> > > ++++++++++++++++++++
> > > > 1 files changed, 20 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > index 8dd3501..188cfb8 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > > @@ -144,6 +144,26 @@
> > > > clocks = <&sysclk>;
> > > > };
> > > >
> > > > + usb0:usb@3100000 {
> > > ^ space needed
> >
> > Yes, will update this in next version.
> >
> > > > + compatible= "snps,dwc3";
> > >
> > > Needs an SoC specific compatible.
> >
> > Do you mean change compatible to "snps,dwc3", "fsl,ls1028a-dwc3" ?
>
> Well, that's the wrong order, but yes.
OK, will update this.
> > As I know, so far there is no SoC specific programming for this IP, so
> > do you think it's still necessary to add it?
>
> Yes. All the bugs and quirks are discovered already?
Yes, so far I don't receive any SoC specific defect report, I think it's fine.
Will work out next version patch, thanks for your time.
Regards,
Ran
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-08 2:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-26 5:54 [PATCH v2] arm64: dts: ls1028a: Add USB dt nodes Ran Wang
2019-05-01 23:54 ` Rob Herring
2019-05-07 8:48 ` Ran Wang
2019-05-07 16:40 ` Rob Herring
2019-05-08 2:20 ` Ran Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).