From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: jacek.anaszewski@gmail.com, broonie@kernel.org,
lgirdwood@gmail.com, lee.jones@linaro.org,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v4 1/6] regulator: lm363x: Make the gpio register enable flexible
Date: Wed, 22 May 2019 23:22:07 +0200 [thread overview]
Message-ID: <20190522212207.GA28132@amd> (raw)
In-Reply-To: <20190522192733.13422-2-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]
On Wed 2019-05-22 14:27:28, Dan Murphy wrote:
> The use of and enablement of the GPIO can be used across devices.
> Use the enable_reg in the regulator descriptor for the register to
> write.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
> ---
> drivers/regulator/lm363x-regulator.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/lm363x-regulator.c b/drivers/regulator/lm363x-regulator.c
> index c876e161052a..382b1cecdd93 100644
> --- a/drivers/regulator/lm363x-regulator.c
> +++ b/drivers/regulator/lm363x-regulator.c
> @@ -263,8 +263,8 @@ static int lm363x_regulator_probe(struct platform_device *pdev)
>
> if (gpiod) {
> cfg.ena_gpiod = gpiod;
> -
> - ret = regmap_update_bits(regmap, LM3632_REG_BIAS_CONFIG,
> + ret = regmap_update_bits(regmap,
> + lm363x_regulator_desc[id].enable_reg,
> LM3632_EXT_EN_MASK,
> LM3632_EXT_EN_MASK);
> if (ret) {
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-05-22 21:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 19:27 [PATCH v4 0/6] LM36274 Introduction Dan Murphy
2019-05-22 19:27 ` [RESEND PATCH v4 1/6] regulator: lm363x: Make the gpio register enable flexible Dan Murphy
2019-05-22 21:22 ` Pavel Machek [this message]
2019-05-23 13:03 ` Mark Brown
2019-05-23 13:50 ` Dan Murphy
2019-05-26 12:48 ` Mark Brown
2019-05-29 11:51 ` Dan Murphy
2019-05-29 15:10 ` Mark Brown
2019-05-29 20:47 ` Dan Murphy
2019-05-30 15:26 ` Mark Brown
2019-06-04 15:14 ` Dan Murphy
2019-06-04 15:33 ` Mark Brown
2019-05-22 19:27 ` [RESEND PATCH v4 2/6] dt-bindings: mfd: Add lm36274 bindings to ti-lmu Dan Murphy
2019-05-22 21:22 ` Pavel Machek
2019-05-22 19:27 ` [RESEND PATCH v4 3/6] mfd: ti-lmu: Add LM36274 support to the ti-lmu Dan Murphy
2019-05-23 8:09 ` Pavel Machek
2019-05-22 19:27 ` [RESEND PATCH v4 4/6] regulator: lm363x: Add support for LM36274 Dan Murphy
2019-05-23 8:12 ` Pavel Machek
2019-05-23 13:04 ` Mark Brown
2019-05-22 19:27 ` [RESEND PATCH v4 5/6] dt-bindings: leds: Add LED bindings for the LM36274 Dan Murphy
2019-05-23 12:43 ` Pavel Machek
2019-05-22 19:27 ` [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver Dan Murphy
2019-05-23 12:50 ` Pavel Machek
2019-05-23 19:09 ` Dan Murphy
2019-05-24 20:51 ` Jacek Anaszewski
2019-05-29 13:58 ` Lee Jones
2019-05-29 20:50 ` Jacek Anaszewski
2019-05-30 7:38 ` Lee Jones
2019-05-30 19:58 ` Jacek Anaszewski
2019-05-31 6:23 ` Lee Jones
2019-05-31 19:44 ` Jacek Anaszewski
2019-05-31 21:07 ` Dan Murphy
2019-05-31 21:57 ` Jacek Anaszewski
2019-05-31 22:41 ` Dan Murphy
2019-06-01 13:55 ` Jacek Anaszewski
2019-05-22 19:37 ` [PATCH v4 0/6] LM36274 Introduction Jacek Anaszewski
2019-05-22 19:39 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522212207.GA28132@amd \
--to=pavel@ucw.cz \
--cc=broonie@kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).