From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Cc: grygorii.strashko@ti.com, hawk@kernel.org, davem@davemloft.net,
ast@kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, xdp-newbies@vger.kernel.org,
ilias.apalodimas@linaro.org, netdev@vger.kernel.org,
daniel@iogearbox.net, jakub.kicinski@netronome.com,
john.fastabend@gmail.com, brouer@redhat.com
Subject: Re: [PATCH v2 net-next 7/7] net: ethernet: ti: cpsw: add XDP support
Date: Fri, 31 May 2019 17:46:43 +0200 [thread overview]
Message-ID: <20190531174643.4be8b27f@carbon> (raw)
In-Reply-To: <20190530182039.4945-8-ivan.khoronzhuk@linaro.org>
Hi Ivan,
From below code snippets, it looks like you only allocated 1 page_pool
and sharing it with several RX-queues, as I don't have the full context
and don't know this driver, I might be wrong?
To be clear, a page_pool object is needed per RX-queue, as it is
accessing a small RX page cache (which protected by NAPI/softirq).
On Thu, 30 May 2019 21:20:39 +0300
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> wrote:
> @@ -1404,6 +1711,14 @@ static int cpsw_ndo_open(struct net_device *ndev)
> enable_irq(cpsw->irqs_table[0]);
> }
>
> + pool_size = cpdma_get_num_rx_descs(cpsw->dma);
> + cpsw->page_pool = cpsw_create_page_pool(cpsw, pool_size);
> + if (IS_ERR(cpsw->page_pool)) {
> + ret = PTR_ERR(cpsw->page_pool);
> + cpsw->page_pool = NULL;
> + goto err_cleanup;
> + }
On Thu, 30 May 2019 21:20:39 +0300
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> wrote:
> @@ -675,10 +742,33 @@ int cpsw_set_ringparam(struct net_device *ndev,
> if (cpsw->usage_count)
> cpdma_chan_split_pool(cpsw->dma);
>
> + for (i = 0; i < cpsw->data.slaves; i++) {
> + struct net_device *ndev = cpsw->slaves[i].ndev;
> +
> + if (!(ndev && netif_running(ndev)))
> + continue;
> +
> + cpsw_xdp_unreg_rxqs(netdev_priv(ndev));
> + }
> +
> + page_pool_destroy(cpsw->page_pool);
> + cpsw->page_pool = pool;
> +
On Thu, 30 May 2019 21:20:39 +0300
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> wrote:
> +void cpsw_xdp_unreg_rxqs(struct cpsw_priv *priv)
> +{
> + struct cpsw_common *cpsw = priv->cpsw;
> + int i;
> +
> + for (i = 0; i < cpsw->rx_ch_num; i++)
> + xdp_rxq_info_unreg(&priv->xdp_rxq[i]);
> +}
On Thu, 30 May 2019 21:20:39 +0300
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> wrote:
> +int cpsw_xdp_reg_rxq(struct cpsw_priv *priv, int ch)
> +{
> + struct xdp_rxq_info *xdp_rxq = &priv->xdp_rxq[ch];
> + struct cpsw_common *cpsw = priv->cpsw;
> + int ret;
> +
> + ret = xdp_rxq_info_reg(xdp_rxq, priv->ndev, ch);
> + if (ret)
> + goto err_cleanup;
> +
> + ret = xdp_rxq_info_reg_mem_model(xdp_rxq, MEM_TYPE_PAGE_POOL,
> + cpsw->page_pool);
> + if (ret)
> + goto err_cleanup;
> +
> + return 0;
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-05-31 15:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 18:20 [PATCH v2 net-next 0/7] net: ethernet: ti: cpsw: Add XDP support Ivan Khoronzhuk
2019-05-30 18:20 ` [PATCH v2 net-next 1/7] net: page_pool: add helper function to retrieve dma addresses Ivan Khoronzhuk
2019-05-30 18:20 ` [PATCH v2 net-next 2/7] net: page_pool: add helper function to unmap " Ivan Khoronzhuk
2019-05-30 18:20 ` [PATCH v2 net-next 3/7] net: ethernet: ti: cpsw: use cpsw as drv data Ivan Khoronzhuk
2019-06-01 10:49 ` grygorii
2019-05-30 18:20 ` [PATCH v2 net-next 4/7] net: ethernet: ti: cpsw_ethtool: simplify slave loops Ivan Khoronzhuk
2019-06-01 10:55 ` grygorii
2019-05-30 18:20 ` [PATCH v2 net-next 5/7] net: ethernet: ti: davinci_cpdma: add dma mapped submit Ivan Khoronzhuk
2019-05-30 18:20 ` [PATCH v2 net-next 6/7] net: ethernet: ti: davinci_cpdma: return handler status Ivan Khoronzhuk
2019-05-30 18:20 ` [PATCH v2 net-next 7/7] net: ethernet: ti: cpsw: add XDP support Ivan Khoronzhuk
2019-05-31 15:46 ` Jesper Dangaard Brouer [this message]
2019-05-31 16:25 ` Ivan Khoronzhuk
2019-05-31 16:32 ` Jesper Dangaard Brouer
2019-05-31 17:03 ` Ivan Khoronzhuk
2019-05-31 22:08 ` Saeed Mahameed
2019-05-31 23:00 ` Ivan Khoronzhuk
2019-05-31 22:37 ` Jesper Dangaard Brouer
2019-05-31 23:27 ` Ivan Khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531174643.4be8b27f@carbon \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xdp-newbies@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).