* [PATCH] platform/chrome: cros_ec_lpc: fix semicolon.cocci warnings [not found] <201906220821.144PfQAY%lkp@intel.com> @ 2019-06-22 0:55 ` kbuild test robot 2019-06-24 15:14 ` Nick Crews 2019-06-22 0:55 ` [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings kbuild test robot 1 sibling, 1 reply; 4+ messages in thread From: kbuild test robot @ 2019-06-22 0:55 UTC (permalink / raw) To: Enric Balletbo i Serra Cc: kbuild-all, Ezequiel Garcia, Nick Crews, Benson Leung, linux-kernel From: kbuild test robot <lkp@intel.com> drivers/platform/chrome/wilco_ec/event.c:161:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime") Signed-off-by: kbuild test robot <lkp@intel.com> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next head: 9eecd07b34507de9d6a9c264d13d30e1ee5fabe8 commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/chrome/wilco_ec/event.c +++ b/drivers/platform/chrome/wilco_ec/event.c @@ -158,7 +158,7 @@ static int enqueue_events(struct acpi_de dev_err(&adev->dev, "Too many event words: %zu > %d\n", num_words, EC_ACPI_MAX_EVENT_WORDS); return -EOVERFLOW; - }; + } /* Ensure event does not overflow the available buffer */ if ((offset + event_size) > length) { ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/chrome: cros_ec_lpc: fix semicolon.cocci warnings 2019-06-22 0:55 ` [PATCH] platform/chrome: cros_ec_lpc: fix semicolon.cocci warnings kbuild test robot @ 2019-06-24 15:14 ` Nick Crews 0 siblings, 0 replies; 4+ messages in thread From: Nick Crews @ 2019-06-24 15:14 UTC (permalink / raw) To: kbuild test robot Cc: Enric Balletbo i Serra, kbuild-all, Ezequiel Garcia, Benson Leung, linux-kernel I fixed this in the new version. On Fri, Jun 21, 2019 at 6:55 PM kbuild test robot <lkp@intel.com> wrote: > > From: kbuild test robot <lkp@intel.com> > > drivers/platform/chrome/wilco_ec/event.c:161:3-4: Unneeded semicolon > > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime") > Signed-off-by: kbuild test robot <lkp@intel.com> > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next > head: 9eecd07b34507de9d6a9c264d13d30e1ee5fabe8 > commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime > > event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/platform/chrome/wilco_ec/event.c > +++ b/drivers/platform/chrome/wilco_ec/event.c > @@ -158,7 +158,7 @@ static int enqueue_events(struct acpi_de > dev_err(&adev->dev, "Too many event words: %zu > %d\n", > num_words, EC_ACPI_MAX_EVENT_WORDS); > return -EOVERFLOW; > - }; > + } > > /* Ensure event does not overflow the available buffer */ > if ((offset + event_size) > length) { ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings [not found] <201906220821.144PfQAY%lkp@intel.com> 2019-06-22 0:55 ` [PATCH] platform/chrome: cros_ec_lpc: fix semicolon.cocci warnings kbuild test robot @ 2019-06-22 0:55 ` kbuild test robot 2019-06-24 15:18 ` Nick Crews 1 sibling, 1 reply; 4+ messages in thread From: kbuild test robot @ 2019-06-22 0:55 UTC (permalink / raw) To: Enric Balletbo i Serra Cc: kbuild-all, Ezequiel Garcia, Nick Crews, Benson Leung, linux-kernel From: kbuild test robot <lkp@intel.com> drivers/platform/chrome/wilco_ec/event.c:270:1-17: WARNING: event_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. Generated by: scripts/coccinelle/api/stream_open.cocci Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime") Signed-off-by: kbuild test robot <lkp@intel.com> --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next head: 9eecd07b34507de9d6a9c264d13d30e1ee5fabe8 commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime Please take the patch only if it's a positive warning. Thanks! event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/chrome/wilco_ec/event.c +++ b/drivers/platform/chrome/wilco_ec/event.c @@ -267,7 +267,7 @@ static int event_open(struct inode *inod /* Increase refcount on device so dev_data is not freed */ get_device(&dev_data->dev); - nonseekable_open(inode, filp); + stream_open(inode, filp); filp->private_data = dev_data; return 0; ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings 2019-06-22 0:55 ` [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings kbuild test robot @ 2019-06-24 15:18 ` Nick Crews 0 siblings, 0 replies; 4+ messages in thread From: Nick Crews @ 2019-06-24 15:18 UTC (permalink / raw) To: kbuild test robot Cc: Enric Balletbo i Serra, kbuild-all, Ezequiel Garcia, Benson Leung, linux-kernel I applied this in the new version as well. On Fri, Jun 21, 2019 at 6:55 PM kbuild test robot <lkp@intel.com> wrote: > > From: kbuild test robot <lkp@intel.com> > > drivers/platform/chrome/wilco_ec/event.c:270:1-17: WARNING: event_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. > > Generated by: scripts/coccinelle/api/stream_open.cocci > > Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime") > Signed-off-by: kbuild test robot <lkp@intel.com> > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next > head: 9eecd07b34507de9d6a9c264d13d30e1ee5fabe8 > commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime > > Please take the patch only if it's a positive warning. Thanks! > > event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/platform/chrome/wilco_ec/event.c > +++ b/drivers/platform/chrome/wilco_ec/event.c > @@ -267,7 +267,7 @@ static int event_open(struct inode *inod > > /* Increase refcount on device so dev_data is not freed */ > get_device(&dev_data->dev); > - nonseekable_open(inode, filp); > + stream_open(inode, filp); > filp->private_data = dev_data; > > return 0; ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-24 15:19 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <201906220821.144PfQAY%lkp@intel.com> 2019-06-22 0:55 ` [PATCH] platform/chrome: cros_ec_lpc: fix semicolon.cocci warnings kbuild test robot 2019-06-24 15:14 ` Nick Crews 2019-06-22 0:55 ` [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings kbuild test robot 2019-06-24 15:18 ` Nick Crews
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).