[PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings

[PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings

[kbuild test robot]

From: kbuild test robot <lkp@intel.com>

drivers/platform/chrome/wilco_ec/event.c:270:1-17: WARNING: event_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

Generated by: scripts/coccinelle/api/stream_open.cocci

Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime")
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
head:   9eecd07b34507de9d6a9c264d13d30e1ee5fabe8
commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

Please take the patch only if it's a positive warning. Thanks!

 event.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/platform/chrome/wilco_ec/event.c
+++ b/drivers/platform/chrome/wilco_ec/event.c
@@ -267,7 +267,7 @@ static int event_open(struct inode *inod
 
 	/* Increase refcount on device so dev_data is not freed */
 	get_device(&dev_data->dev);
-	nonseekable_open(inode, filp);
+	stream_open(inode, filp);
 	filp->private_data = dev_data;
 
 	return 0;

[PATCH] platform/chrome: cros_ec_lpc: fix semicolon.cocci warnings

[kbuild test robot]

From: kbuild test robot <lkp@intel.com>

drivers/platform/chrome/wilco_ec/event.c:161:3-4: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime")
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
head:   9eecd07b34507de9d6a9c264d13d30e1ee5fabe8
commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

 event.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/platform/chrome/wilco_ec/event.c
+++ b/drivers/platform/chrome/wilco_ec/event.c
@@ -158,7 +158,7 @@ static int enqueue_events(struct acpi_de
 			dev_err(&adev->dev, "Too many event words: %zu > %d\n",
 				num_words, EC_ACPI_MAX_EVENT_WORDS);
 			return -EOVERFLOW;
-		};
+		}
 
 		/* Ensure event does not overflow the available buffer */
 		if ((offset + event_size) > length) {

Re: [PATCH] platform/chrome: cros_ec_lpc: fix semicolon.cocci warnings

[Nick Crews]

I fixed this in the new version.

On Fri, Jun 21, 2019 at 6:55 PM kbuild test robot <lkp@intel.com> wrote:
>
> From: kbuild test robot <lkp@intel.com>
>
> drivers/platform/chrome/wilco_ec/event.c:161:3-4: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
> head:   9eecd07b34507de9d6a9c264d13d30e1ee5fabe8
> commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime
>
>  event.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/platform/chrome/wilco_ec/event.c
> +++ b/drivers/platform/chrome/wilco_ec/event.c
> @@ -158,7 +158,7 @@ static int enqueue_events(struct acpi_de
>                         dev_err(&adev->dev, "Too many event words: %zu > %d\n",
>                                 num_words, EC_ACPI_MAX_EVENT_WORDS);
>                         return -EOVERFLOW;
> -               };
> +               }
>
>                 /* Ensure event does not overflow the available buffer */
>                 if ((offset + event_size) > length) {

Re: [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings

[Nick Crews]

I applied this in the new version as well.

On Fri, Jun 21, 2019 at 6:55 PM kbuild test robot <lkp@intel.com> wrote:
>
> From: kbuild test robot <lkp@intel.com>
>
> drivers/platform/chrome/wilco_ec/event.c:270:1-17: WARNING: event_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.
>
> Generated by: scripts/coccinelle/api/stream_open.cocci
>
> Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
> head:   9eecd07b34507de9d6a9c264d13d30e1ee5fabe8
> commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime
>
> Please take the patch only if it's a positive warning. Thanks!
>
>  event.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/platform/chrome/wilco_ec/event.c
> +++ b/drivers/platform/chrome/wilco_ec/event.c
> @@ -267,7 +267,7 @@ static int event_open(struct inode *inod
>
>         /* Increase refcount on device so dev_data is not freed */
>         get_device(&dev_data->dev);
> -       nonseekable_open(inode, filp);
> +       stream_open(inode, filp);
>         filp->private_data = dev_data;
>
>         return 0;