* [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
@ 2019-01-21 17:15 Eddie James
2019-06-17 2:08 ` Alistair Popple
0 siblings, 1 reply; 6+ messages in thread
From: Eddie James @ 2019-01-21 17:15 UTC (permalink / raw)
To: linux-kernel, openbmc; +Cc: joel, andrew, benh, Eddie James
SBE fifo operations should be allowed while the SBE is in any of the
"IPL" states. Operations should succeed in this state.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
drivers/fsi/fsi-sbefifo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index c7d13ac..f7665b3 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo)
switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >> CFAM_SBM_SBE_STATE_SHIFT) {
case SBE_STATE_UNKNOWN:
return -ESHUTDOWN;
+ case SBE_STATE_DMT:
+ return -EBUSY;
case SBE_STATE_IPLING:
case SBE_STATE_ISTEP:
case SBE_STATE_MPIPL:
- case SBE_STATE_DMT:
- return -EBUSY;
case SBE_STATE_RUNTIME:
case SBE_STATE_DUMP: /* Not sure about that one */
break;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
2019-01-21 17:15 [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state Eddie James
@ 2019-06-17 2:08 ` Alistair Popple
2019-06-17 5:41 ` Joel Stanley
0 siblings, 1 reply; 6+ messages in thread
From: Alistair Popple @ 2019-06-17 2:08 UTC (permalink / raw)
To: openbmc; +Cc: Eddie James, linux-kernel, andrew
This fixed the problem I was having trying to issue istep operations to the
SBE.
Tested-by: Alistair Popple <alistair@popple.id.au>
On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> SBE fifo operations should be allowed while the SBE is in any of the
> "IPL" states. Operations should succeed in this state.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> drivers/fsi/fsi-sbefifo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index c7d13ac..f7665b3 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
> *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
> CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:
> return -ESHUTDOWN;
> + case SBE_STATE_DMT:
> + return -EBUSY;
> case SBE_STATE_IPLING:
> case SBE_STATE_ISTEP:
> case SBE_STATE_MPIPL:
> - case SBE_STATE_DMT:
> - return -EBUSY;
> case SBE_STATE_RUNTIME:
> case SBE_STATE_DUMP: /* Not sure about that one */
> break;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
2019-06-17 2:08 ` Alistair Popple
@ 2019-06-17 5:41 ` Joel Stanley
2019-06-25 4:35 ` Joel Stanley
0 siblings, 1 reply; 6+ messages in thread
From: Joel Stanley @ 2019-06-17 5:41 UTC (permalink / raw)
To: Alistair Popple, Greg KH
Cc: OpenBMC Maillist, Andrew Jeffery, Eddie James, Linux Kernel Mailing List
On Mon, 17 Jun 2019 at 02:09, Alistair Popple <alistair@popple.id.au> wrote:
>
> On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> > SBE fifo operations should be allowed while the SBE is in any of the
> > "IPL" states. Operations should succeed in this state.
> >
> > Signed-off-by: Eddie James <eajames@linux.ibm.com>
>
> This fixed the problem I was having trying to issue istep operations to the
> SBE.
>
> Tested-by: Alistair Popple <alistair@popple.id.au>
This one slipped through the cracks.
Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO
Reviewed-by: Joel Stanley <joel@jsm.id.au>
Greg, can you please queue this one up for 5.3?
Cheers,
Joel
> > ---
> > drivers/fsi/fsi-sbefifo.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> > index c7d13ac..f7665b3 100644
> > --- a/drivers/fsi/fsi-sbefifo.c
> > +++ b/drivers/fsi/fsi-sbefifo.c
> > @@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
> > *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
> > CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:
> > return -ESHUTDOWN;
> > + case SBE_STATE_DMT:
> > + return -EBUSY;
> > case SBE_STATE_IPLING:
> > case SBE_STATE_ISTEP:
> > case SBE_STATE_MPIPL:
> > - case SBE_STATE_DMT:
> > - return -EBUSY;
> > case SBE_STATE_RUNTIME:
> > case SBE_STATE_DUMP: /* Not sure about that one */
> > break;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
2019-06-17 5:41 ` Joel Stanley
@ 2019-06-25 4:35 ` Joel Stanley
2019-06-25 7:24 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Joel Stanley @ 2019-06-25 4:35 UTC (permalink / raw)
To: Alistair Popple, Greg KH
Cc: OpenBMC Maillist, Andrew Jeffery, Eddie James, Linux Kernel Mailing List
Hi Greg,
On Mon, 17 Jun 2019 at 05:41, Joel Stanley <joel@jms.id.au> wrote:
>
> On Mon, 17 Jun 2019 at 02:09, Alistair Popple <alistair@popple.id.au> wrote:
> >
> > On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> > > SBE fifo operations should be allowed while the SBE is in any of the
> > > "IPL" states. Operations should succeed in this state.
> > >
> > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> >
> > This fixed the problem I was having trying to issue istep operations to the
> > SBE.
> >
> > Tested-by: Alistair Popple <alistair@popple.id.au>
>
> This one slipped through the cracks.
>
> Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO
> Reviewed-by: Joel Stanley <joel@jsm.id.au>
>
> Greg, can you please queue this one up for 5.3?
Ping?
>
> Cheers,
>
> Joel
>
> > > ---
> > > drivers/fsi/fsi-sbefifo.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> > > index c7d13ac..f7665b3 100644
> > > --- a/drivers/fsi/fsi-sbefifo.c
> > > +++ b/drivers/fsi/fsi-sbefifo.c
> > > @@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
> > > *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
> > > CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:
> > > return -ESHUTDOWN;
> > > + case SBE_STATE_DMT:
> > > + return -EBUSY;
> > > case SBE_STATE_IPLING:
> > > case SBE_STATE_ISTEP:
> > > case SBE_STATE_MPIPL:
> > > - case SBE_STATE_DMT:
> > > - return -EBUSY;
> > > case SBE_STATE_RUNTIME:
> > > case SBE_STATE_DUMP: /* Not sure about that one */
> > > break;
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
2019-06-25 4:35 ` Joel Stanley
@ 2019-06-25 7:24 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2019-06-25 7:24 UTC (permalink / raw)
To: Joel Stanley
Cc: Alistair Popple, OpenBMC Maillist, Andrew Jeffery, Eddie James,
Linux Kernel Mailing List
On Tue, Jun 25, 2019 at 04:35:50AM +0000, Joel Stanley wrote:
> Hi Greg,
>
> On Mon, 17 Jun 2019 at 05:41, Joel Stanley <joel@jms.id.au> wrote:
> >
> > On Mon, 17 Jun 2019 at 02:09, Alistair Popple <alistair@popple.id.au> wrote:
> > >
> > > On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> > > > SBE fifo operations should be allowed while the SBE is in any of the
> > > > "IPL" states. Operations should succeed in this state.
> > > >
> > > > Signed-off-by: Eddie James <eajames@linux.ibm.com>
> > >
> > > This fixed the problem I was having trying to issue istep operations to the
> > > SBE.
> > >
> > > Tested-by: Alistair Popple <alistair@popple.id.au>
> >
> > This one slipped through the cracks.
> >
> > Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO
> > Reviewed-by: Joel Stanley <joel@jsm.id.au>
> >
> > Greg, can you please queue this one up for 5.3?
>
> Ping?
I don't see this in my queue at all, sorry. Can someone resend it in a
format that I can apply it in with the needed tested-by and reviewed-by
added to it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
@ 2019-06-26 18:56 Eddie James
0 siblings, 0 replies; 6+ messages in thread
From: Eddie James @ 2019-06-26 18:56 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, joel, andrew, Eddie James
SBE fifo operations should be allowed while the SBE is in any of the
"IPL" states. Operations should succeed in this state.
Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO
Reviewed-by: Joel Stanley <joel@jms.id.au>
Tested-by: Alistair Popple <alistair@popple.id.au>
Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
drivers/fsi/fsi-sbefifo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index d92f5b8..f54df9e 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -289,11 +289,11 @@ static int sbefifo_check_sbe_state(struct sbefifo *sbefifo)
switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >> CFAM_SBM_SBE_STATE_SHIFT) {
case SBE_STATE_UNKNOWN:
return -ESHUTDOWN;
+ case SBE_STATE_DMT:
+ return -EBUSY;
case SBE_STATE_IPLING:
case SBE_STATE_ISTEP:
case SBE_STATE_MPIPL:
- case SBE_STATE_DMT:
- return -EBUSY;
case SBE_STATE_RUNTIME:
case SBE_STATE_DUMP: /* Not sure about that one */
break;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-26 18:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-21 17:15 [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state Eddie James
2019-06-17 2:08 ` Alistair Popple
2019-06-17 5:41 ` Joel Stanley
2019-06-25 4:35 ` Joel Stanley
2019-06-25 7:24 ` Greg KH
2019-06-26 18:56 Eddie James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).