linux-next: Fixes tag needs some work in the hyperv-fixes tree

linux-next: Fixes tag needs some work in the hyperv-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi all,

In commit

  2e6d7851bdeb ("PCI: pci-hyperv: fix build errors on non-SYSFS config")

Fixes tag

  Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also do not
include blank lines among the tag lines.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the hyperv-fixes tree

[Randy Dunlap]

On 7/14/19 5:55 AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   2e6d7851bdeb ("PCI: pci-hyperv: fix build errors on non-SYSFS config")
> 
> Fixes tag
> 
>   Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot

oops, copy-paste error.

> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.  Also do not
> include blank lines among the tag lines.

Hm, so you are saying that the Fixes: line should not be separated from the
other tag lines?  That's news to me...
Should Fixes: be before the other tag lines or does it matter?

thanks.
-- 
~Randy

Re: linux-next: Fixes tag needs some work in the hyperv-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi Randy,

On Sun, 14 Jul 2019 08:02:11 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> > Please do not split Fixes tags over more than one line.  Also do not
> > include blank lines among the tag lines.  
> 
> Hm, so you are saying that the Fixes: line should not be separated from the
> other tag lines?  That's news to me...

see "git interpret-trailers".

> Should Fixes: be before the other tag lines or does it matter?

I don't think that matters, but first seems most used.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the hyperv-fixes tree

[Sasha Levin]

On Mon, Jul 15, 2019 at 08:01:59AM +1000, Stephen Rothwell wrote:
>Hi Randy,
>
>On Sun, 14 Jul 2019 08:02:11 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> > Please do not split Fixes tags over more than one line.  Also do not
>> > include blank lines among the tag lines.
>>
>> Hm, so you are saying that the Fixes: line should not be separated from the
>> other tag lines?  That's news to me...
>
>see "git interpret-trailers".

Stephen,

Thanks for pointing it out, I've fixed it up. And thanks for pointing
out git-interpret-trailers, I wasn't familiar with that.

--
Thanks,
Sasha