* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). [not found] ` <20190706144204.15652de7@heffalump.sk2.org> @ 2019-07-22 17:50 ` Kees Cook 2019-07-22 17:59 ` Joe Perches 0 siblings, 1 reply; 11+ messages in thread From: Kees Cook @ 2019-07-22 17:50 UTC (permalink / raw) To: Stephen Kitt Cc: Nitin Gote, jannh, kernel-hardening, Joe Perches, corbet, linux-kernel, Rasmus Villemoes On Sat, Jul 06, 2019 at 02:42:04PM +0200, Stephen Kitt wrote: > On Tue, 2 Jul 2019 10:25:04 -0700, Kees Cook <keescook@chromium.org> wrote: > > On Sat, Jun 29, 2019 at 06:15:37PM +0200, Stephen Kitt wrote: > > > On Fri, 28 Jun 2019 17:25:48 +0530, Nitin Gote <nitin.r.gote@intel.com> > > > wrote: > > > > 1. Deprecate strcpy() in favor of strscpy(). > > > > > > This isn’t a comment “against” this patch, but something I’ve been > > > wondering recently and which raises a question about how to handle > > > strcpy’s deprecation in particular. There is still one scenario where > > > strcpy is useful: when GCC replaces it with its builtin, inline version... > > > > > > Would it be worth introducing a macro for strcpy-from-constant-string, > > > which would check that GCC’s builtin is being used (when building with > > > GCC), and fall back to strscpy otherwise? > > > > How would you suggest it operate? A separate API, or something like the > > existing overloaded strcpy() macros in string.h? > > The latter; in my mind the point is to simplify the thought process for > developers, so strscpy should be the “obvious” choice in all cases, even when > dealing with constant strings in hot paths. Something like > > __FORTIFY_INLINE ssize_t strscpy(char *dest, const char *src, size_t count) > { > size_t dest_size = __builtin_object_size(dest, 0); > size_t src_size = __builtin_object_size(src, 0); > if (__builtin_constant_p(count) && > __builtin_constant_p(src_size) && > __builtin_constant_p(dest_size) && > src_size <= count && > src_size <= dest_size && > src[src_size - 1] == '\0') { > strcpy(dest, src); > return src_size - 1; > } else { > return __strscpy(dest, src, count); > } > } > > with the current strscpy renamed to __strscpy. I imagine it’s not necessary > to tie this to FORTIFY — __OPTIMIZE__ should be sufficient, shouldn’t it? > Although building on top of the fortified strcpy is reassuring, and I might > be missing something. I’m also not sure how to deal with the backing strscpy: > weak symbol, or something else... At least there aren’t (yet) any > arch-specific implementations of strscpy to deal with, but obviously they’d > still need to be supportable. > > In my tests, this all gets optimised away, and we end up with code such as > > strscpy(raead.type, "aead", sizeof(raead.type)); > > being compiled down to > > movl $1684104545, 4(%rsp) > > on x86-64, and non-constant code being compiled down to a direct __strscpy > call. Thanks for the details! Yeah, that seems nice. I wonder if there is a sensible way to combine these also with the stracpy*() proposal[1], so the call in your example above could just be: stracpy(raead.type, "aead"); (It seems both proposals together would have the correct result...) [1] https://lkml.kernel.org/r/201907221031.8B87A9DE@keescook -- Kees Cook ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-22 17:50 ` [PATCH] checkpatch: Added warnings in favor of strscpy() Kees Cook @ 2019-07-22 17:59 ` Joe Perches 2019-07-22 21:01 ` Stephen Kitt 0 siblings, 1 reply; 11+ messages in thread From: Joe Perches @ 2019-07-22 17:59 UTC (permalink / raw) To: Kees Cook, Stephen Kitt Cc: Nitin Gote, jannh, kernel-hardening, corbet, linux-kernel, Rasmus Villemoes On Mon, 2019-07-22 at 10:50 -0700, Kees Cook wrote: > On Sat, Jul 06, 2019 at 02:42:04PM +0200, Stephen Kitt wrote: > > On Tue, 2 Jul 2019 10:25:04 -0700, Kees Cook <keescook@chromium.org> wrote: > > > On Sat, Jun 29, 2019 at 06:15:37PM +0200, Stephen Kitt wrote: > > > > On Fri, 28 Jun 2019 17:25:48 +0530, Nitin Gote <nitin.r.gote@intel.com> > > > > wrote: > > > > > 1. Deprecate strcpy() in favor of strscpy(). > > > > > > > > This isn’t a comment “against” this patch, but something I’ve been > > > > wondering recently and which raises a question about how to handle > > > > strcpy’s deprecation in particular. There is still one scenario where > > > > strcpy is useful: when GCC replaces it with its builtin, inline version... > > > > > > > > Would it be worth introducing a macro for strcpy-from-constant-string, > > > > which would check that GCC’s builtin is being used (when building with > > > > GCC), and fall back to strscpy otherwise? > > > > > > How would you suggest it operate? A separate API, or something like the > > > existing overloaded strcpy() macros in string.h? > > > > The latter; in my mind the point is to simplify the thought process for > > developers, so strscpy should be the “obvious” choice in all cases, even when > > dealing with constant strings in hot paths. Something like > > > > __FORTIFY_INLINE ssize_t strscpy(char *dest, const char *src, size_t count) > > { > > size_t dest_size = __builtin_object_size(dest, 0); > > size_t src_size = __builtin_object_size(src, 0); > > if (__builtin_constant_p(count) && > > __builtin_constant_p(src_size) && > > __builtin_constant_p(dest_size) && > > src_size <= count && > > src_size <= dest_size && > > src[src_size - 1] == '\0') { > > strcpy(dest, src); > > return src_size - 1; > > } else { > > return __strscpy(dest, src, count); > > } > > } > > > > with the current strscpy renamed to __strscpy. I imagine it’s not necessary > > to tie this to FORTIFY — __OPTIMIZE__ should be sufficient, shouldn’t it? > > Although building on top of the fortified strcpy is reassuring, and I might > > be missing something. I’m also not sure how to deal with the backing strscpy: > > weak symbol, or something else... At least there aren’t (yet) any > > arch-specific implementations of strscpy to deal with, but obviously they’d > > still need to be supportable. > > > > In my tests, this all gets optimised away, and we end up with code such as > > > > strscpy(raead.type, "aead", sizeof(raead.type)); > > > > being compiled down to > > > > movl $1684104545, 4(%rsp) > > > > on x86-64, and non-constant code being compiled down to a direct __strscpy > > call. > > Thanks for the details! Yeah, that seems nice. I wonder if there is a > sensible way to combine these also with the stracpy*() proposal[1], so the > call in your example above could just be: > > stracpy(raead.type, "aead"); > > (It seems both proposals together would have the correct result...) > > [1] https://lkml.kernel.org/r/201907221031.8B87A9DE@keescook Easy enough to do. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-22 17:59 ` Joe Perches @ 2019-07-22 21:01 ` Stephen Kitt 2019-07-22 21:50 ` Joe Perches 0 siblings, 1 reply; 11+ messages in thread From: Stephen Kitt @ 2019-07-22 21:01 UTC (permalink / raw) To: Joe Perches Cc: Kees Cook, Nitin Gote, jannh, kernel-hardening, corbet, linux-kernel, Rasmus Villemoes [-- Attachment #1: Type: text/plain, Size: 3573 bytes --] On Mon, 22 Jul 2019 10:59:00 -0700, Joe Perches <joe@perches.com> wrote: > On Mon, 2019-07-22 at 10:50 -0700, Kees Cook wrote: > > On Sat, Jul 06, 2019 at 02:42:04PM +0200, Stephen Kitt wrote: > > > On Tue, 2 Jul 2019 10:25:04 -0700, Kees Cook <keescook@chromium.org> > > > wrote: > > > > On Sat, Jun 29, 2019 at 06:15:37PM +0200, Stephen Kitt wrote: > > > > > On Fri, 28 Jun 2019 17:25:48 +0530, Nitin Gote > > > > > <nitin.r.gote@intel.com> wrote: > > > > > > 1. Deprecate strcpy() in favor of strscpy(). > > > > > > > > > > This isn’t a comment “against” this patch, but something I’ve been > > > > > wondering recently and which raises a question about how to handle > > > > > strcpy’s deprecation in particular. There is still one scenario > > > > > where strcpy is useful: when GCC replaces it with its builtin, > > > > > inline version... > > > > > > > > > > Would it be worth introducing a macro for > > > > > strcpy-from-constant-string, which would check that GCC’s builtin > > > > > is being used (when building with GCC), and fall back to strscpy > > > > > otherwise? > > > > > > > > How would you suggest it operate? A separate API, or something like > > > > the existing overloaded strcpy() macros in string.h? > > > > > > The latter; in my mind the point is to simplify the thought process for > > > developers, so strscpy should be the “obvious” choice in all cases, > > > even when dealing with constant strings in hot paths. Something like > > > > > > __FORTIFY_INLINE ssize_t strscpy(char *dest, const char *src, size_t > > > count) { > > > size_t dest_size = __builtin_object_size(dest, 0); > > > size_t src_size = __builtin_object_size(src, 0); > > > if (__builtin_constant_p(count) && > > > __builtin_constant_p(src_size) && > > > __builtin_constant_p(dest_size) && > > > src_size <= count && > > > src_size <= dest_size && > > > src[src_size - 1] == '\0') { > > > strcpy(dest, src); > > > return src_size - 1; > > > } else { > > > return __strscpy(dest, src, count); > > > } > > > } > > > > > > with the current strscpy renamed to __strscpy. I imagine it’s not > > > necessary to tie this to FORTIFY — __OPTIMIZE__ should be sufficient, > > > shouldn’t it? Although building on top of the fortified strcpy is > > > reassuring, and I might be missing something. I’m also not sure how to > > > deal with the backing strscpy: weak symbol, or something else... At > > > least there aren’t (yet) any arch-specific implementations of strscpy > > > to deal with, but obviously they’d still need to be supportable. > > > > > > In my tests, this all gets optimised away, and we end up with code such > > > as > > > > > > strscpy(raead.type, "aead", sizeof(raead.type)); > > > > > > being compiled down to > > > > > > movl $1684104545, 4(%rsp) > > > > > > on x86-64, and non-constant code being compiled down to a direct > > > __strscpy call. > > > > Thanks for the details! Yeah, that seems nice. I wonder if there is a > > sensible way to combine these also with the stracpy*() proposal[1], so the > > call in your example above could just be: > > > > stracpy(raead.type, "aead"); > > > > (It seems both proposals together would have the correct result...) > > > > [1] https://lkml.kernel.org/r/201907221031.8B87A9DE@keescook > > Easy enough to do. How about you submit your current patch set, and I follow up with the above adapted to stracpy? Regards, Stephen [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-22 21:01 ` Stephen Kitt @ 2019-07-22 21:50 ` Joe Perches 2019-07-22 21:57 ` Jonathan Corbet 0 siblings, 1 reply; 11+ messages in thread From: Joe Perches @ 2019-07-22 21:50 UTC (permalink / raw) To: Stephen Kitt Cc: Kees Cook, Nitin Gote, jannh, kernel-hardening, corbet, linux-kernel, Rasmus Villemoes On Mon, 2019-07-22 at 23:01 +0200, Stephen Kitt wrote: > How about you submit your current patch set, and I follow up with the above > adapted to stracpy? OK, I will shortly after I figure out how to add kernel-doc for stracpy/stracpy_pad to lib/string.c. It doesn't seem appropriate to add the kernel-doc to string.h as it would be separated from the others in string.c Anyone got a clue here? Jonathan? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-22 21:50 ` Joe Perches @ 2019-07-22 21:57 ` Jonathan Corbet 2019-07-22 22:24 ` Joe Perches 0 siblings, 1 reply; 11+ messages in thread From: Jonathan Corbet @ 2019-07-22 21:57 UTC (permalink / raw) To: Joe Perches Cc: Stephen Kitt, Kees Cook, Nitin Gote, jannh, kernel-hardening, linux-kernel, Rasmus Villemoes On Mon, 22 Jul 2019 14:50:09 -0700 Joe Perches <joe@perches.com> wrote: > On Mon, 2019-07-22 at 23:01 +0200, Stephen Kitt wrote: > > How about you submit your current patch set, and I follow up with the above > > adapted to stracpy? > > OK, I will shortly after I figure out how to add kernel-doc > for stracpy/stracpy_pad to lib/string.c. > > It doesn't seem appropriate to add the kernel-doc to string.h > as it would be separated from the others in string.c > > Anyone got a clue here? Jonathan? If the functions themselves are fully defined in the .h file, I'd just add the kerneldoc there as well. That's how it's usually done, and you want to keep the documentation and the prototypes together. jon ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-22 21:57 ` Jonathan Corbet @ 2019-07-22 22:24 ` Joe Perches 2019-07-22 22:28 ` Jonathan Corbet 0 siblings, 1 reply; 11+ messages in thread From: Joe Perches @ 2019-07-22 22:24 UTC (permalink / raw) To: Jonathan Corbet Cc: Stephen Kitt, Kees Cook, Nitin Gote, jannh, kernel-hardening, linux-kernel, Rasmus Villemoes On Mon, 2019-07-22 at 15:57 -0600, Jonathan Corbet wrote: > On Mon, 22 Jul 2019 14:50:09 -0700 > Joe Perches <joe@perches.com> wrote: > > > On Mon, 2019-07-22 at 23:01 +0200, Stephen Kitt wrote: > > > How about you submit your current patch set, and I follow up with the above > > > adapted to stracpy? > > > > OK, I will shortly after I figure out how to add kernel-doc > > for stracpy/stracpy_pad to lib/string.c. > > > > It doesn't seem appropriate to add the kernel-doc to string.h > > as it would be separated from the others in string.c > > > > Anyone got a clue here? Jonathan? > > If the functions themselves are fully defined in the .h file, I'd just add > the kerneldoc there as well. That's how it's usually done, and you want > to keep the documentation and the prototypes together. In this case, it's a macro and yes, the kernel-doc could easily be set around the macro in the .h, but my desire is to keep all the string function kernel-doc output together so it should be added to lib/string.c Are you suggesting I move all the lib/string.c kernel-doc to include/linux/string.h ? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-22 22:24 ` Joe Perches @ 2019-07-22 22:28 ` Jonathan Corbet 2019-07-22 22:35 ` Joe Perches 2019-07-24 11:41 ` Joe Perches 0 siblings, 2 replies; 11+ messages in thread From: Jonathan Corbet @ 2019-07-22 22:28 UTC (permalink / raw) To: Joe Perches Cc: Stephen Kitt, Kees Cook, Nitin Gote, jannh, kernel-hardening, linux-kernel, Rasmus Villemoes On Mon, 22 Jul 2019 15:24:33 -0700 Joe Perches <joe@perches.com> wrote: > > If the functions themselves are fully defined in the .h file, I'd just add > > the kerneldoc there as well. That's how it's usually done, and you want > > to keep the documentation and the prototypes together. > > In this case, it's a macro and yes, the kernel-doc could > easily be set around the macro in the .h, but my desire > is to keep all the string function kernel-doc output > together so it should be added to lib/string.c > > Are you suggesting I move all the lib/string.c kernel-doc > to include/linux/string.h ? If you want the *output* together, just put the kernel-doc directives together in the RST file that pulls it all in. Or am I missing something here? Thanks, jon ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-22 22:28 ` Jonathan Corbet @ 2019-07-22 22:35 ` Joe Perches 2019-07-24 11:41 ` Joe Perches 1 sibling, 0 replies; 11+ messages in thread From: Joe Perches @ 2019-07-22 22:35 UTC (permalink / raw) To: Jonathan Corbet Cc: Stephen Kitt, Kees Cook, Nitin Gote, jannh, kernel-hardening, linux-kernel, Rasmus Villemoes On Mon, 2019-07-22 at 16:28 -0600, Jonathan Corbet wrote: > On Mon, 22 Jul 2019 15:24:33 -0700 > Joe Perches <joe@perches.com> wrote: > > > > If the functions themselves are fully defined in the .h file, I'd just add > > > the kerneldoc there as well. That's how it's usually done, and you want > > > to keep the documentation and the prototypes together. > > > > In this case, it's a macro and yes, the kernel-doc could > > easily be set around the macro in the .h, but my desire > > is to keep all the string function kernel-doc output > > together so it should be added to lib/string.c > > > > Are you suggesting I move all the lib/string.c kernel-doc > > to include/linux/string.h ? > > If you want the *output* together, just put the kernel-doc directives > together in the RST file that pulls it all in. Or am I missing something > here? Nah, it's me. I'm not particularly up to date on .rst file usage. Thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-22 22:28 ` Jonathan Corbet 2019-07-22 22:35 ` Joe Perches @ 2019-07-24 11:41 ` Joe Perches 1 sibling, 0 replies; 11+ messages in thread From: Joe Perches @ 2019-07-24 11:41 UTC (permalink / raw) To: Jonathan Corbet Cc: Stephen Kitt, Kees Cook, Nitin Gote, jannh, kernel-hardening, linux-kernel, Rasmus Villemoes On Mon, 2019-07-22 at 16:28 -0600, Jonathan Corbet wrote: > On Mon, 22 Jul 2019 15:24:33 -0700 > Joe Perches <joe@perches.com> wrote: > > > > If the functions themselves are fully defined in the .h file, I'd just add > > > the kerneldoc there as well. That's how it's usually done, and you want > > > to keep the documentation and the prototypes together. > > > > In this case, it's a macro and yes, the kernel-doc could > > easily be set around the macro in the .h, but my desire > > is to keep all the string function kernel-doc output > > together so it should be added to lib/string.c > > > > Are you suggesting I move all the lib/string.c kernel-doc > > to include/linux/string.h ? > > If you want the *output* together, just put the kernel-doc directives > together in the RST file that pulls it all in. Or am I missing something > here? The negative of the kernel-doc separation of prototypes by .h and .c files is that the ordering of the functions in the .rst outout files doesn't make much logical sense. stracpy is pretty far away from strscpy in the list of functions. ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] checkpatch: Added warnings in favor of strscpy(). @ 2019-07-04 5:54 Nitin Gote 2019-07-04 20:46 ` Joe Perches 0 siblings, 1 reply; 11+ messages in thread From: Nitin Gote @ 2019-07-04 5:54 UTC (permalink / raw) To: akpm Cc: corbet, apw, joe, keescook, linux-doc, linux-kernel, kernel-hardening, Nitin Gote Added warnings in checkpatch.pl script to : 1. Deprecate strcpy() in favor of strscpy(). 2. Deprecate strlcpy() in favor of strscpy(). 3. Deprecate strncpy() in favor of strscpy() or strscpy_pad(). Updated strncpy() section in Documentation/process/deprecated.rst to cover strscpy_pad() case. Signed-off-by: Nitin Gote <nitin.r.gote@intel.com> --- This patch is already reviewed by mailing list kernel-hardening@lists.openwall.com. Refer below link <https://www.openwall.com/lists/kernel-hardening/2019/07/03/4> Acked-by: Kees Cook <keescook@chromium.org> Documentation/process/deprecated.rst | 6 +++--- scripts/checkpatch.pl | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/process/deprecated.rst b/Documentation/process/deprecated.rst index 49e0f64..f564de3 100644 --- a/Documentation/process/deprecated.rst +++ b/Documentation/process/deprecated.rst @@ -93,9 +93,9 @@ will be NUL terminated. This can lead to various linear read overflows and other misbehavior due to the missing termination. It also NUL-pads the destination buffer if the source contents are shorter than the destination buffer size, which may be a needless performance penalty for callers using -only NUL-terminated strings. The safe replacement is :c:func:`strscpy`. -(Users of :c:func:`strscpy` still needing NUL-padding will need an -explicit :c:func:`memset` added.) +only NUL-terminated strings. In this case, the safe replacement is +:c:func:`strscpy`. If, however, the destination buffer still needs +NUL-padding, the safe replacement is :c:func:`strscpy_pad`. If a caller is using non-NUL-terminated strings, :c:func:`strncpy()` can still be used, but destinations should be marked with the `__nonstring diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 342c7c7..3d80967 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -595,6 +595,11 @@ our %deprecated_apis = ( "rcu_barrier_sched" => "rcu_barrier", "get_state_synchronize_sched" => "get_state_synchronize_rcu", "cond_synchronize_sched" => "cond_synchronize_rcu", + "strcpy" => "strscpy", + "strlcpy" => "strscpy", + "strncpy" => "strscpy, strscpy_pad or for + non-NUL-terminated strings, strncpy() can still be used, but + destinations should be marked with the __nonstring", ); #Create a search pattern for all these strings to speed up a loop below -- 2.7.4 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] checkpatch: Added warnings in favor of strscpy(). 2019-07-04 5:54 Nitin Gote @ 2019-07-04 20:46 ` Joe Perches 0 siblings, 0 replies; 11+ messages in thread From: Joe Perches @ 2019-07-04 20:46 UTC (permalink / raw) To: Nitin Gote, akpm Cc: corbet, apw, keescook, linux-doc, linux-kernel, kernel-hardening On Thu, 2019-07-04 at 11:24 +0530, Nitin Gote wrote: > Added warnings in checkpatch.pl script to : > > 1. Deprecate strcpy() in favor of strscpy(). > 2. Deprecate strlcpy() in favor of strscpy(). > 3. Deprecate strncpy() in favor of strscpy() or strscpy_pad(). > > Updated strncpy() section in Documentation/process/deprecated.rst > to cover strscpy_pad() case. > > Signed-off-by: Nitin Gote <nitin.r.gote@intel.com> OK, for whatever reason, this when into a spam folder. > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -595,6 +595,11 @@ our %deprecated_apis = ( > "rcu_barrier_sched" => "rcu_barrier", > "get_state_synchronize_sched" => "get_state_synchronize_rcu", > "cond_synchronize_sched" => "cond_synchronize_rcu", > + "strcpy" => "strscpy", > + "strlcpy" => "strscpy", > + "strncpy" => "strscpy, strscpy_pad or for > + non-NUL-terminated strings, strncpy() can still be used, but > + destinations should be marked with the __nonstring", > ); $ git grep -w strcpy | wc -l 2239 $ git grep -w strlcpy | wc -l 1760 $ git grep -w strncpy | wc -l 839 These functions are _really_ commonly used in the kernel. This should probably be a different %deprecated_string_api and these should probably not be emitted at WARN level when using command line option -f/--file but at CHECK level so that novice script users just don't send bad patches. Also, perhaps there could be some macro for the relatively commonly used strscpy(foo, bar, sizeof(foo)) and strlcpy(foo, bar, sizeof(foo)) so argument 1 doesn't have to be repeated in the sizeof() Something like: #define stracpy(to, from) \ ({ \ size_t size = ARRAY_SIZE(to); \ BUILD_BUG_ON(!__same_type(typeof(*to), char)); \ \ strscpy(to, from, size); \ }) ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-07-24 11:41 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <1561722948-28289-1-git-send-email-nitin.r.gote@intel.com> [not found] ` <20190629181537.7d524f7d@sk2.org> [not found] ` <201907021024.D1C8E7B2D@keescook> [not found] ` <20190706144204.15652de7@heffalump.sk2.org> 2019-07-22 17:50 ` [PATCH] checkpatch: Added warnings in favor of strscpy() Kees Cook 2019-07-22 17:59 ` Joe Perches 2019-07-22 21:01 ` Stephen Kitt 2019-07-22 21:50 ` Joe Perches 2019-07-22 21:57 ` Jonathan Corbet 2019-07-22 22:24 ` Joe Perches 2019-07-22 22:28 ` Jonathan Corbet 2019-07-22 22:35 ` Joe Perches 2019-07-24 11:41 ` Joe Perches 2019-07-04 5:54 Nitin Gote 2019-07-04 20:46 ` Joe Perches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).