[PATCH] regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator

[PATCH] regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator

[Axel Lin]

Setting .n_voltages = 1 and .fixed_uV is enough for fixed regulator,
remove the redundant .min_uV and .list_voltage settings.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/regulator/stm32-booster.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/regulator/stm32-booster.c b/drivers/regulator/stm32-booster.c
index 2a897666c650..03f162ffd144 100644
--- a/drivers/regulator/stm32-booster.c
+++ b/drivers/regulator/stm32-booster.c
@@ -20,7 +20,6 @@
 #define STM32MP1_SYSCFG_EN_BOOSTER_MASK	BIT(8)
 
 static const struct regulator_ops stm32h7_booster_ops = {
-	.list_voltage	= regulator_list_voltage_linear,
 	.enable		= regulator_enable_regmap,
 	.disable	= regulator_disable_regmap,
 	.is_enabled	= regulator_is_enabled_regmap,
@@ -31,7 +30,6 @@ static const struct regulator_desc stm32h7_booster_desc = {
 	.supply_name = "vdda",
 	.n_voltages = 1,
 	.type = REGULATOR_VOLTAGE,
-	.min_uV = 3300000,
 	.fixed_uV = 3300000,
 	.ramp_delay = 66000, /* up to 50us to stabilize */
 	.ops = &stm32h7_booster_ops,
@@ -53,7 +51,6 @@ static int stm32mp1_booster_disable(struct regulator_dev *rdev)
 }
 
 static const struct regulator_ops stm32mp1_booster_ops = {
-	.list_voltage	= regulator_list_voltage_linear,
 	.enable		= stm32mp1_booster_enable,
 	.disable	= stm32mp1_booster_disable,
 	.is_enabled	= regulator_is_enabled_regmap,
@@ -64,7 +61,6 @@ static const struct regulator_desc stm32mp1_booster_desc = {
 	.supply_name = "vdda",
 	.n_voltages = 1,
 	.type = REGULATOR_VOLTAGE,
-	.min_uV = 3300000,
 	.fixed_uV = 3300000,
 	.ramp_delay = 66000,
 	.ops = &stm32mp1_booster_ops,
-- 
2.20.1

Re: [PATCH] regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator

[Fabrice Gasnier]

On 7/23/19 3:41 AM, Axel Lin wrote:
> Setting .n_voltages = 1 and .fixed_uV is enough for fixed regulator,
> remove the redundant .min_uV and .list_voltage settings.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Hi Axel,

Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>

Thanks,
Fabrice
> ---
>  drivers/regulator/stm32-booster.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/regulator/stm32-booster.c b/drivers/regulator/stm32-booster.c
> index 2a897666c650..03f162ffd144 100644
> --- a/drivers/regulator/stm32-booster.c
> +++ b/drivers/regulator/stm32-booster.c
> @@ -20,7 +20,6 @@
>  #define STM32MP1_SYSCFG_EN_BOOSTER_MASK	BIT(8)
>  
>  static const struct regulator_ops stm32h7_booster_ops = {
> -	.list_voltage	= regulator_list_voltage_linear,
>  	.enable		= regulator_enable_regmap,
>  	.disable	= regulator_disable_regmap,
>  	.is_enabled	= regulator_is_enabled_regmap,
> @@ -31,7 +30,6 @@ static const struct regulator_desc stm32h7_booster_desc = {
>  	.supply_name = "vdda",
>  	.n_voltages = 1,
>  	.type = REGULATOR_VOLTAGE,
> -	.min_uV = 3300000,
>  	.fixed_uV = 3300000,
>  	.ramp_delay = 66000, /* up to 50us to stabilize */
>  	.ops = &stm32h7_booster_ops,
> @@ -53,7 +51,6 @@ static int stm32mp1_booster_disable(struct regulator_dev *rdev)
>  }
>  
>  static const struct regulator_ops stm32mp1_booster_ops = {
> -	.list_voltage	= regulator_list_voltage_linear,
>  	.enable		= stm32mp1_booster_enable,
>  	.disable	= stm32mp1_booster_disable,
>  	.is_enabled	= regulator_is_enabled_regmap,
> @@ -64,7 +61,6 @@ static const struct regulator_desc stm32mp1_booster_desc = {
>  	.supply_name = "vdda",
>  	.n_voltages = 1,
>  	.type = REGULATOR_VOLTAGE,
> -	.min_uV = 3300000,
>  	.fixed_uV = 3300000,
>  	.ramp_delay = 66000,
>  	.ops = &stm32mp1_booster_ops,
> 

Applied "regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator" to the regulator tree

[Mark Brown]

The patch

   regulator: stm32-booster: Remove .min_uV and .list_voltage for fixed regulator

has been applied to the regulator tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 03b77f0b8587a9a0f9d2f1503da3d120aa6fe730 Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@ingics.com>
Date: Tue, 23 Jul 2019 09:41:02 +0800
Subject: [PATCH] regulator: stm32-booster: Remove .min_uV and .list_voltage
 for fixed regulator

Setting .n_voltages = 1 and .fixed_uV is enough for fixed regulator,
remove the redundant .min_uV and .list_voltage settings.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Link: https://lore.kernel.org/r/20190723014102.25103-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/stm32-booster.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/regulator/stm32-booster.c b/drivers/regulator/stm32-booster.c
index 2a897666c650..03f162ffd144 100644
--- a/drivers/regulator/stm32-booster.c
+++ b/drivers/regulator/stm32-booster.c
@@ -20,7 +20,6 @@
 #define STM32MP1_SYSCFG_EN_BOOSTER_MASK	BIT(8)
 
 static const struct regulator_ops stm32h7_booster_ops = {
-	.list_voltage	= regulator_list_voltage_linear,
 	.enable		= regulator_enable_regmap,
 	.disable	= regulator_disable_regmap,
 	.is_enabled	= regulator_is_enabled_regmap,
@@ -31,7 +30,6 @@ static const struct regulator_desc stm32h7_booster_desc = {
 	.supply_name = "vdda",
 	.n_voltages = 1,
 	.type = REGULATOR_VOLTAGE,
-	.min_uV = 3300000,
 	.fixed_uV = 3300000,
 	.ramp_delay = 66000, /* up to 50us to stabilize */
 	.ops = &stm32h7_booster_ops,
@@ -53,7 +51,6 @@ static int stm32mp1_booster_disable(struct regulator_dev *rdev)
 }
 
 static const struct regulator_ops stm32mp1_booster_ops = {
-	.list_voltage	= regulator_list_voltage_linear,
 	.enable		= stm32mp1_booster_enable,
 	.disable	= stm32mp1_booster_disable,
 	.is_enabled	= regulator_is_enabled_regmap,
@@ -64,7 +61,6 @@ static const struct regulator_desc stm32mp1_booster_desc = {
 	.supply_name = "vdda",
 	.n_voltages = 1,
 	.type = REGULATOR_VOLTAGE,
-	.min_uV = 3300000,
 	.fixed_uV = 3300000,
 	.ramp_delay = 66000,
 	.ops = &stm32mp1_booster_ops,
-- 
2.20.1