linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Documentation: filesystem: fix "Removed Sysctls" table
@ 2019-07-23 11:48 Sheriff Esseson
  2019-07-23 13:42 ` Jonathan Corbet
  2019-07-26 20:51 ` Jonathan Corbet
  0 siblings, 2 replies; 6+ messages in thread
From: Sheriff Esseson @ 2019-07-23 11:48 UTC (permalink / raw)
  To: skhan
  Cc: linux-kernel-mentees, Darrick J. Wong, linux-xfs,
	Jonathan Corbet, open list:DOCUMENTATION, open list

the "Removed Sysctls" section is a table - bring it alive with ReST.

Signed-off-by: Sheriff Esseson <sheriffesseson@gmail.com>
---
 Documentation/admin-guide/xfs.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/xfs.rst
index e76665a8f2f2..fb5b39f73059 100644
--- a/Documentation/admin-guide/xfs.rst
+++ b/Documentation/admin-guide/xfs.rst
@@ -337,11 +337,12 @@ None at present.
 Removed Sysctls
 ===============
 
+=============================	=======
   Name				Removed
-  ----				-------
+=============================	=======
   fs.xfs.xfsbufd_centisec	v4.0
   fs.xfs.age_buffer_centisecs	v4.0
-
+=============================	=======
 
 Error handling
 ==============
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation: filesystem: fix "Removed Sysctls" table
  2019-07-23 11:48 [PATCH] Documentation: filesystem: fix "Removed Sysctls" table Sheriff Esseson
@ 2019-07-23 13:42 ` Jonathan Corbet
  2019-07-23 14:52   ` Sheriff Esseson
  2019-07-26 20:51 ` Jonathan Corbet
  1 sibling, 1 reply; 6+ messages in thread
From: Jonathan Corbet @ 2019-07-23 13:42 UTC (permalink / raw)
  To: Sheriff Esseson
  Cc: skhan, linux-kernel-mentees, Darrick J. Wong, linux-xfs,
	open list:DOCUMENTATION, open list

On Tue, 23 Jul 2019 12:48:13 +0100
Sheriff Esseson <sheriffesseson@gmail.com> wrote:

> the "Removed Sysctls" section is a table - bring it alive with ReST.
> 
> Signed-off-by: Sheriff Esseson <sheriffesseson@gmail.com>

So this appears to be identical to the patch you sent three days ago; is
there a reason why you are sending it again now?

Thanks,

jon

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation: filesystem: fix "Removed Sysctls" table
  2019-07-23 13:42 ` Jonathan Corbet
@ 2019-07-23 14:52   ` Sheriff Esseson
  2019-07-23 22:21     ` Dave Chinner
  0 siblings, 1 reply; 6+ messages in thread
From: Sheriff Esseson @ 2019-07-23 14:52 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: Darrick J. Wong, supporter:XFS FILESYSTEM, Jonathan Corbet,
	open list:DOCUMENTATION, open list, skhan, linux-kernel-mentees

On Tue, Jul 23, 2019 at 07:42:18AM -0600, Jonathan Corbet wrote:
> On Tue, 23 Jul 2019 12:48:13 +0100
> Sheriff Esseson <sheriffesseson@gmail.com> wrote:
> 
> > the "Removed Sysctls" section is a table - bring it alive with ReST.
> > 
> > Signed-off-by: Sheriff Esseson <sheriffesseson@gmail.com>
> 
> So this appears to be identical to the patch you sent three days ago; is
> there a reason why you are sending it again now?
> 
> Thanks,
> 
> jon

Sorry, I was think the patch went unnoticed during the merge window - I could
not find a response.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation: filesystem: fix "Removed Sysctls" table
  2019-07-23 14:52   ` Sheriff Esseson
@ 2019-07-23 22:21     ` Dave Chinner
  0 siblings, 0 replies; 6+ messages in thread
From: Dave Chinner @ 2019-07-23 22:21 UTC (permalink / raw)
  To: Sheriff Esseson
  Cc: Jonathan Corbet, Darrick J. Wong, supporter:XFS FILESYSTEM,
	open list:DOCUMENTATION, open list, skhan, linux-kernel-mentees

On Tue, Jul 23, 2019 at 03:52:01PM +0100, Sheriff Esseson wrote:
> On Tue, Jul 23, 2019 at 07:42:18AM -0600, Jonathan Corbet wrote:
> > On Tue, 23 Jul 2019 12:48:13 +0100
> > Sheriff Esseson <sheriffesseson@gmail.com> wrote:
> > 
> > > the "Removed Sysctls" section is a table - bring it alive with ReST.
> > > 
> > > Signed-off-by: Sheriff Esseson <sheriffesseson@gmail.com>
> > 
> > So this appears to be identical to the patch you sent three days ago; is
> > there a reason why you are sending it again now?
> > 
> > Thanks,
> > 
> > jon
> 
> Sorry, I was think the patch went unnoticed during the merge window - I could
> not find a response.

The correct thing to do in that case is to reply to the original
patch and ask if it has been looked at. The usual way of doing this
is quoting the commit message and replying with a "Ping?" comment
to bump it back to the top of everyone's mail stacks.

But, again, 3 days is not a long time, people tend to be extremely
busy and might take a few days to get to reviewing non-critical
changes, and people may not even review patches during the merge
window. I'd suggest waiting a week before pinging a patch you've
sent if there's been no response....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Documentation: filesystem: fix "Removed Sysctls" table
  2019-07-23 11:48 [PATCH] Documentation: filesystem: fix "Removed Sysctls" table Sheriff Esseson
  2019-07-23 13:42 ` Jonathan Corbet
@ 2019-07-26 20:51 ` Jonathan Corbet
  1 sibling, 0 replies; 6+ messages in thread
From: Jonathan Corbet @ 2019-07-26 20:51 UTC (permalink / raw)
  To: Sheriff Esseson
  Cc: skhan, linux-kernel-mentees, Darrick J. Wong, linux-xfs,
	open list:DOCUMENTATION, open list

On Tue, 23 Jul 2019 12:48:13 +0100
Sheriff Esseson <sheriffesseson@gmail.com> wrote:

> the "Removed Sysctls" section is a table - bring it alive with ReST.
> 
> Signed-off-by: Sheriff Esseson <sheriffesseson@gmail.com>
> ---
>  Documentation/admin-guide/xfs.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/xfs.rst
> index e76665a8f2f2..fb5b39f73059 100644
> --- a/Documentation/admin-guide/xfs.rst
> +++ b/Documentation/admin-guide/xfs.rst
> @@ -337,11 +337,12 @@ None at present.
>  Removed Sysctls
>  ===============
>  
> +=============================	=======
>    Name				Removed
> -  ----				-------
> +=============================	=======
>    fs.xfs.xfsbufd_centisec	v4.0
>    fs.xfs.age_buffer_centisecs	v4.0
> -
> +=============================	=======

I've applied this, thanks.

jon

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] Documentation: filesystem: fix "Removed Sysctls" table
@ 2019-07-20 17:29 Sheriff Esseson
  0 siblings, 0 replies; 6+ messages in thread
From: Sheriff Esseson @ 2019-07-20 17:29 UTC (permalink / raw)
  To: skhan
  Cc: linux-kernel-mentees, Darrick J. Wong, linux-xfs,
	Jonathan Corbet, open list:DOCUMENTATION, open list

the "Removed Sysctls" section is a table - bring it alive with ReST.

Signed-off-by: Sheriff Esseson <sheriffesseson@gmail.com>
---
 Documentation/admin-guide/xfs.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/admin-guide/xfs.rst b/Documentation/admin-guide/xfs.rst
index e76665a8f2f2..fb5b39f73059 100644
--- a/Documentation/admin-guide/xfs.rst
+++ b/Documentation/admin-guide/xfs.rst
@@ -337,11 +337,12 @@ None at present.
 Removed Sysctls
 ===============
 
+=============================	=======
   Name				Removed
-  ----				-------
+=============================	=======
   fs.xfs.xfsbufd_centisec	v4.0
   fs.xfs.age_buffer_centisecs	v4.0
-
+=============================	=======
 
 Error handling
 ==============
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-07-26 20:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 11:48 [PATCH] Documentation: filesystem: fix "Removed Sysctls" table Sheriff Esseson
2019-07-23 13:42 ` Jonathan Corbet
2019-07-23 14:52   ` Sheriff Esseson
2019-07-23 22:21     ` Dave Chinner
2019-07-26 20:51 ` Jonathan Corbet
  -- strict thread matches above, loose matches on Subject: below --
2019-07-20 17:29 Sheriff Esseson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).