From: Saravana Kannan <saravanak@google.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Saravana Kannan <saravanak@google.com>,
Sibi Sankar <sibis@codeaurora.org>,
kernel-team@android.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 1/5] OPP: Allow required-opps even if the device doesn't have power-domains
Date: Tue, 23 Jul 2019 18:42:17 -0700 [thread overview]
Message-ID: <20190724014222.110767-2-saravanak@google.com> (raw)
In-Reply-To: <20190724014222.110767-1-saravanak@google.com>
A Device-A can have a (minimum) performance requirement on another
Device-B to be able to function correctly. This performance requirement
on Device-B can also change based on the current performance level of
Device-A.
The existing required-opps feature fits well to describe this need. So,
instead of limiting required-opps to point to only PM-domain devices,
allow it to point to any device.
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/opp/core.c | 2 +-
drivers/opp/of.c | 11 -----------
2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index c094d5d20fd7..438fcd134d93 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -707,7 +707,7 @@ static int _set_required_opps(struct device *dev,
return 0;
/* Single genpd case */
- if (!genpd_virt_devs) {
+ if (!genpd_virt_devs && required_opp_tables[0]->is_genpd) {
pstate = likely(opp) ? opp->required_opps[0]->pstate : 0;
ret = dev_pm_genpd_set_performance_state(dev, pstate);
if (ret) {
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index b313aca9894f..ff88eaf66b56 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -197,17 +197,6 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
if (IS_ERR(required_opp_tables[i]))
goto free_required_tables;
-
- /*
- * We only support genpd's OPPs in the "required-opps" for now,
- * as we don't know how much about other cases. Error out if the
- * required OPP doesn't belong to a genpd.
- */
- if (!required_opp_tables[i]->is_genpd) {
- dev_err(dev, "required-opp doesn't belong to genpd: %pOF\n",
- required_np);
- goto free_required_tables;
- }
}
goto put_np;
--
2.22.0.709.g102302147b-goog
next prev parent reply other threads:[~2019-07-24 1:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190724014230epcas5p371a5fdee330f91a646d619fbcc024acf@epcas5p3.samsung.com>
2019-07-24 1:42 ` [PATCH v4 0/5] Add required-opps support to devfreq passive gov Saravana Kannan
2019-07-24 1:42 ` Saravana Kannan [this message]
2019-07-24 1:42 ` [PATCH v4 2/5] OPP: Add function to look up required OPP's for a given OPP Saravana Kannan
2019-07-24 1:42 ` [PATCH v4 3/5] OPP: Improve required-opps linking Saravana Kannan
2019-07-24 17:59 ` Sibi Sankar
2019-07-24 21:13 ` Saravana Kannan
2019-07-24 1:42 ` [PATCH v4 4/5] PM / devfreq: Cache OPP table reference in devfreq Saravana Kannan
2019-07-24 1:42 ` [PATCH v4 5/5] PM / devfreq: Add required OPPs support to passive governor Saravana Kannan
2019-07-25 2:30 ` [PATCH v4 0/5] Add required-opps support to devfreq passive gov Viresh Kumar
2019-07-25 3:40 ` Saravana Kannan
2019-07-25 5:22 ` Viresh Kumar
2019-07-26 1:56 ` Saravana Kannan
2019-11-14 7:54 ` Chanwoo Choi
2019-11-14 8:23 ` Saravana Kannan
2019-11-14 8:35 ` Viresh Kumar
2019-11-14 19:39 ` Saravana Kannan
2019-11-14 8:39 ` Chanwoo Choi
2019-12-19 16:17 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724014222.110767-2-saravanak@google.com \
--to=saravanak@google.com \
--cc=cw00.choi@samsung.com \
--cc=kernel-team@android.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).