* Re: [Bug] v5.3-rc3: arm: omap5: omapdss: omap_fbdev_init fails with lpae config and reports dma_mask error
[not found] ` <DF565339-14BC-411D-9301-5651FA601733@goldelico.com>
@ 2019-08-08 7:24 ` Christoph Hellwig
2019-08-08 9:57 ` H. Nikolaus Schaller
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2019-08-08 7:24 UTC (permalink / raw)
To: H. Nikolaus Schaller
Cc: Tomi Valkeinen, Tony Lindgren, Roger Quadros, Christoph Hellwig,
Vignesh Raghavendra, Linux-OMAP, Linux Kernel Mailing List,
kernel, Discussions about the Letux Kernel
Hi Nikolaus,
please try the patch below:
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index 561c4812545b..2c8abf07e617 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -232,6 +232,8 @@ void omap_fbdev_init(struct drm_device *dev)
if (!priv->num_pipes)
return;
+ dma_coerce_mask_and_coherent(dev->dev, DMA_BIT_MASK(32));
+
fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);
if (!fbdev)
goto fail;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Bug] v5.3-rc3: arm: omap5: omapdss: omap_fbdev_init fails with lpae config and reports dma_mask error
2019-08-08 7:24 ` [Bug] v5.3-rc3: arm: omap5: omapdss: omap_fbdev_init fails with lpae config and reports dma_mask error Christoph Hellwig
@ 2019-08-08 9:57 ` H. Nikolaus Schaller
0 siblings, 0 replies; 2+ messages in thread
From: H. Nikolaus Schaller @ 2019-08-08 9:57 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Tomi Valkeinen, Tony Lindgren, Roger Quadros,
Vignesh Raghavendra, Linux-OMAP, Linux Kernel Mailing List,
kernel, Discussions about the Letux Kernel
Hi Christoph,
> Am 08.08.2019 um 09:24 schrieb Christoph Hellwig <hch@lst.de>:
>
> Hi Nikolaus,
>
> please try the patch below:
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> index 561c4812545b..2c8abf07e617 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -232,6 +232,8 @@ void omap_fbdev_init(struct drm_device *dev)
> if (!priv->num_pipes)
> return;
>
> + dma_coerce_mask_and_coherent(dev->dev, DMA_BIT_MASK(32));
> +
> fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);
> if (!fbdev)
> goto fail;
Yes, it fixes the issue!
BR and thanks,
Nikolaus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-08 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <14A6738F-75C6-4479-8B15-FD7395EFC55E@goldelico.com>
[not found] ` <DF565339-14BC-411D-9301-5651FA601733@goldelico.com>
2019-08-08 7:24 ` [Bug] v5.3-rc3: arm: omap5: omapdss: omap_fbdev_init fails with lpae config and reports dma_mask error Christoph Hellwig
2019-08-08 9:57 ` H. Nikolaus Schaller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).