From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@mellanox.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"wankhede@nvidia.com" <wankhede@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"cjia@nvidia.com" <cjia@nvidia.com>
Subject: Re: [PATCH v1 2/2] vfio/mdev: Removed unused and redundant API for mdev UUID
Date: Thu, 8 Aug 2019 10:29:31 +0200 [thread overview]
Message-ID: <20190808102931.40c6b4ae.cohuck@redhat.com> (raw)
In-Reply-To: <AM0PR05MB48664379F91C8FA3D0035B41D1D40@AM0PR05MB4866.eurprd05.prod.outlook.com>
On Wed, 7 Aug 2019 16:33:11 +0000
Parav Pandit <parav@mellanox.com> wrote:
> > -----Original Message-----
> > From: Cornelia Huck <cohuck@redhat.com>
> > Sent: Wednesday, August 7, 2019 2:58 PM
> > To: Parav Pandit <parav@mellanox.com>
> > Cc: kvm@vger.kernel.org; wankhede@nvidia.com; linux-
> > kernel@vger.kernel.org; alex.williamson@redhat.com; cjia@nvidia.com
> > Subject: Re: [PATCH v1 2/2] vfio/mdev: Removed unused and redundant API for
> > mdev UUID
> >
> > On Tue, 6 Aug 2019 09:18:26 -0500
> > Parav Pandit <parav@mellanox.com> wrote:
> >
> > > There is no single production driver who is interested in mdev device
> > > uuid. Currently UUID is mainly used to derive a device name.
> > > Additionally mdev device name is already available using core kernel
> > > API dev_name().
> >
> > Well, the mdev code actually uses the uuid to check for duplicates before
> > registration with the driver core would fail... I'd just drop the two sentences
> Yes, it does the check. But its mainly used to derive a device name.
> And to ensure that there are no two devices with duplicate name, it compares with the uuid.
>
> Even this 16 bytes storage is redundant.
> Subsequently, I will submit a patch to get rid of storing this 16 bytes of UUID too.
> Because for duplicate name check, device name itself is pretty good enough.
>
> Since I ran out of time and rc-4 is going on, I differed the 3rd simplification patch.
I'm not sure why we'd want to ditch the uuid; it's not like it is
taking up huge amounts of space... and I see the device name being
derived from the unique identifier that is the uuid, and not as the
unique identifier itself.
>
> Commit message actually came from the thoughts of 3rd patch, but I see that without it, its not so intuitive.
>
> > talking about the device name, IMHO they don't really add useful information;
> > but I'll leave that decision to the maintainers.
> >
> > >
> > > Hence removed unused exported symbol.
> > >
> > > Signed-off-by: Parav Pandit <parav@mellanox.com>
> > > ---
> > > Changelog:
> > > v0->v1:
> > > - Updated commit log to address comments from Cornelia
> > > ---
> > > drivers/vfio/mdev/mdev_core.c | 6 ------
> > > include/linux/mdev.h | 1 -
> > > 2 files changed, 7 deletions(-)
> >
> > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> Thanks for the review.
next prev parent reply other threads:[~2019-08-08 8:29 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 6:59 [PATCH 0/2] Simplify mtty driver and mdev core Parav Pandit
2019-08-02 6:59 ` [PATCH 1/2] vfio-mdev/mtty: Simplify interrupt generation Parav Pandit
2019-08-06 8:15 ` Cornelia Huck
2019-08-02 6:59 ` [PATCH 2/2] vfio/mdev: Removed unused and redundant API for mdev name Parav Pandit
2019-08-06 8:29 ` Cornelia Huck
2019-08-06 13:12 ` Parav Pandit
2019-08-06 14:18 ` [PATCH v1 0/2] Simplify mtty driver and mdev core Parav Pandit
2019-08-06 14:18 ` [PATCH v1 1/2] vfio-mdev/mtty: Simplify interrupt generation Parav Pandit
2019-08-06 14:18 ` [PATCH v1 2/2] vfio/mdev: Removed unused and redundant API for mdev UUID Parav Pandit
2019-08-07 9:28 ` Cornelia Huck
2019-08-07 16:33 ` Parav Pandit
2019-08-08 8:29 ` Cornelia Huck [this message]
2019-08-08 14:01 ` Parav Pandit
2019-08-08 14:12 ` [PATCH v2 0/2] Simplify mtty driver and mdev core Parav Pandit
2019-08-08 14:12 ` [PATCH v2 1/2] vfio-mdev/mtty: Simplify interrupt generation Parav Pandit
2019-08-13 16:39 ` Christoph Hellwig
2019-08-23 20:48 ` Alex Williamson
2019-08-08 14:12 ` [PATCH v2 2/2] vfio/mdev: Removed unused and redundant API for mdev UUID Parav Pandit
2019-08-13 16:39 ` Christoph Hellwig
2019-08-16 15:22 ` Cornelia Huck
2019-08-08 23:02 ` [PATCH v2 0/2] Simplify mtty driver and mdev core Alex Williamson
2019-08-09 8:07 ` Cornelia Huck
2019-08-12 11:35 ` Kirti Wankhede
2019-08-13 14:40 ` Parav Pandit
2019-08-13 14:52 ` Alex Williamson
2019-08-13 16:28 ` Parav Pandit
2019-08-13 16:34 ` Cornelia Huck
2019-08-13 17:11 ` Alex Williamson
2019-08-14 5:54 ` Parav Pandit
2019-08-14 8:01 ` Cornelia Huck
2019-08-14 12:27 ` Parav Pandit
2019-08-14 13:09 ` Cornelia Huck
2019-08-14 13:45 ` Parav Pandit
2019-08-14 14:57 ` Alex Williamson
2019-08-14 16:21 ` Parav Pandit
2019-08-20 8:58 ` Parav Pandit
2019-08-20 9:58 ` Christophe de Dinechin
2019-08-20 11:25 ` Parav Pandit
2019-08-20 16:31 ` Cornelia Huck
2019-08-21 2:42 ` Parav Pandit
2019-08-20 17:19 ` Alex Williamson
2019-08-20 17:55 ` Cornelia Huck
2019-08-21 3:57 ` Parav Pandit
2019-08-21 3:42 ` Parav Pandit
2019-08-21 4:20 ` Alex Williamson
2019-08-21 4:40 ` Parav Pandit
2019-08-21 4:57 ` Alex Williamson
2019-08-21 5:01 ` Parav Pandit
2019-08-21 5:26 ` Alex Williamson
2019-08-21 6:23 ` Parav Pandit
2019-08-22 9:29 ` Jiri Pirko
2019-08-22 9:42 ` Parav Pandit
2019-08-22 9:58 ` Jiri Pirko
2019-08-22 10:04 ` Parav Pandit
2019-08-22 12:19 ` Jiri Pirko
2019-08-22 13:33 ` Parav Pandit
2019-08-23 8:12 ` Jiri Pirko
2019-08-23 8:14 ` Parav Pandit
2019-08-23 14:28 ` Alex Williamson
2019-08-23 14:53 ` Parav Pandit
2019-08-23 15:04 ` Jiri Pirko
2019-08-23 15:52 ` Alex Williamson
2019-08-23 16:14 ` Parav Pandit
2019-08-23 17:16 ` Alex Williamson
2019-08-23 18:00 ` Parav Pandit
2019-08-23 19:43 ` Alex Williamson
2019-08-24 3:56 ` Parav Pandit
2019-08-24 4:45 ` Parav Pandit
2019-08-24 4:59 ` Alex Williamson
2019-08-24 5:22 ` Parav Pandit
2019-08-13 16:37 ` Christoph Hellwig
2019-08-13 17:40 ` Greg Kroah-Hartman
2019-08-14 5:30 ` Parav Pandit
2019-08-13 14:48 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808102931.40c6b4ae.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cjia@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=wankhede@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).