From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thierry Reding <thierry.reding@gmail.com>,
od@zcrc.me, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mathieu Malaterre <malat@debian.org>,
Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH 2/7] pwm: jz4740: Use clocks from TCU driver
Date: Fri, 9 Aug 2019 18:55:09 +0200 [thread overview]
Message-ID: <20190809165509.odbmz4wy2ijl6vh2@pengutronix.de> (raw)
In-Reply-To: <20190809123031.24219-3-paul@crapouillou.net>
On Fri, Aug 09, 2019 at 02:30:26PM +0200, Paul Cercueil wrote:
> The ingenic-timer "TCU" driver provides us with clocks, that can be
> (un)gated, reparented or reclocked from devicetree, instead of having
> these settings hardcoded in this driver.
>
> While this driver is devicetree-compatible, it is never (as of now)
> probed from devicetree, so this change does not introduce a ABI problem
> with current devicetree files.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Tested-by: Mathieu Malaterre <malat@debian.org>
> Tested-by: Artur Rojek <contact@artur-rojek.eu>
> ---
> drivers/pwm/Kconfig | 1 +
> drivers/pwm/pwm-jz4740.c | 40 ++++++++++++++++++++++++++--------------
> 2 files changed, 27 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index cc4df0ec978a..d2557c6fcf65 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -225,6 +225,7 @@ config PWM_IMX_TPM
> config PWM_JZ4740
> tristate "Ingenic JZ47xx PWM support"
> depends on MACH_INGENIC
> + depends on COMMON_CLK
> select MFD_SYSCON
> help
> Generic PWM framework driver for Ingenic JZ47xx based
> diff --git a/drivers/pwm/pwm-jz4740.c b/drivers/pwm/pwm-jz4740.c
> index 7aea5e0c6e18..6ec8794d3b99 100644
> --- a/drivers/pwm/pwm-jz4740.c
> +++ b/drivers/pwm/pwm-jz4740.c
> @@ -20,7 +20,6 @@
>
> struct jz4740_pwm_chip {
> struct pwm_chip chip;
> - struct clk *clk;
> struct regmap *map;
> };
>
> @@ -32,6 +31,9 @@ static inline struct jz4740_pwm_chip *to_jz4740(struct pwm_chip *chip)
> static int jz4740_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
> {
> struct jz4740_pwm_chip *jz = to_jz4740(chip);
> + struct clk *clk;
> + char clk_name[16];
> + int ret;
>
> /*
> * Timers 0 and 1 are used for system tasks, so they are unavailable
> @@ -40,16 +42,29 @@ static int jz4740_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
> if (pwm->hwpwm < 2)
> return -EBUSY;
>
> - regmap_write(jz->map, TCU_REG_TSCR, BIT(pwm->hwpwm));
> + snprintf(clk_name, sizeof(clk_name), "timer%u", pwm->hwpwm);
This undoes stuff from the previous patch. Maybe swap the order of the
two patches?
Other than that the patch looks fine on a quick glance.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-08-09 16:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 12:30 [PATCH 0/7] pwm: jz4740: Driver update Paul Cercueil
2019-08-09 12:30 ` [PATCH 1/7] pwm: jz4740: Obtain regmap from parent node Paul Cercueil
2019-08-09 16:51 ` Uwe Kleine-König
2019-08-09 17:04 ` Paul Cercueil
2019-08-12 6:18 ` Uwe Kleine-König
2019-08-09 12:30 ` [PATCH 2/7] pwm: jz4740: Use clocks from TCU driver Paul Cercueil
2019-08-09 16:55 ` Uwe Kleine-König [this message]
2019-08-09 12:30 ` [PATCH 3/7] pwm: jz4740: Drop dependency on MACH_INGENIC Paul Cercueil
2019-08-09 16:41 ` Uwe Kleine-König
2019-08-09 21:40 ` Paul Cercueil
2019-08-12 6:09 ` Uwe Kleine-König
2019-08-09 12:30 ` [PATCH 4/7] pwm: jz4740: Improve algorithm of clock calculation Paul Cercueil
2019-08-09 17:05 ` Uwe Kleine-König
2019-08-09 17:14 ` Paul Cercueil
2019-08-12 6:15 ` Uwe Kleine-König
2019-08-12 20:43 ` Paul Cercueil
2019-08-12 21:48 ` Uwe Kleine-König
2019-08-12 22:25 ` Paul Cercueil
[not found] ` <1565648183.2007.3@crapouillou.net>
2019-08-13 5:27 ` Uwe Kleine-König
2019-08-13 11:01 ` Paul Cercueil
2019-08-13 12:33 ` Uwe Kleine-König
2019-08-13 12:47 ` Paul Cercueil
2019-08-13 14:09 ` Uwe Kleine-König
2019-08-14 16:10 ` Paul Cercueil
2019-08-14 17:32 ` Uwe Kleine-König
2019-10-21 12:47 ` Paul Cercueil
2020-02-12 7:29 ` About rounding in the clk framework [Was: Re: [PATCH 4/7] pwm: jz4740: Improve algorithm of clock calculation] Uwe Kleine-König
2020-04-14 9:24 ` Uwe Kleine-König
2020-12-21 13:57 ` Uwe Kleine-König
2019-08-09 12:30 ` [PATCH 5/7] pwm: jz4740: Allow selection of PWM channels 0 and 1 Paul Cercueil
2019-08-09 12:30 ` [PATCH 6/7] pwm: jz4740: Make PWM start with the active part Paul Cercueil
2019-08-09 17:10 ` Uwe Kleine-König
2019-08-09 17:33 ` Paul Cercueil
2019-08-12 5:55 ` Uwe Kleine-König
2019-08-12 20:50 ` Paul Cercueil
2019-08-12 21:58 ` Uwe Kleine-König
2019-09-20 22:52 ` Thierry Reding
2019-08-09 12:30 ` [PATCH 7/7] pwm: jz4740: document known limitations Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809165509.odbmz4wy2ijl6vh2@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=contact@artur-rojek.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=malat@debian.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).