* [PATCH] mfd: cros_ec: Update cros_ec_commands.h
@ 2019-07-08 18:15 Yicheng Li
2019-07-11 17:17 ` Gwendal Grignou
2019-08-12 7:27 ` Lee Jones
0 siblings, 2 replies; 6+ messages in thread
From: Yicheng Li @ 2019-07-08 18:15 UTC (permalink / raw)
To: LKML, lee.jones
Cc: enric.balletbo, gwendal, bleung, Yicheng Li, Guenter Roeck
Update cros_ec_commands.h to match the fingerprint MCU section in
the current ec_commands.h
Signed-off-by: Yicheng Li <yichengli@chromium.org>
---
include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
index 7ccb8757b79d..98415686cbfa 100644
--- a/include/linux/mfd/cros_ec_commands.h
+++ b/include/linux/mfd/cros_ec_commands.h
@@ -5513,6 +5513,18 @@ struct ec_params_fp_seed {
uint8_t seed[FP_CONTEXT_TPM_BYTES];
} __ec_align4;
+#define EC_CMD_FP_ENC_STATUS 0x0409
+
+/* FP TPM seed has been set or not */
+#define FP_ENC_STATUS_SEED_SET BIT(0)
+
+struct ec_response_fp_encryption_status {
+ /* Used bits in encryption engine status */
+ uint32_t valid_flags;
+ /* Encryption engine status */
+ uint32_t status;
+} __ec_align4;
+
/*****************************************************************************/
/* Touchpad MCU commands: range 0x0500-0x05FF */
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: cros_ec: Update cros_ec_commands.h
2019-07-08 18:15 [PATCH] mfd: cros_ec: Update cros_ec_commands.h Yicheng Li
@ 2019-07-11 17:17 ` Gwendal Grignou
2019-07-22 14:15 ` Enric Balletbo i Serra
2019-08-12 7:27 ` Lee Jones
1 sibling, 1 reply; 6+ messages in thread
From: Gwendal Grignou @ 2019-07-11 17:17 UTC (permalink / raw)
To: Yicheng Li
Cc: LKML, Lee Jones, Enric Balletbo i Serra, Benson Leung, Guenter Roeck
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Note there is a patch series that move cros_ec_commands.h from
nclude/linux/mfd/ to include/linux/platform_data.
On Mon, Jul 8, 2019 at 11:16 AM Yicheng Li <yichengli@chromium.org> wrote:
>
> Update cros_ec_commands.h to match the fingerprint MCU section in
> the current ec_commands.h
>
> Signed-off-by: Yicheng Li <yichengli@chromium.org>
> ---
>
> include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
> index 7ccb8757b79d..98415686cbfa 100644
> --- a/include/linux/mfd/cros_ec_commands.h
> +++ b/include/linux/mfd/cros_ec_commands.h
> @@ -5513,6 +5513,18 @@ struct ec_params_fp_seed {
> uint8_t seed[FP_CONTEXT_TPM_BYTES];
> } __ec_align4;
>
> +#define EC_CMD_FP_ENC_STATUS 0x0409
> +
> +/* FP TPM seed has been set or not */
> +#define FP_ENC_STATUS_SEED_SET BIT(0)
> +
> +struct ec_response_fp_encryption_status {
> + /* Used bits in encryption engine status */
> + uint32_t valid_flags;
> + /* Encryption engine status */
> + uint32_t status;
> +} __ec_align4;
> +
> /*****************************************************************************/
> /* Touchpad MCU commands: range 0x0500-0x05FF */
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: cros_ec: Update cros_ec_commands.h
2019-07-11 17:17 ` Gwendal Grignou
@ 2019-07-22 14:15 ` Enric Balletbo i Serra
2019-08-12 7:28 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Enric Balletbo i Serra @ 2019-07-22 14:15 UTC (permalink / raw)
To: Gwendal Grignou, Yicheng Li
Cc: LKML, Lee Jones, Benson Leung, Guenter Roeck, kernel
Hi Lee,
On 11/7/19 19:17, Gwendal Grignou wrote:
> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>
> Note there is a patch series that move cros_ec_commands.h from
> nclude/linux/mfd/ to include/linux/platform_data.
>
I just sent a new version of the patches mentioned above now that rc1 is out [1]
As Gwendal said this patch will conflict with them, so we have two options.
1. If Lee picks that patch I can rebase again my series on top of it.
2. If not, we can wait for Lee reviewing my patch series and then I don't mind
to rebase that patch on top of my series and carry the patch through
chrome-platform. Anyway I'll need an immutable branch from Lee.
> On Mon, Jul 8, 2019 at 11:16 AM Yicheng Li <yichengli@chromium.org> wrote:
>>
>> Update cros_ec_commands.h to match the fingerprint MCU section in
>> the current ec_commands.h
>>
>> Signed-off-by: Yicheng Li <yichengli@chromium.org>
For the first case:
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Thanks,
~ Enric
[1] https://lkml.org/lkml/2019/7/22/497
>> ---
>>
>> include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
>> index 7ccb8757b79d..98415686cbfa 100644
>> --- a/include/linux/mfd/cros_ec_commands.h
>> +++ b/include/linux/mfd/cros_ec_commands.h
>> @@ -5513,6 +5513,18 @@ struct ec_params_fp_seed {
>> uint8_t seed[FP_CONTEXT_TPM_BYTES];
>> } __ec_align4;
>>
>> +#define EC_CMD_FP_ENC_STATUS 0x0409
>> +
>> +/* FP TPM seed has been set or not */
>> +#define FP_ENC_STATUS_SEED_SET BIT(0)
>> +
>> +struct ec_response_fp_encryption_status {
>> + /* Used bits in encryption engine status */
>> + uint32_t valid_flags;
>> + /* Encryption engine status */
>> + uint32_t status;
>> +} __ec_align4;
>> +
>> /*****************************************************************************/
>> /* Touchpad MCU commands: range 0x0500-0x05FF */
>>
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: cros_ec: Update cros_ec_commands.h
2019-07-08 18:15 [PATCH] mfd: cros_ec: Update cros_ec_commands.h Yicheng Li
2019-07-11 17:17 ` Gwendal Grignou
@ 2019-08-12 7:27 ` Lee Jones
1 sibling, 0 replies; 6+ messages in thread
From: Lee Jones @ 2019-08-12 7:27 UTC (permalink / raw)
To: Yicheng Li; +Cc: LKML, enric.balletbo, gwendal, bleung, Guenter Roeck
On Mon, 08 Jul 2019, Yicheng Li wrote:
> Update cros_ec_commands.h to match the fingerprint MCU section in
> the current ec_commands.h
>
> Signed-off-by: Yicheng Li <yichengli@chromium.org>
> ---
>
> include/linux/mfd/cros_ec_commands.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: cros_ec: Update cros_ec_commands.h
2019-07-22 14:15 ` Enric Balletbo i Serra
@ 2019-08-12 7:28 ` Lee Jones
2019-08-21 17:27 ` Enric Balletbo i Serra
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2019-08-12 7:28 UTC (permalink / raw)
To: Enric Balletbo i Serra
Cc: Gwendal Grignou, Yicheng Li, LKML, Benson Leung, Guenter Roeck, kernel
On Mon, 22 Jul 2019, Enric Balletbo i Serra wrote:
> Hi Lee,
>
> On 11/7/19 19:17, Gwendal Grignou wrote:
> > Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
> >
> > Note there is a patch series that move cros_ec_commands.h from
> > nclude/linux/mfd/ to include/linux/platform_data.
> >
>
> I just sent a new version of the patches mentioned above now that rc1 is out [1]
>
> As Gwendal said this patch will conflict with them, so we have two options.
>
> 1. If Lee picks that patch I can rebase again my series on top of it.
Yes please.
> 2. If not, we can wait for Lee reviewing my patch series and then I don't mind
> to rebase that patch on top of my series and carry the patch through
> chrome-platform. Anyway I'll need an immutable branch from Lee.
I just reviewed your series.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: cros_ec: Update cros_ec_commands.h
2019-08-12 7:28 ` Lee Jones
@ 2019-08-21 17:27 ` Enric Balletbo i Serra
0 siblings, 0 replies; 6+ messages in thread
From: Enric Balletbo i Serra @ 2019-08-21 17:27 UTC (permalink / raw)
To: Lee Jones
Cc: Gwendal Grignou, Yicheng Li, LKML, Benson Leung, Guenter Roeck, kernel
Hi Lee,
On 12/8/19 9:28, Lee Jones wrote:
> On Mon, 22 Jul 2019, Enric Balletbo i Serra wrote:
>
>> Hi Lee,
>>
>> On 11/7/19 19:17, Gwendal Grignou wrote:
>>> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>>>
>>> Note there is a patch series that move cros_ec_commands.h from
>>> nclude/linux/mfd/ to include/linux/platform_data.
>>>
>>
>> I just sent a new version of the patches mentioned above now that rc1 is out [1]
>>
>> As Gwendal said this patch will conflict with them, so we have two options.
>>
>> 1. If Lee picks that patch I can rebase again my series on top of it.
>
> Yes please.
>
Perfect, preparing a new rebased version to send soon.
>> 2. If not, we can wait for Lee reviewing my patch series and then I don't mind
>> to rebase that patch on top of my series and carry the patch through
>> chrome-platform. Anyway I'll need an immutable branch from Lee.
>
> I just reviewed your series.
>
Thanks,
Enric
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-21 17:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 18:15 [PATCH] mfd: cros_ec: Update cros_ec_commands.h Yicheng Li
2019-07-11 17:17 ` Gwendal Grignou
2019-07-22 14:15 ` Enric Balletbo i Serra
2019-08-12 7:28 ` Lee Jones
2019-08-21 17:27 ` Enric Balletbo i Serra
2019-08-12 7:27 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).