From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-accelerators@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
Kenneth Lee <liguozhu@hisilicon.com>,
Zaibo Xu <xuzaibo@huawei.com>,
Zhou Wang <wangzhou1@hisilicon.com>
Subject: Re: [PATCH 2/2] uacce: add uacce module
Date: Thu, 15 Aug 2019 16:13:51 +0200 [thread overview]
Message-ID: <20190815141351.GD23267@kroah.com> (raw)
In-Reply-To: <1565775265-21212-3-git-send-email-zhangfei.gao@linaro.org>
On Wed, Aug 14, 2019 at 05:34:25PM +0800, Zhangfei Gao wrote:
> +int uacce_register(struct uacce *uacce)
> +{
> + int ret;
> +
> + if (!uacce->pdev) {
> + pr_debug("uacce parent device not set\n");
> + return -ENODEV;
> + }
> +
> + if (uacce->flags & UACCE_DEV_NOIOMMU) {
> + add_taint(TAINT_CRAP, LOCKDEP_STILL_OK);
> + dev_warn(uacce->pdev,
> + "Register to noiommu mode, which export kernel data to user space and may vulnerable to attack");
> + }
THat is odd, why even offer this feature then if it is a major issue?
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-15 14:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 9:34 [PATCH 0/2] A General Accelerator Framework, WarpDrive Zhangfei Gao
2019-08-14 9:34 ` [PATCH 1/2] uacce: Add documents for WarpDrive/uacce Zhangfei Gao
2019-08-14 9:34 ` [PATCH 2/2] uacce: add uacce module Zhangfei Gao
2019-08-15 14:12 ` Greg Kroah-Hartman
[not found] ` <5d5a6757.1c69fb81.e0678.2ab2SMTPIN_ADDED_BROKEN@mx.google.com>
2019-08-19 10:22 ` Greg Kroah-Hartman
2019-08-20 12:38 ` zhangfei
2019-08-20 14:31 ` Greg Kroah-Hartman
2019-08-15 14:13 ` Greg Kroah-Hartman [this message]
2019-08-20 13:08 ` zhangfei
2019-08-20 16:59 ` Greg Kroah-Hartman
[not found] ` <5d5cf0fc.1c69fb81.ec57f.b853SMTPIN_ADDED_BROKEN@mx.google.com>
2019-08-21 9:17 ` Greg Kroah-Hartman
2019-08-21 14:30 ` zhangfei
2019-08-21 16:05 ` Greg Kroah-Hartman
2019-08-26 4:10 ` Kenneth Lee
2019-08-26 4:29 ` Greg Kroah-Hartman
2019-08-27 11:42 ` Kenneth Lee
2019-08-27 18:48 ` Greg Kroah-Hartman
2019-08-15 14:20 ` Greg Kroah-Hartman
[not found] ` <5d5a6f5b.1c69fb81.9d35e.5303SMTPIN_ADDED_BROKEN@mx.google.com>
2019-08-19 10:24 ` Greg Kroah-Hartman
2019-08-20 12:36 ` zhangfei
2019-08-20 14:33 ` Greg Kroah-Hartman
2019-08-24 12:53 ` zhangfei
2019-08-24 15:40 ` Greg Kroah-Hartman
2019-08-15 16:54 ` Jonathan Cameron
2019-08-23 9:21 ` zhangfei
2019-08-23 16:36 ` Jonathan Cameron
2019-08-23 16:42 ` Jonathan Cameron
2019-08-15 17:04 ` [PATCH 0/2] A General Accelerator Framework, WarpDrive Jerome Glisse
2019-08-20 14:26 ` zhangfei
2019-08-26 4:14 ` Kenneth Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815141351.GD23267@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=liguozhu@hisilicon.com \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).