Re: [PATCH 2/2] uacce: add uacce module

From: zhangfei <zhangfei.gao@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"zhangfei.gao@foxmail.com" <zhangfei.gao@foxmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-accelerators@lists.ozlabs.org,
	linux-kernel@vger.kernel.org,
	Kenneth Lee <liguozhu@hisilicon.com>,
	Zaibo Xu <xuzaibo@huawei.com>,
	Zhou Wang <wangzhou1@hisilicon.com>
Subject: Re: [PATCH 2/2] uacce: add uacce module
Date: Tue, 20 Aug 2019 20:38:46 +0800	[thread overview]
Message-ID: <350c937f-faee-f74a-ad76-03532c8648bd@linaro.org> (raw)
In-Reply-To: <20190819102250.GA2030@kroah.com>


On 2019/8/19 下午6:22, Greg Kroah-Hartman wrote:
> On Mon, Aug 19, 2019 at 05:09:23PM +0800, zhangfei.gao@foxmail.com wrote:
>> Hi, Greg
>>
>> Thanks for your kind suggestion.
>>
>> On 2019/8/15 下午10:12, Greg Kroah-Hartman wrote:
>>> On Wed, Aug 14, 2019 at 05:34:25PM +0800, Zhangfei Gao wrote:
>>>> diff --git a/include/uapi/misc/uacce.h b/include/uapi/misc/uacce.h
>>>> new file mode 100644
>>>> index 0000000..44a0a5d
>>>> --- /dev/null
>>>> +++ b/include/uapi/misc/uacce.h
>>>> @@ -0,0 +1,44 @@
>>>> +/* SPDX-License-Identifier: GPL-2.0-or-later */
>>>> +#ifndef _UAPIUUACCE_H
>>>> +#define _UAPIUUACCE_H
>>>> +
>>>> +#include <linux/types.h>
>>>> +#include <linux/ioctl.h>
>>>> +
>>>> +#define UACCE_CLASS_NAME	"uacce"
>>> Why is this in a uapi file?
>> User app need get attribute from /sys/class,
>> For example: /sys/class/uacce/hisi_zip-0/xxx
>> UACCE_CLASS_NAME here tells app which subsystem to open,
>> /sys/class/subsystem/
> But that never comes from a uapi file.  No other subsystem does this.
OK, got it
Maybe the entry info can come from Documentation/ABI/entries

Thanks