Re: [PATCH 2/2] uacce: add uacce module

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Aug 20, 2019 at 08:38:46PM +0800, zhangfei wrote:
> 
> 
> On 2019/8/19 下午6:22, Greg Kroah-Hartman wrote:
> > On Mon, Aug 19, 2019 at 05:09:23PM +0800, zhangfei.gao@foxmail.com wrote:
> > > Hi, Greg
> > > 
> > > Thanks for your kind suggestion.
> > > 
> > > On 2019/8/15 下午10:12, Greg Kroah-Hartman wrote:
> > > > On Wed, Aug 14, 2019 at 05:34:25PM +0800, Zhangfei Gao wrote:
> > > > > diff --git a/include/uapi/misc/uacce.h b/include/uapi/misc/uacce.h
> > > > > new file mode 100644
> > > > > index 0000000..44a0a5d
> > > > > --- /dev/null
> > > > > +++ b/include/uapi/misc/uacce.h
> > > > > @@ -0,0 +1,44 @@
> > > > > +/* SPDX-License-Identifier: GPL-2.0-or-later */
> > > > > +#ifndef _UAPIUUACCE_H
> > > > > +#define _UAPIUUACCE_H
> > > > > +
> > > > > +#include <linux/types.h>
> > > > > +#include <linux/ioctl.h>
> > > > > +
> > > > > +#define UACCE_CLASS_NAME	"uacce"
> > > > Why is this in a uapi file?
> > > User app need get attribute from /sys/class,
> > > For example: /sys/class/uacce/hisi_zip-0/xxx
> > > UACCE_CLASS_NAME here tells app which subsystem to open,
> > > /sys/class/subsystem/
> > But that never comes from a uapi file.  No other subsystem does this.
> OK, got it
> Maybe the entry info can come from Documentation/ABI/entries

Yes it can, we now have a tool in the tree that automatically parses
those entries and outputs it in a variety of different formats.

thanks,

greg k-h