* [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example
@ 2019-08-28 19:56 Peter Vernia
2019-08-29 14:52 ` Jan Kundrát
2019-09-02 14:40 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Peter Vernia @ 2019-08-28 19:56 UTC (permalink / raw)
To: peter.vernia
Cc: linus.walleij, robh+dt, mark.rutland, linux-gpio, devicetree,
linux-kernel, poeschel
The device-tree properties documentation-file specifies the property
"microchip,spi-present-mask" as required for MCP23SXX chips. However,
the device-tree-source example below it uses only "spi-present-mask".
Without "microchip," on the front, the driver will print "missing
spi-present-mask" when it initializes.
Update the device-tree example with the correct property-name.
Signed-off-by: Peter Vernia <peter.vernia@gmail.com>
---
Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
index 625a22e2f211..8b94aa8f5971 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
@@ -82,7 +82,7 @@ gpiom1: gpio@0 {
compatible = "microchip,mcp23s17";
gpio-controller;
#gpio-cells = <2>;
- spi-present-mask = <0x01>;
+ microchip,spi-present-mask = <0x01>;
reg = <0>;
spi-max-frequency = <1000000>;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example
2019-08-28 19:56 [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example Peter Vernia
@ 2019-08-29 14:52 ` Jan Kundrát
2019-09-02 14:40 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kundrát @ 2019-08-29 14:52 UTC (permalink / raw)
To: Peter Vernia
Cc: linus.walleij, robh+dt, mark.rutland, linux-gpio, devicetree,
linux-kernel, poeschel
On středa 28. srpna 2019 21:56:09 CEST, Peter Vernia wrote:
> The device-tree properties documentation-file specifies the property
> "microchip,spi-present-mask" as required for MCP23SXX chips. However,
> the device-tree-source example below it uses only "spi-present-mask".
> Without "microchip," on the front, the driver will print "missing
> spi-present-mask" when it initializes.
>
> Update the device-tree example with the correct property-name.
>
> Signed-off-by: Peter Vernia <peter.vernia@gmail.com>
Reviewed-by: Jan Kundrát <jan.kundrat@cesnet.cz>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> index 625a22e2f211..8b94aa8f5971 100644
> --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt
> @@ -82,7 +82,7 @@ gpiom1: gpio@0 {
> compatible = "microchip,mcp23s17";
> gpio-controller;
> #gpio-cells = <2>;
> - spi-present-mask = <0x01>;
> + microchip,spi-present-mask = <0x01>;
> reg = <0>;
> spi-max-frequency = <1000000>;
> };
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example
2019-08-28 19:56 [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example Peter Vernia
2019-08-29 14:52 ` Jan Kundrát
@ 2019-09-02 14:40 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-09-02 14:40 UTC (permalink / raw)
To: Peter Vernia
Cc: peter.vernia, linus.walleij, robh+dt, mark.rutland, linux-gpio,
devicetree, linux-kernel, poeschel
On Wed, 28 Aug 2019 15:56:09 -0400, Peter Vernia wrote:
> The device-tree properties documentation-file specifies the property
> "microchip,spi-present-mask" as required for MCP23SXX chips. However,
> the device-tree-source example below it uses only "spi-present-mask".
> Without "microchip," on the front, the driver will print "missing
> spi-present-mask" when it initializes.
>
> Update the device-tree example with the correct property-name.
>
> Signed-off-by: Peter Vernia <peter.vernia@gmail.com>
> ---
> Documentation/devicetree/bindings/pinctrl/pinctrl-mcp23s08.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-02 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-28 19:56 [PATCH] pinctrl-mcp23s08: Fix property-name in dt-example Peter Vernia
2019-08-29 14:52 ` Jan Kundrát
2019-09-02 14:40 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).