* linux-next: Fixes tag needs some work in the pm tree
@ 2019-09-10 14:33 Stephen Rothwell
2019-09-11 7:27 ` Heikki Krogerus
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2019-09-10 14:33 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Heikki Krogerus
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
Hi all,
In commit
fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
Fixes tag
Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
Did you mean
Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
or
Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: Fixes tag needs some work in the pm tree
2019-09-10 14:33 linux-next: Fixes tag needs some work in the pm tree Stephen Rothwell
@ 2019-09-11 7:27 ` Heikki Krogerus
2019-09-11 17:17 ` Rafael J. Wysocki
0 siblings, 1 reply; 19+ messages in thread
From: Heikki Krogerus @ 2019-09-11 7:27 UTC (permalink / raw)
To: Stephen Rothwell, Rafael J. Wysocki
Cc: Linux Next Mailing List, Linux Kernel Mailing List
On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
>
> Fixes tag
>
> Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Did you mean
>
> Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
>
> or
>
> Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
Rafael, it seems you have rebased your branch. Do you want me to
resend those fixes, or can you fix the tags in them yourself?
thanks,
--
heikki
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: Fixes tag needs some work in the pm tree
2019-09-11 7:27 ` Heikki Krogerus
@ 2019-09-11 17:17 ` Rafael J. Wysocki
2019-09-12 7:40 ` Heikki Krogerus
0 siblings, 1 reply; 19+ messages in thread
From: Rafael J. Wysocki @ 2019-09-11 17:17 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List
On Wednesday, September 11, 2019 9:27:41 AM CEST Heikki Krogerus wrote:
> On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> >
> > Fixes tag
> >
> > Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
> >
> > Did you mean
> >
> > Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> >
> > or
> >
> > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
>
> Rafael, it seems you have rebased your branch.
No, I haven't.
Actually, the commit ID is correct, but the name isn't.
You'd have been unlikely to get a valid commit ID matching anything with
"software node" in the subject had it been rebased. :-)
> Do you want me to resend those fixes, or can you fix the tags in them
> yourself?
I fixed that tag up.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: Fixes tag needs some work in the pm tree
2019-09-11 17:17 ` Rafael J. Wysocki
@ 2019-09-12 7:40 ` Heikki Krogerus
0 siblings, 0 replies; 19+ messages in thread
From: Heikki Krogerus @ 2019-09-12 7:40 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List
On Wed, Sep 11, 2019 at 07:17:52PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, September 11, 2019 9:27:41 AM CEST Heikki Krogerus wrote:
> > On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > In commit
> > >
> > > fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> > >
> > > Fixes tag
> > >
> > > Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> > >
> > > has these problem(s):
> > >
> > > - Subject does not match target commit subject
> > > Just use
> > > git log -1 --format='Fixes: %h ("%s")'
> > >
> > > Did you mean
> > >
> > > Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> > >
> > > or
> > >
> > > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
> >
> > Rafael, it seems you have rebased your branch.
>
> No, I haven't.
>
> Actually, the commit ID is correct, but the name isn't.
>
> You'd have been unlikely to get a valid commit ID matching anything with
> "software node" in the subject had it been rebased. :-)
Ah. I've added the tag line manually (for some reason). I'm sorry
about that. I usually use this:
% git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
> > Do you want me to resend those fixes, or can you fix the tags in them
> > yourself?
>
> I fixed that tag up.
Thanks Rafael!
--
heikki
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2024-03-06 22:05 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2024-03-06 22:05 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Perry Yuan, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
Hi all,
In commit
a51ab63b297c ("ACPI: CPPC: enable AMD CPPC V2 support for family 17h processors")
Fixes tag
Fixes: fbd74d1689 ("ACPI: CPPC: Fix enabling CPPC on AMD systems with shared memory")
has these problem(s):
- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or
more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2024-02-25 21:38 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2024-02-25 21:38 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Sakari Ailus, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
Hi all,
In commit
43b549c5d8de ("ACPI: property: Polish ignoring bad data nodes")
Fixes tag
Fixes: 6018731b04ca ("ACPI: property: Ignore bad graph port nodes on Dell XPS 9315")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 5bd4edbbf920 ("ACPI: property: Ignore bad graph port nodes on Dell XPS 9315")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2023-01-24 20:42 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2023-01-24 20:42 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
Hi all,
In commit
26c9a5984cba ("thermal: intel: int340x: Fix unitialized variable error")
Fixes tag
Fixes: d58c653e9e26 ("thermal: intel: int340x: Use generic trip points")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: fecb78002029 ("thermal: intel: int340x: Use generic trip points")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2023-01-11 21:16 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2023-01-11 21:16 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Perry Yuan, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
Hi all,
In commit
4f3085f87b51 ("cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering")
Fixes tag
Fixes: 1d215f0319 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")
has these problem(s):
- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or
more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2022-10-16 3:44 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2022-10-16 3:44 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Jiri Slaby (SUSE), Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 383 bytes --]
Hi all,
In commit
bfcdf58380b1 ("ACPI: resource: do IRQ override on LENOVO IdeaPad")
Fixes tag
Fixes: 37c81d9f1d1b (ACPI: resource: skip IRQ override on AMD Zen platforms)
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2022-05-19 23:02 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2022-05-19 23:02 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Chanwoo Choi, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
Hi all,
In commit
42d2607d91c4 ("PM / devfreq: passive: Return non-error when not-supported event is required")
Fixes tag
Fixes: ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: Fixes tag needs some work in the pm tree
2021-04-07 22:38 Stephen Rothwell
@ 2021-04-08 7:52 ` Vitaly Kuznetsov
0 siblings, 0 replies; 19+ messages in thread
From: Vitaly Kuznetsov @ 2021-04-08 7:52 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, Linux Next Mailing List, Stephen Rothwell
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> Hi all,
>
> In commit
>
> fa26d0c778b4 ("ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m")
>
> Fixes tag
>
> Fixes: 8cdddd182bd7 ("CPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()")
"A" in "ACPI" seems to be missing
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
This is an extremely unlucky fix :-(
--
Vitaly
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2021-04-07 22:38 Stephen Rothwell
2021-04-08 7:52 ` Vitaly Kuznetsov
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2021-04-07 22:38 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Vitaly Kuznetsov, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
Hi all,
In commit
fa26d0c778b4 ("ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m")
Fixes tag
Fixes: 8cdddd182bd7 ("CPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: Fixes tag needs some work in the pm tree
2020-08-19 22:01 Stephen Rothwell
@ 2020-08-20 4:55 ` Viresh Kumar
0 siblings, 0 replies; 19+ messages in thread
From: Viresh Kumar @ 2020-08-20 4:55 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Rafael J. Wysocki, Linux Next Mailing List,
Linux Kernel Mailing List, Rajendra Nayak
On 20-08-20, 08:01, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> ceac7fc18ac7 ("opp: Enable resources again if they were disabled earlier")
>
> Fixes tag
>
> Fixes: cd7ea582 ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> or later) just making sure it is not set (or set to "auto").
It came from the author and I failed to verify it :(
Rafael: Do you want me to resend the pull request with this fixed ? Or
something else ?
--
viresh
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2020-08-19 22:01 Stephen Rothwell
2020-08-20 4:55 ` Viresh Kumar
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2020-08-19 22:01 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Rajendra Nayak, Viresh Kumar
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
Hi all,
In commit
ceac7fc18ac7 ("opp: Enable resources again if they were disabled earlier")
Fixes tag
Fixes: cd7ea582 ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2020-03-04 20:53 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2020-03-04 20:53 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Mauro Carvalho Chehab
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
Hi all,
In commit
ea28c454067f ("docs: cpufreq: fix a broken reference")
Fixes tag
Fixes: 78a0abeca1bd ("Documentation: cpufreq: Move legacy driver documentation")
has these problem(s):
- Target SHA1 does not exist
Maybe you meant
Fixes: 03b22496502d ("Documentation: cpufreq: Move legacy driver documentation")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2019-12-17 20:17 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2019-12-17 20:17 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Zhengyuan Liu
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
Hi all,
78d3e7c19e2d ("tools/power/acpi: fix compilation error")
Fixes tag
Fixes: d5a4b1a540b ("tools/power/acpi: Remove direct kernel source include reference")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: linux-next: Fixes tag needs some work in the pm tree
2019-10-14 20:59 Stephen Rothwell
@ 2019-10-15 10:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 19+ messages in thread
From: Rafael J. Wysocki @ 2019-10-15 10:08 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Shevchenko
On Monday, October 14, 2019 10:59:04 PM CEST Stephen Rothwell wrote:
>
> --Sig_/eM_f_lhAmw+jp3bqTr5YSMd
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
>
> Hi all,
>
> In commit
>
> b2afd668c323 ("ACPI / utils: Move acpi_dev_get_first_match_dev() under CO=
> NFIG_ACPI")
>
> Fixes tag
>
> Fixes: 817b4d64da03 ("Introduce acpi_dev_get_first_match_dev() helper")
>
> has these problem(s):
>
> - Subject does not match target commit subject
Fixed, thanks!
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2019-10-14 20:59 Stephen Rothwell
2019-10-15 10:08 ` Rafael J. Wysocki
0 siblings, 1 reply; 19+ messages in thread
From: Stephen Rothwell @ 2019-10-14 20:59 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Andy Shevchenko
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
Hi all,
In commit
b2afd668c323 ("ACPI / utils: Move acpi_dev_get_first_match_dev() under CONFIG_ACPI")
Fixes tag
Fixes: 817b4d64da03 ("Introduce acpi_dev_get_first_match_dev() helper")
has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* linux-next: Fixes tag needs some work in the pm tree
@ 2019-07-10 11:26 Stephen Rothwell
0 siblings, 0 replies; 19+ messages in thread
From: Stephen Rothwell @ 2019-07-10 11:26 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Wen Yang
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
Hi all,
In commit
f43e075f7252 ("cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init()")
Fixes tag
Fixes: a9acc26b75f ("cpufreq/pasemi: fix possible object reference leak")
has these problem(s):
- SHA1 should be at least 12 digits long
Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
or later) just making sure it is not set (or set to "auto").
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2024-03-06 22:05 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-10 14:33 linux-next: Fixes tag needs some work in the pm tree Stephen Rothwell
2019-09-11 7:27 ` Heikki Krogerus
2019-09-11 17:17 ` Rafael J. Wysocki
2019-09-12 7:40 ` Heikki Krogerus
-- strict thread matches above, loose matches on Subject: below --
2024-03-06 22:05 Stephen Rothwell
2024-02-25 21:38 Stephen Rothwell
2023-01-24 20:42 Stephen Rothwell
2023-01-11 21:16 Stephen Rothwell
2022-10-16 3:44 Stephen Rothwell
2022-05-19 23:02 Stephen Rothwell
2021-04-07 22:38 Stephen Rothwell
2021-04-08 7:52 ` Vitaly Kuznetsov
2020-08-19 22:01 Stephen Rothwell
2020-08-20 4:55 ` Viresh Kumar
2020-03-04 20:53 Stephen Rothwell
2019-12-17 20:17 Stephen Rothwell
2019-10-14 20:59 Stephen Rothwell
2019-10-15 10:08 ` Rafael J. Wysocki
2019-07-10 11:26 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).