* Re: [PATCH -next] PCI: tegra: Add missing include file
2019-09-20 1:48 [PATCH -next] PCI: tegra: Add missing include file YueHaibing
@ 2019-09-20 3:17 ` Vidya Sagar
2019-09-20 8:17 ` Andrew Murray
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Vidya Sagar @ 2019-09-20 3:17 UTC (permalink / raw)
To: YueHaibing, lorenzo.pieralisi, andrew.murray, bhelgaas,
thierry.reding, jonathanh, treding
Cc: linux-pci, linux-tegra, linux-kernel
On 9/20/2019 7:18 AM, YueHaibing wrote:
> Fix build error without CONFIG_PINCTRL
>
> drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
> did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
> ret = pinctrl_pm_select_default_state(dev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> prandom_seed_full_state
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e4..b219d3b2 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -28,6 +28,7 @@
> #include <linux/reset.h>
> #include <linux/resource.h>
> #include <linux/types.h>
> +#include <linux/pinctrl/consumer.h>
> #include "pcie-designware.h"
> #include <soc/tegra/bpmp.h>
> #include <soc/tegra/bpmp-abi.h>
>
Thanks for pushing this change.
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH -next] PCI: tegra: Add missing include file
2019-09-20 1:48 [PATCH -next] PCI: tegra: Add missing include file YueHaibing
2019-09-20 3:17 ` Vidya Sagar
@ 2019-09-20 8:17 ` Andrew Murray
2019-09-20 10:39 ` [PATCH v2 " YueHaibing
2019-09-20 19:28 ` [PATCH " Bjorn Helgaas
3 siblings, 0 replies; 7+ messages in thread
From: Andrew Murray @ 2019-09-20 8:17 UTC (permalink / raw)
To: YueHaibing
Cc: lorenzo.pieralisi, bhelgaas, thierry.reding, jonathanh, vidyas,
treding, linux-pci, linux-tegra, linux-kernel
On Fri, Sep 20, 2019 at 09:48:07AM +0800, YueHaibing wrote:
> Fix build error without CONFIG_PINCTRL
>
> drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
> did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
> ret = pinctrl_pm_select_default_state(dev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> prandom_seed_full_state
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e4..b219d3b2 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -28,6 +28,7 @@
> #include <linux/reset.h>
> #include <linux/resource.h>
> #include <linux/types.h>
> +#include <linux/pinctrl/consumer.h>
> #include "pcie-designware.h"
> #include <soc/tegra/bpmp.h>
> #include <soc/tegra/bpmp-abi.h>
Thanks for spotting and fixing this. Is it possible to keep the include
list in alphabetical order?
Thanks,
Andrew Murray
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 -next] PCI: tegra: Add missing include file
2019-09-20 1:48 [PATCH -next] PCI: tegra: Add missing include file YueHaibing
2019-09-20 3:17 ` Vidya Sagar
2019-09-20 8:17 ` Andrew Murray
@ 2019-09-20 10:39 ` YueHaibing
2019-09-20 10:53 ` Andrew Murray
2019-09-20 15:17 ` Lorenzo Pieralisi
2019-09-20 19:28 ` [PATCH " Bjorn Helgaas
3 siblings, 2 replies; 7+ messages in thread
From: YueHaibing @ 2019-09-20 10:39 UTC (permalink / raw)
To: lorenzo.pieralisi, andrew.murray, bhelgaas, thierry.reding,
jonathanh, vidyas, yuehaibing, treding
Cc: linux-pci, linux-tegra, linux-kernel
Fix build error without CONFIG_PINCTRL
drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
ret = pinctrl_pm_select_default_state(dev);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
prandom_seed_full_state
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
---
v2: keep alphabetical order
---
drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 09ed8e4..f89f5ac 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -22,6 +22,7 @@
#include <linux/of_pci.h>
#include <linux/pci.h>
#include <linux/phy/phy.h>
+#include <linux/pinctrl/consumer.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/random.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 -next] PCI: tegra: Add missing include file
2019-09-20 10:39 ` [PATCH v2 " YueHaibing
@ 2019-09-20 10:53 ` Andrew Murray
2019-09-20 15:17 ` Lorenzo Pieralisi
1 sibling, 0 replies; 7+ messages in thread
From: Andrew Murray @ 2019-09-20 10:53 UTC (permalink / raw)
To: YueHaibing
Cc: lorenzo.pieralisi, bhelgaas, thierry.reding, jonathanh, vidyas,
treding, linux-pci, linux-tegra, linux-kernel
On Fri, Sep 20, 2019 at 06:39:25PM +0800, YueHaibing wrote:
> Fix build error without CONFIG_PINCTRL
>
> drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
> did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
> ret = pinctrl_pm_select_default_state(dev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> prandom_seed_full_state
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> v2: keep alphabetical order
> ---
Thanks,
Reviewed-by: Andrew Murray <andrew.murray@arm.com>
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e4..f89f5ac 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -22,6 +22,7 @@
> #include <linux/of_pci.h>
> #include <linux/pci.h>
> #include <linux/phy/phy.h>
> +#include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/random.h>
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2 -next] PCI: tegra: Add missing include file
2019-09-20 10:39 ` [PATCH v2 " YueHaibing
2019-09-20 10:53 ` Andrew Murray
@ 2019-09-20 15:17 ` Lorenzo Pieralisi
1 sibling, 0 replies; 7+ messages in thread
From: Lorenzo Pieralisi @ 2019-09-20 15:17 UTC (permalink / raw)
To: YueHaibing
Cc: andrew.murray, bhelgaas, thierry.reding, jonathanh, vidyas,
treding, linux-pci, linux-tegra, linux-kernel
On Fri, Sep 20, 2019 at 06:39:25PM +0800, YueHaibing wrote:
> Fix build error without CONFIG_PINCTRL
>
> drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
> did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
> ret = pinctrl_pm_select_default_state(dev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> prandom_seed_full_state
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> v2: keep alphabetical order
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
Squashed in the original commit and pushed out pci/tegra
again.
Thanks,
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e4..f89f5ac 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -22,6 +22,7 @@
> #include <linux/of_pci.h>
> #include <linux/pci.h>
> #include <linux/phy/phy.h>
> +#include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/random.h>
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] PCI: tegra: Add missing include file
2019-09-20 1:48 [PATCH -next] PCI: tegra: Add missing include file YueHaibing
` (2 preceding siblings ...)
2019-09-20 10:39 ` [PATCH v2 " YueHaibing
@ 2019-09-20 19:28 ` Bjorn Helgaas
3 siblings, 0 replies; 7+ messages in thread
From: Bjorn Helgaas @ 2019-09-20 19:28 UTC (permalink / raw)
To: YueHaibing
Cc: lorenzo.pieralisi, andrew.murray, thierry.reding, jonathanh,
vidyas, treding, linux-pci, linux-tegra, linux-kernel
On Fri, Sep 20, 2019 at 09:48:07AM +0800, YueHaibing wrote:
> Fix build error without CONFIG_PINCTRL
>
> drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
> did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
> ret = pinctrl_pm_select_default_state(dev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> prandom_seed_full_state
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, I folded this into ab2a50e7602b (with the include in alpha
order) and updated my "next" branch.
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e4..b219d3b2 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -28,6 +28,7 @@
> #include <linux/reset.h>
> #include <linux/resource.h>
> #include <linux/types.h>
> +#include <linux/pinctrl/consumer.h>
> #include "pcie-designware.h"
> #include <soc/tegra/bpmp.h>
> #include <soc/tegra/bpmp-abi.h>
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread