* [PATCH v2] drm/panfrost: Reduce the amount of logs on deferred probe
@ 2019-09-23 17:12 Krzysztof Kozlowski
2019-09-25 9:25 ` Steven Price
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-23 17:12 UTC (permalink / raw)
To: Rob Herring, Tomeu Vizoso, David Airlie, Daniel Vetter,
dri-devel, linux-kernel
Cc: Steven Price, Krzysztof Kozlowski
There is no point to print deferred probe (and its failures to get
resources) as an error. Also there is no need to print regulator errors
twice.
In case of multiple probe tries this would pollute the dmesg.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Changes since v1:
1. Remove second error message from calling panfrost_regulator_init().
---
drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
index 46b0b02e4289..287c6ba314d9 100644
--- a/drivers/gpu/drm/panfrost/panfrost_device.c
+++ b/drivers/gpu/drm/panfrost/panfrost_device.c
@@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
pfdev->regulator = NULL;
if (ret == -ENODEV)
return 0;
- dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(pfdev->dev, "failed to get regulator: %d\n",
+ ret);
return ret;
}
@@ -133,10 +135,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
}
err = panfrost_regulator_init(pfdev);
- if (err) {
- dev_err(pfdev->dev, "regulator init failed %d\n", err);
+ if (err)
goto err_out0;
- }
err = panfrost_reset_init(pfdev);
if (err) {
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/panfrost: Reduce the amount of logs on deferred probe
2019-09-23 17:12 [PATCH v2] drm/panfrost: Reduce the amount of logs on deferred probe Krzysztof Kozlowski
@ 2019-09-25 9:25 ` Steven Price
0 siblings, 0 replies; 2+ messages in thread
From: Steven Price @ 2019-09-25 9:25 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Tomeu Vizoso, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
On 23/09/2019 18:12, Krzysztof Kozlowski wrote:
> There is no point to print deferred probe (and its failures to get
> resources) as an error. Also there is no need to print regulator errors
> twice.
>
> In case of multiple probe tries this would pollute the dmesg.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Steven Price <steven.price@arm.com>
>
> ---
>
> Changes since v1:
> 1. Remove second error message from calling panfrost_regulator_init().
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 46b0b02e4289..287c6ba314d9 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
> pfdev->regulator = NULL;
> if (ret == -ENODEV)
> return 0;
> - dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(pfdev->dev, "failed to get regulator: %d\n",
> + ret);
> return ret;
> }
>
> @@ -133,10 +135,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
> }
>
> err = panfrost_regulator_init(pfdev);
> - if (err) {
> - dev_err(pfdev->dev, "regulator init failed %d\n", err);
> + if (err)
> goto err_out0;
> - }
>
> err = panfrost_reset_init(pfdev);
> if (err) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-25 9:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-23 17:12 [PATCH v2] drm/panfrost: Reduce the amount of logs on deferred probe Krzysztof Kozlowski
2019-09-25 9:25 ` Steven Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).