* [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings
@ 2019-10-15 10:33 Rajendra Nayak
2019-10-15 10:33 ` [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
2019-10-16 5:21 ` [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings Vinod Koul
0 siblings, 2 replies; 8+ messages in thread
From: Rajendra Nayak @ 2019-10-15 10:33 UTC (permalink / raw)
To: agross, robh+dt, bjorn.andersson
Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak
Add a SoC string 'sc7180' for the qualcomm SC7180 SoC.
Also add a new board type 'idp'
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index e39d8f02e33c..0a60ea051541 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -36,6 +36,7 @@ description: |
mdm9615
ipq8074
sdm845
+ sc7180
The 'board' element must be one of the following strings:
@@ -46,6 +47,7 @@ description: |
sbc
hk01
qrd
+ idp
The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
where the minor number may be omitted when it's zero, i.e. v1.0 is the same
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc
2019-10-15 10:33 [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings Rajendra Nayak
@ 2019-10-15 10:33 ` Rajendra Nayak
2019-10-16 5:25 ` Vinod Koul
2019-10-16 5:21 ` [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings Vinod Koul
1 sibling, 1 reply; 8+ messages in thread
From: Rajendra Nayak @ 2019-10-15 10:33 UTC (permalink / raw)
To: agross, robh+dt, bjorn.andersson
Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak, Taniya Das
Add skeletal sc7180 SoC dtsi and idp board dts files.
Co-developed-by: Taniya Das <tdas@codeaurora.org>
Signed-off-by: Taniya Das <tdas@codeaurora.org>
Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
This isn't ready for merge yet, depends on gcc driver patches [1]
for the DT header inclusion
[1] https://www.spinics.net/lists/linux-clk/msg41851.html
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 47 ++++
arch/arm64/boot/dts/qcom/sc7180.dtsi | 318 ++++++++++++++++++++++++
3 files changed, 366 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sc7180-idp.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7180.dtsi
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 6498a1ec893f..7a5c2f7fe37f 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-asus-novago-tp370ql.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8998-hp-envy-x2.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8998-lenovo-miix-630.dtb
dtb-$(CONFIG_ARCH_QCOM) += msm8998-mtp.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r2.dtb
dtb-$(CONFIG_ARCH_QCOM) += sdm845-cheza-r3.dtb
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
new file mode 100644
index 000000000000..f8b7e098f5b4
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -0,0 +1,47 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * SC7180 IDP board device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "sc7180.dtsi"
+
+/ {
+ model = "Qualcomm Technologies, Inc. SC7180 IDP";
+ compatible = "qcom,sc7180-idp";
+
+ aliases {
+ serial0 = &uart2;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+};
+
+&qupv3_id_0 {
+ status = "okay";
+};
+
+&uart2 {
+ status = "okay";
+};
+
+/* PINCTRL - additions to nodes defined in sc7180.dtsi */
+
+&qup_uart2_default {
+ pinconf-tx {
+ pins = "gpio44";
+ drive-strength = <2>;
+ bias-disable;
+ };
+
+ pinconf-rx {
+ pins = "gpio45";
+ drive-strength = <2>;
+ bias-pull-up;
+ };
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
new file mode 100644
index 000000000000..2e127571892d
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -0,0 +1,318 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * SC7180 SoC device tree source
+ *
+ * Copyright (c) 2019, The Linux Foundation. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/clock/qcom,gcc-sc7180.h>
+
+/ {
+ interrupt-parent = <&intc>;
+
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ chosen { };
+
+ memory@80000000 {
+ device_type = "memory";
+ /* We expect the bootloader to fill in the size */
+ reg = <0 0x80000000 0 0>;
+ };
+
+ cpus {
+ #address-cells = <2>;
+ #size-cells = <0>;
+
+ CPU0: cpu@0 {
+ device_type = "cpu";
+ compatible = "arm,armv8";
+ reg = <0x0 0x0>;
+ enable-method = "psci";
+ next-level-cache = <&L2_0>;
+ L2_0: l2-cache {
+ compatible = "cache";
+ next-level-cache = <&L3_0>;
+ L3_0: l3-cache {
+ compatible = "cache";
+ };
+ };
+ };
+
+ CPU1: cpu@100 {
+ device_type = "cpu";
+ compatible = "arm,armv8";
+ reg = <0x0 0x100>;
+ enable-method = "psci";
+ next-level-cache = <&L2_100>;
+ L2_100: l2-cache {
+ compatible = "cache";
+ next-level-cache = <&L3_0>;
+ };
+ };
+
+ CPU2: cpu@200 {
+ device_type = "cpu";
+ compatible = "arm,armv8";
+ reg = <0x0 0x200>;
+ enable-method = "psci";
+ next-level-cache = <&L2_200>;
+ L2_200: l2-cache {
+ compatible = "cache";
+ next-level-cache = <&L3_0>;
+ };
+ };
+
+ CPU3: cpu@300 {
+ device_type = "cpu";
+ compatible = "arm,armv8";
+ reg = <0x0 0x300>;
+ enable-method = "psci";
+ next-level-cache = <&L2_300>;
+ L2_300: l2-cache {
+ compatible = "cache";
+ next-level-cache = <&L3_0>;
+ };
+ };
+
+ CPU4: cpu@400 {
+ device_type = "cpu";
+ compatible = "arm,armv8";
+ reg = <0x0 0x400>;
+ enable-method = "psci";
+ next-level-cache = <&L2_400>;
+ L2_400: l2-cache {
+ compatible = "cache";
+ next-level-cache = <&L3_0>;
+ };
+ };
+
+ CPU5: cpu@500 {
+ device_type = "cpu";
+ compatible = "arm,armv8";
+ reg = <0x0 0x500>;
+ enable-method = "psci";
+ next-level-cache = <&L2_500>;
+ L2_500: l2-cache {
+ compatible = "cache";
+ next-level-cache = <&L3_0>;
+ };
+ };
+
+ CPU6: cpu@600 {
+ device_type = "cpu";
+ compatible = "arm,armv8";
+ reg = <0x0 0x600>;
+ enable-method = "psci";
+ next-level-cache = <&L2_600>;
+ L2_600: l2-cache {
+ compatible = "cache";
+ next-level-cache = <&L3_0>;
+ };
+ };
+
+ CPU7: cpu@700 {
+ device_type = "cpu";
+ compatible = "arm,armv8";
+ reg = <0x0 0x700>;
+ enable-method = "psci";
+ next-level-cache = <&L2_700>;
+ L2_700: l2-cache {
+ compatible = "cache";
+ next-level-cache = <&L3_0>;
+ };
+ };
+ };
+
+ pmu {
+ compatible = "arm,armv8-pmuv3";
+ interrupts = <GIC_PPI 5 IRQ_TYPE_LEVEL_HIGH>;
+ };
+
+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>,
+ <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>;
+ };
+
+ clocks {
+ xo_board: xo-board {
+ compatible = "fixed-clock";
+ clock-frequency = <38400000>;
+ clock-output-names = "xo_board";
+ #clock-cells = <0>;
+ };
+
+ sleep_clk: sleep-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <32764>;
+ clock-output-names = "sleep_clk";
+ #clock-cells = <0>;
+ };
+
+ bi_tcxo: bi_tcxo {
+ compatible = "fixed-factor-clock";
+ clocks = <&xo_board>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ #clock-cells = <0>;
+ };
+
+ bi_tcxo_ao: bi_tcxo_ao {
+ compatible = "fixed-factor-clock";
+ clocks = <&xo_board>;
+ clock-mult = <1>;
+ clock-div = <2>;
+ #clock-cells = <0>;
+ };
+ };
+
+ psci {
+ compatible = "arm,psci-1.0";
+ method = "smc";
+ };
+
+ soc: soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges = <0 0 0 0 0x10 0>;
+ dma-ranges = <0 0 0 0 0x10 0>;
+ compatible = "simple-bus";
+
+ gcc: clock-controller@100000 {
+ compatible = "qcom,gcc-sc7180";
+ reg = <0 0x00100000 0 0x1f0000>;
+ clocks = <&bi_tcxo>, <&bi_tcxo_ao>;
+ clock-names = "bi_tcxo", "bi_tcxo_ao";
+ #clock-cells = <1>;
+ #reset-cells = <1>;
+ #power-domain-cells = <1>;
+ };
+
+ qupv3_id_0: geniqup@ac0000 {
+ compatible = "qcom,geni-se-qup";
+ reg = <0 0x00ac0000 0 0x6000>;
+ clock-names = "m-ahb", "s-ahb";
+ clocks = <&gcc GCC_QUPV3_WRAP_1_M_AHB_CLK>,
+ <&gcc GCC_QUPV3_WRAP_1_S_AHB_CLK>;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+ status = "disabled";
+
+ uart2: serial@a88000 {
+ compatible = "qcom,geni-debug-uart";
+ reg = <0 0x00a88000 0 0x4000>;
+ clock-names = "se";
+ clocks = <&gcc GCC_QUPV3_WRAP1_S2_CLK>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&qup_uart2_default>;
+ interrupts = <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
+ };
+
+ tlmm: pinctrl@3500000 {
+ compatible = "qcom,sc7180-pinctrl";
+ reg = <0 0x03500000 0 0x300000>,
+ <0 0x03900000 0 0x300000>,
+ <0 0x03d00000 0 0x300000>;
+ reg-names = "west", "north", "south";
+ interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ gpio-ranges = <&tlmm 0 0 120>;
+
+ qup_uart2_default: qup-uart2-default {
+ pinmux {
+ pins = "gpio44", "gpio45";
+ function = "qup12";
+ };
+ };
+ };
+
+ intc: interrupt-controller@17a00000 {
+ compatible = "arm,gic-v3";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+ #interrupt-cells = <3>;
+ interrupt-controller;
+ reg = <0 0x17a00000 0 0x10000>, /* GICD */
+ <0 0x17a60000 0 0x100000>; /* GICR * 8 */
+ interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+
+ gic-its@17a40000 {
+ compatible = "arm,gic-v3-its";
+ msi-controller;
+ #msi-cells = <1>;
+ reg = <0 0x17a40000 0 0x20000>;
+ status = "disabled";
+ };
+ };
+
+ timer@17c20000{
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+ compatible = "arm,armv7-timer-mem";
+ reg = <0 0x17c20000 0 0x1000>;
+
+ frame@17c21000 {
+ frame-number = <0>;
+ interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
+ reg = <0 0x17c21000 0 0x1000>,
+ <0 0x17c22000 0 0x1000>;
+ };
+
+ frame@17c23000 {
+ frame-number = <1>;
+ interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+ reg = <0 0x17c23000 0 0x1000>;
+ status = "disabled";
+ };
+
+ frame@17c25000 {
+ frame-number = <2>;
+ interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+ reg = <0 0x17c25000 0 0x1000>;
+ status = "disabled";
+ };
+
+ frame@17c27000 {
+ frame-number = <3>;
+ interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
+ reg = <0 0x17c27000 0 0x1000>;
+ status = "disabled";
+ };
+
+ frame@17c29000 {
+ frame-number = <4>;
+ interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
+ reg = <0 0x17c29000 0 0x1000>;
+ status = "disabled";
+ };
+
+ frame@17c2b000 {
+ frame-number = <5>;
+ interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
+ reg = <0 0x17c2b000 0 0x1000>;
+ status = "disabled";
+ };
+
+ frame@17c2d000 {
+ frame-number = <6>;
+ interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
+ reg = <0 0x17c2d000 0 0x1000>;
+ status = "disabled";
+ };
+ };
+ };
+};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings
2019-10-15 10:33 [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings Rajendra Nayak
2019-10-15 10:33 ` [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
@ 2019-10-16 5:21 ` Vinod Koul
1 sibling, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2019-10-16 5:21 UTC (permalink / raw)
To: Rajendra Nayak
Cc: agross, robh+dt, bjorn.andersson, linux-arm-msm, devicetree,
linux-kernel
On 15-10-19, 16:03, Rajendra Nayak wrote:
> Add a SoC string 'sc7180' for the qualcomm SC7180 SoC.
> Also add a new board type 'idp'
Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index e39d8f02e33c..0a60ea051541 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -36,6 +36,7 @@ description: |
> mdm9615
> ipq8074
> sdm845
> + sc7180
>
> The 'board' element must be one of the following strings:
>
> @@ -46,6 +47,7 @@ description: |
> sbc
> hk01
> qrd
> + idp
>
> The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor>
> where the minor number may be omitted when it's zero, i.e. v1.0 is the same
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc
2019-10-15 10:33 ` [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
@ 2019-10-16 5:25 ` Vinod Koul
2019-10-16 7:52 ` Taniya Das
2019-10-16 8:15 ` Rajendra Nayak
0 siblings, 2 replies; 8+ messages in thread
From: Vinod Koul @ 2019-10-16 5:25 UTC (permalink / raw)
To: Rajendra Nayak
Cc: agross, robh+dt, bjorn.andersson, linux-arm-msm, devicetree,
linux-kernel, Taniya Das
On 15-10-19, 16:03, Rajendra Nayak wrote:
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>,
> + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + clocks {
Can we have these sorted alphabetically please
> + xo_board: xo-board {
> + compatible = "fixed-clock";
> + clock-frequency = <38400000>;
> + clock-output-names = "xo_board";
> + #clock-cells = <0>;
> + };
> +
> + sleep_clk: sleep-clk {
> + compatible = "fixed-clock";
> + clock-frequency = <32764>;
> + clock-output-names = "sleep_clk";
> + #clock-cells = <0>;
> + };
> +
> + bi_tcxo: bi_tcxo {
why is this a clock defined here? Isnt this gcc clock?
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc
2019-10-16 5:25 ` Vinod Koul
@ 2019-10-16 7:52 ` Taniya Das
2019-10-16 8:24 ` Vinod Koul
2019-10-16 8:15 ` Rajendra Nayak
1 sibling, 1 reply; 8+ messages in thread
From: Taniya Das @ 2019-10-16 7:52 UTC (permalink / raw)
To: Vinod Koul, Rajendra Nayak
Cc: agross, robh+dt, bjorn.andersson, linux-arm-msm, devicetree,
linux-kernel
Hi Vinod,
On 10/16/2019 10:55 AM, Vinod Koul wrote:
> On 15-10-19, 16:03, Rajendra Nayak wrote:
>
>> + timer {
>> + compatible = "arm,armv8-timer";
>> + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>;
>> + };
>> +
>> + clocks {
>
> Can we have these sorted alphabetically please
>
>> + xo_board: xo-board {
>> + compatible = "fixed-clock";
>> + clock-frequency = <38400000>;
>> + clock-output-names = "xo_board";
>> + #clock-cells = <0>;
>> + };
>> +
>> + sleep_clk: sleep-clk {
>> + compatible = "fixed-clock";
>> + clock-frequency = <32764>;
>> + clock-output-names = "sleep_clk";
>> + #clock-cells = <0>;
>> + };
>> +
>> + bi_tcxo: bi_tcxo {
>
> why is this a clock defined here? Isnt this gcc clock?
>
This is a RPMH-controlled clock and not from GCC. It is the parent clock
for GCC RCGs/PLLs.
Once the RPMH clock support is added these would be removed.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc
2019-10-16 5:25 ` Vinod Koul
2019-10-16 7:52 ` Taniya Das
@ 2019-10-16 8:15 ` Rajendra Nayak
1 sibling, 0 replies; 8+ messages in thread
From: Rajendra Nayak @ 2019-10-16 8:15 UTC (permalink / raw)
To: Vinod Koul
Cc: agross, robh+dt, bjorn.andersson, linux-arm-msm, devicetree,
linux-kernel, Taniya Das
On 10/16/2019 10:55 AM, Vinod Koul wrote:
> On 15-10-19, 16:03, Rajendra Nayak wrote:
>
>> + timer {
>> + compatible = "arm,armv8-timer";
>> + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>,
>> + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>;
>> + };
>> +
>> + clocks {
>
> Can we have these sorted alphabetically please
will do, thanks.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc
2019-10-16 7:52 ` Taniya Das
@ 2019-10-16 8:24 ` Vinod Koul
2019-10-16 10:43 ` Taniya Das
0 siblings, 1 reply; 8+ messages in thread
From: Vinod Koul @ 2019-10-16 8:24 UTC (permalink / raw)
To: Taniya Das
Cc: Rajendra Nayak, agross, robh+dt, bjorn.andersson, linux-arm-msm,
devicetree, linux-kernel
On 16-10-19, 13:22, Taniya Das wrote:
> Hi Vinod,
>
> On 10/16/2019 10:55 AM, Vinod Koul wrote:
> > On 15-10-19, 16:03, Rajendra Nayak wrote:
> >
> > > + timer {
> > > + compatible = "arm,armv8-timer";
> > > + interrupts = <GIC_PPI 1 IRQ_TYPE_LEVEL_LOW>,
> > > + <GIC_PPI 2 IRQ_TYPE_LEVEL_LOW>,
> > > + <GIC_PPI 3 IRQ_TYPE_LEVEL_LOW>,
> > > + <GIC_PPI 0 IRQ_TYPE_LEVEL_LOW>;
> > > + };
> > > +
> > > + clocks {
> >
> > Can we have these sorted alphabetically please
> >
> > > + xo_board: xo-board {
> > > + compatible = "fixed-clock";
> > > + clock-frequency = <38400000>;
> > > + clock-output-names = "xo_board";
> > > + #clock-cells = <0>;
> > > + };
> > > +
> > > + sleep_clk: sleep-clk {
> > > + compatible = "fixed-clock";
> > > + clock-frequency = <32764>;
> > > + clock-output-names = "sleep_clk";
> > > + #clock-cells = <0>;
> > > + };
> > > +
> > > + bi_tcxo: bi_tcxo {
> >
> > why is this a clock defined here? Isnt this gcc clock?
>
> This is a RPMH-controlled clock and not from GCC. It is the parent clock for
> GCC RCGs/PLLs.
Yes right!
> Once the RPMH clock support is added these would be removed.
Wont it make sense to keep this bit not upstream and then remove that
part when you have rpmh support available. Reduces the churn upstream!
The parent can be xo_board till then!
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc
2019-10-16 8:24 ` Vinod Koul
@ 2019-10-16 10:43 ` Taniya Das
0 siblings, 0 replies; 8+ messages in thread
From: Taniya Das @ 2019-10-16 10:43 UTC (permalink / raw)
To: Vinod Koul
Cc: Rajendra Nayak, agross, robh+dt, bjorn.andersson, linux-arm-msm,
devicetree, linux-kernel
>>>> + xo_board: xo-board {
>>>> + compatible = "fixed-clock";
>>>> + clock-frequency = <38400000>;
>>>> + clock-output-names = "xo_board";
>>>> + #clock-cells = <0>;
>>>> + };
>>>> +
>>>> + sleep_clk: sleep-clk {
>>>> + compatible = "fixed-clock";
>>>> + clock-frequency = <32764>;
>>>> + clock-output-names = "sleep_clk";
>>>> + #clock-cells = <0>;
>>>> + };
>>>> +
>>>> + bi_tcxo: bi_tcxo {
>>>
>>> why is this a clock defined here? Isnt this gcc clock?
>>
>> This is a RPMH-controlled clock and not from GCC. It is the parent clock for
>> GCC RCGs/PLLs.
>
> Yes right!
>
>> Once the RPMH clock support is added these would be removed.
>
> Wont it make sense to keep this bit not upstream and then remove that
> part when you have rpmh support available. Reduces the churn upstream!
>
> The parent can be xo_board till then!
>
The xo_board is 38.4MHz and bi_tcxo (xo/2), which needs to be updated
anyways :).
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.
--
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-10-16 10:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-15 10:33 [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings Rajendra Nayak
2019-10-15 10:33 ` [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
2019-10-16 5:25 ` Vinod Koul
2019-10-16 7:52 ` Taniya Das
2019-10-16 8:24 ` Vinod Koul
2019-10-16 10:43 ` Taniya Das
2019-10-16 8:15 ` Rajendra Nayak
2019-10-16 5:21 ` [PATCH 1/2] dt-bindings: qcom: Add SC7180 bindings Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).