* [PATCH net-next] ionic: Remove set but not used variable 'sg_desc'
@ 2019-10-28 12:01 YueHaibing
2019-10-28 16:30 ` Shannon Nelson
2019-10-29 23:44 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-10-28 12:01 UTC (permalink / raw)
To: Shannon Nelson, Pensando Drivers, David S . Miller
Cc: YueHaibing, netdev, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_empty':
drivers/net/ethernet/pensando/ionic/ionic_txrx.c:405:28: warning:
variable 'sg_desc' set but not used [-Wunused-but-set-variable]
It is never used, so can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
index 0aeac3157160..97e79949b359 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
@@ -402,7 +402,6 @@ static void ionic_rx_fill_cb(void *arg)
void ionic_rx_empty(struct ionic_queue *q)
{
- struct ionic_rxq_sg_desc *sg_desc;
struct ionic_desc_info *cur;
struct ionic_rxq_desc *desc;
unsigned int i;
@@ -412,7 +411,6 @@ void ionic_rx_empty(struct ionic_queue *q)
desc->addr = 0;
desc->len = 0;
- sg_desc = cur->sg_desc;
for (i = 0; i < cur->npages; i++) {
if (likely(cur->pages[i].page)) {
ionic_rx_page_free(q, cur->pages[i].page,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ionic: Remove set but not used variable 'sg_desc'
2019-10-28 12:01 [PATCH net-next] ionic: Remove set but not used variable 'sg_desc' YueHaibing
@ 2019-10-28 16:30 ` Shannon Nelson
2019-10-29 23:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Shannon Nelson @ 2019-10-28 16:30 UTC (permalink / raw)
To: YueHaibing, Pensando Drivers, David S . Miller
Cc: netdev, linux-kernel, kernel-janitors
On 10/28/19 5:01 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_empty':
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c:405:28: warning:
> variable 'sg_desc' set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Shannon Nelson <snelson@pensando.io>
> ---
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> index 0aeac3157160..97e79949b359 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c
> @@ -402,7 +402,6 @@ static void ionic_rx_fill_cb(void *arg)
>
> void ionic_rx_empty(struct ionic_queue *q)
> {
> - struct ionic_rxq_sg_desc *sg_desc;
> struct ionic_desc_info *cur;
> struct ionic_rxq_desc *desc;
> unsigned int i;
> @@ -412,7 +411,6 @@ void ionic_rx_empty(struct ionic_queue *q)
> desc->addr = 0;
> desc->len = 0;
>
> - sg_desc = cur->sg_desc;
> for (i = 0; i < cur->npages; i++) {
> if (likely(cur->pages[i].page)) {
> ionic_rx_page_free(q, cur->pages[i].page,
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ionic: Remove set but not used variable 'sg_desc'
2019-10-28 12:01 [PATCH net-next] ionic: Remove set but not used variable 'sg_desc' YueHaibing
2019-10-28 16:30 ` Shannon Nelson
@ 2019-10-29 23:44 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-10-29 23:44 UTC (permalink / raw)
To: yuehaibing; +Cc: snelson, drivers, netdev, linux-kernel, kernel-janitors
From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 28 Oct 2019 12:01:21 +0000
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c: In function 'ionic_rx_empty':
> drivers/net/ethernet/pensando/ionic/ionic_txrx.c:405:28: warning:
> variable 'sg_desc' set but not used [-Wunused-but-set-variable]
>
> It is never used, so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-29 23:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 12:01 [PATCH net-next] ionic: Remove set but not used variable 'sg_desc' YueHaibing
2019-10-28 16:30 ` Shannon Nelson
2019-10-29 23:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).