[PATCH 0/4] part2: kill pr_warning from kernel

[PATCH 0/4] part2: kill pr_warning from kernel

[Kefeng Wang]

This is the part2 of kill pr_warning, as most pr_warning conversion merged
into v5.5, let's cleanup the last two stragglers. Then, completely drop
pr_warning defination in printk.h and check in checkpatch.pl.

Part1: https://lore.kernel.org/lkml/20190920062544.180997-1-wangkefeng.wang@huawei.com

Kefeng Wang (4):
  workqueue: Use pr_warn instead of pr_warning
  staging: isdn: gigaset: Use pr_warn instead of pr_warning
  printk: Drop pr_warning definition
  checkpatch: Drop pr_warning check

 drivers/staging/isdn/gigaset/interface.c | 2 +-
 include/linux/printk.h                   | 3 +--
 kernel/workqueue.c                       | 4 ++--
 scripts/checkpatch.pl                    | 9 ---------
 4 files changed, 4 insertions(+), 14 deletions(-)

-- 
2.20.1

[PATCH 1/4] workqueue: Use pr_warn instead of pr_warning

[Kefeng Wang]

Use pr_warn() instead of the remaining pr_warning() calls.

Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 kernel/workqueue.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index bc88fd939f4e..cfc923558e04 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4374,8 +4374,8 @@ void destroy_workqueue(struct workqueue_struct *wq)
 	for_each_pwq(pwq, wq) {
 		spin_lock_irq(&pwq->pool->lock);
 		if (WARN_ON(pwq_busy(pwq))) {
-			pr_warning("%s: %s has the following busy pwq\n",
-				   __func__, wq->name);
+			pr_warn("%s: %s has the following busy pwq\n",
+				__func__, wq->name);
 			show_pwq(pwq);
 			spin_unlock_irq(&pwq->pool->lock);
 			mutex_unlock(&wq->mutex);
-- 
2.20.1

[PATCH 2/4] staging: isdn: gigaset: Use pr_warn instead of pr_warning

[Kefeng Wang]

Use pr_warn() instead of the remaining pr_warning() calls.

Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/staging/isdn/gigaset/interface.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/isdn/gigaset/interface.c b/drivers/staging/isdn/gigaset/interface.c
index 17fa615a8c68..9ddadd07e707 100644
--- a/drivers/staging/isdn/gigaset/interface.c
+++ b/drivers/staging/isdn/gigaset/interface.c
@@ -518,7 +518,7 @@ void gigaset_if_init(struct cardstate *cs)
 	if (!IS_ERR(cs->tty_dev))
 		dev_set_drvdata(cs->tty_dev, cs);
 	else {
-		pr_warning("could not register device to the tty subsystem\n");
+		pr_warn("could not register device to the tty subsystem\n");
 		cs->tty_dev = NULL;
 	}
 	mutex_unlock(&cs->mutex);
-- 
2.20.1

[PATCH 3/4] printk: Drop pr_warning definition

[Kefeng Wang]

With all pr_warning are removed, saftely drop pr_warning definition.

Cc: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 include/linux/printk.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/printk.h b/include/linux/printk.h
index c09d67edda3a..1e6108b8d15f 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -302,9 +302,8 @@ extern int kptr_restrict;
 	printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__)
 #define pr_err(fmt, ...) \
 	printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
-#define pr_warning(fmt, ...) \
+#define pr_warn(fmt, ...) \
 	printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
-#define pr_warn pr_warning
 #define pr_notice(fmt, ...) \
 	printk(KERN_NOTICE pr_fmt(fmt), ##__VA_ARGS__)
 #define pr_info(fmt, ...) \
-- 
2.20.1

[PATCH 4/4] checkpatch: Drop pr_warning check

[Kefeng Wang]

All pr_warning are removed from kernel, let's cleanup pr_warning
check in checkpatch.

Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 scripts/checkpatch.pl | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 64890be3c8fd..447c0050eec0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4113,15 +4113,6 @@ sub process {
 			     "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...\n" . $herecurr);
 		}
 
-		if ($line =~ /\bpr_warning\s*\(/) {
-			if (WARN("PREFER_PR_LEVEL",
-				 "Prefer pr_warn(... to pr_warning(...\n" . $herecurr) &&
-			    $fix) {
-				$fixed[$fixlinenr] =~
-				    s/\bpr_warning\b/pr_warn/;
-			}
-		}
-
 		if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
 			my $orig = $1;
 			my $level = lc($orig);
-- 
2.20.1

Re: [PATCH 4/4] checkpatch: Drop pr_warning check

[Joe Perches]

On Thu, 2019-11-28 at 08:47 +0800, Kefeng Wang wrote:
> All pr_warning are removed from kernel, let's cleanup pr_warning
> check in checkpatch.
> 
> Cc: Andy Whitcroft <apw@canonical.com>
> Cc: Joe Perches <joe@perches.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Assuming the other bits go in:

Acked-by: Joe Perches <joe@perches.com>

> ---
>  scripts/checkpatch.pl | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 64890be3c8fd..447c0050eec0 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4113,15 +4113,6 @@ sub process {
>  			     "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...\n" . $herecurr);
>  		}
>  
> -		if ($line =~ /\bpr_warning\s*\(/) {
> -			if (WARN("PREFER_PR_LEVEL",
> -				 "Prefer pr_warn(... to pr_warning(...\n" . $herecurr) &&
> -			    $fix) {
> -				$fixed[$fixlinenr] =~
> -				    s/\bpr_warning\b/pr_warn/;
> -			}
> -		}
> -
>  		if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
>  			my $orig = $1;
>  			my $level = lc($orig);

Re: [PATCH 3/4] printk: Drop pr_warning definition

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 8873 bytes --]

Hi Kefeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wq/for-next]
[cannot apply to pmladek/for-next v5.4 next-20191127]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Kefeng-Wang/part2-kill-pr_warning-from-kernel/20191128-085343
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/platform/x86/eeepc-laptop.c: In function 'eeepc_rfkill_hotplug':
>> drivers/platform/x86/eeepc-laptop.c:581:3: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
      pr_warning("Unable to find port\n");
      ^~~~~~~~~~
      acpi_warning
   cc1: some warnings being treated as errors
--
   drivers/video/console/vgacon.c: In function 'text_mode':
>> drivers/video/console/vgacon.c:116:2: error: implicit declaration of function 'pr_warning'; did you mean 'pr_warn'? [-Werror=implicit-function-declaration]
     pr_warning("You have booted with nomodeset. This means your GPU drivers are DISABLED\n");
     ^~~~~~~~~~
     pr_warn
   cc1: some warnings being treated as errors
--
   arch/x86//kernel/tsc_sync.c: In function 'check_tsc_sync_source':
>> arch/x86//kernel/tsc_sync.c:367:3: error: implicit declaration of function 'pr_warning'; did you mean 'pr_warn'? [-Werror=implicit-function-declaration]
      pr_warning("TSC synchronization [CPU#%d -> CPU#%d]:\n",
      ^~~~~~~~~~
      pr_warn
   cc1: some warnings being treated as errors
--
   arch/x86//kernel/setup_percpu.c: In function 'setup_per_cpu_areas':
>> arch/x86//kernel/setup_percpu.c:210:4: error: implicit declaration of function 'pr_warning'; did you mean 'pr_warn'? [-Werror=implicit-function-declaration]
       pr_warning("%s allocator failed (%d), falling back to page size\n",
       ^~~~~~~~~~
       pr_warn
   cc1: some warnings being treated as errors
--
   arch/x86//kernel/apic/apic.c: In function 'calibrate_by_pmtimer':
>> arch/x86//kernel/apic/apic.c:783:2: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
     pr_warning("APIC calibration not consistent "
     ^~~~~~~~~~
     acpi_warning
   cc1: some warnings being treated as errors
--
   drivers//acpi/resource.c: In function 'acpi_dev_get_irqresource':
>> drivers//acpi/resource.c:416:4: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
       pr_warning("ACPI: IRQ %d override to %s, %s\n", gsi,
       ^~~~~~~~~~
       acpi_warning
   cc1: some warnings being treated as errors

vim +581 drivers/platform/x86/eeepc-laptop.c

2b121bc262fa03 Corentin Chary    2009-06-25  560  
14fdb152416c0f Matthew Garrett   2011-05-09  561  static void eeepc_rfkill_hotplug(struct eeepc_laptop *eeepc, acpi_handle handle)
5740294ca3a9b1 Matthew Garrett   2009-01-20  562  {
14fdb152416c0f Matthew Garrett   2011-05-09  563  	struct pci_dev *port;
5740294ca3a9b1 Matthew Garrett   2009-01-20  564  	struct pci_dev *dev;
6d41839e762f8b Alan Jenkins      2009-08-28  565  	struct pci_bus *bus;
854c78363f37f0 Alan Jenkins      2009-12-03  566  	bool blocked = eeepc_wlan_rfkill_blocked(eeepc);
bc9d24a3aeb153 Alan Jenkins      2010-02-22  567  	bool absent;
bc9d24a3aeb153 Alan Jenkins      2010-02-22  568  	u32 l;
5740294ca3a9b1 Matthew Garrett   2009-01-20  569  
a7624b63fdf50d Alan Jenkins      2009-12-03  570  	if (eeepc->wlan_rfkill)
a7624b63fdf50d Alan Jenkins      2009-12-03  571  		rfkill_set_sw_state(eeepc->wlan_rfkill, blocked);
6d41839e762f8b Alan Jenkins      2009-08-28  572  
a7624b63fdf50d Alan Jenkins      2009-12-03  573  	mutex_lock(&eeepc->hotplug_lock);
8b9ec1da6a310b Rafael J. Wysocki 2014-01-10  574  	pci_lock_rescan_remove();
dcf443b5813074 Alan Jenkins      2009-08-28  575  
125450f814418b Lukas Wunner      2018-09-08  576  	if (!eeepc->hotplug_slot.ops)
248d4903639068 Frans Klaver      2014-10-22  577  		goto out_unlock;
248d4903639068 Frans Klaver      2014-10-22  578  
14fdb152416c0f Matthew Garrett   2011-05-09  579  	port = acpi_get_pci_dev(handle);
14fdb152416c0f Matthew Garrett   2011-05-09  580  	if (!port) {
14fdb152416c0f Matthew Garrett   2011-05-09 @581  		pr_warning("Unable to find port\n");
14fdb152416c0f Matthew Garrett   2011-05-09  582  		goto out_unlock;
14fdb152416c0f Matthew Garrett   2011-05-09  583  	}
14fdb152416c0f Matthew Garrett   2011-05-09  584  
14fdb152416c0f Matthew Garrett   2011-05-09  585  	bus = port->subordinate;
14fdb152416c0f Matthew Garrett   2011-05-09  586  
5740294ca3a9b1 Matthew Garrett   2009-01-20  587  	if (!bus) {
22441ffeed17b9 Joe Perches       2011-03-29  588  		pr_warn("Unable to find PCI bus 1?\n");
f661848b74b330 Jiang Liu         2012-09-14  589  		goto out_put_dev;
5740294ca3a9b1 Matthew Garrett   2009-01-20  590  	}
5740294ca3a9b1 Matthew Garrett   2009-01-20  591  
bc9d24a3aeb153 Alan Jenkins      2010-02-22  592  	if (pci_bus_read_config_dword(bus, 0, PCI_VENDOR_ID, &l)) {
bc9d24a3aeb153 Alan Jenkins      2010-02-22  593  		pr_err("Unable to read PCI config space?\n");
f661848b74b330 Jiang Liu         2012-09-14  594  		goto out_put_dev;
bc9d24a3aeb153 Alan Jenkins      2010-02-22  595  	}
14fdb152416c0f Matthew Garrett   2011-05-09  596  
bc9d24a3aeb153 Alan Jenkins      2010-02-22  597  	absent = (l == 0xffffffff);
bc9d24a3aeb153 Alan Jenkins      2010-02-22  598  
bc9d24a3aeb153 Alan Jenkins      2010-02-22  599  	if (blocked != absent) {
9f662b20d6cef8 Frans Klaver      2014-10-22  600  		pr_warn("BIOS says wireless lan is %s, but the pci device is %s\n",
bc9d24a3aeb153 Alan Jenkins      2010-02-22  601  			blocked ? "blocked" : "unblocked",
bc9d24a3aeb153 Alan Jenkins      2010-02-22  602  			absent ? "absent" : "present");
9f662b20d6cef8 Frans Klaver      2014-10-22  603  		pr_warn("skipped wireless hotplug as probably inappropriate for this model\n");
f661848b74b330 Jiang Liu         2012-09-14  604  		goto out_put_dev;
bc9d24a3aeb153 Alan Jenkins      2010-02-22  605  	}
bc9d24a3aeb153 Alan Jenkins      2010-02-22  606  
19d337dff95cbf Johannes Berg     2009-06-02  607  	if (!blocked) {
5740294ca3a9b1 Matthew Garrett   2009-01-20  608  		dev = pci_get_slot(bus, 0);
5740294ca3a9b1 Matthew Garrett   2009-01-20  609  		if (dev) {
5740294ca3a9b1 Matthew Garrett   2009-01-20  610  			/* Device already present */
5740294ca3a9b1 Matthew Garrett   2009-01-20  611  			pci_dev_put(dev);
f661848b74b330 Jiang Liu         2012-09-14  612  			goto out_put_dev;
5740294ca3a9b1 Matthew Garrett   2009-01-20  613  		}
5740294ca3a9b1 Matthew Garrett   2009-01-20  614  		dev = pci_scan_single_device(bus, 0);
5740294ca3a9b1 Matthew Garrett   2009-01-20  615  		if (dev) {
5740294ca3a9b1 Matthew Garrett   2009-01-20  616  			pci_bus_assign_resources(bus);
c893d133eaccdd Yijing Wang       2014-05-30  617  			pci_bus_add_device(dev);
5740294ca3a9b1 Matthew Garrett   2009-01-20  618  		}
5740294ca3a9b1 Matthew Garrett   2009-01-20  619  	} else {
5740294ca3a9b1 Matthew Garrett   2009-01-20  620  		dev = pci_get_slot(bus, 0);
5740294ca3a9b1 Matthew Garrett   2009-01-20  621  		if (dev) {
210647af897af8 Yinghai Lu        2012-02-25  622  			pci_stop_and_remove_bus_device(dev);
5740294ca3a9b1 Matthew Garrett   2009-01-20  623  			pci_dev_put(dev);
5740294ca3a9b1 Matthew Garrett   2009-01-20  624  		}
5740294ca3a9b1 Matthew Garrett   2009-01-20  625  	}
f661848b74b330 Jiang Liu         2012-09-14  626  out_put_dev:
f661848b74b330 Jiang Liu         2012-09-14  627  	pci_dev_put(port);
dcf443b5813074 Alan Jenkins      2009-08-28  628  
dcf443b5813074 Alan Jenkins      2009-08-28  629  out_unlock:
8b9ec1da6a310b Rafael J. Wysocki 2014-01-10  630  	pci_unlock_rescan_remove();
a7624b63fdf50d Alan Jenkins      2009-12-03  631  	mutex_unlock(&eeepc->hotplug_lock);
5740294ca3a9b1 Matthew Garrett   2009-01-20  632  }
5740294ca3a9b1 Matthew Garrett   2009-01-20  633  

:::::: The code at line 581 was first introduced by commit
:::::: 14fdb152416c0fab80ecddf492c129d7da1bb8ef eeepc-laptop: Use ACPI handle to identify rfkill port

:::::: TO: Matthew Garrett <mjg@redhat.com>
:::::: CC: Matthew Garrett <mjg@redhat.com>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28088 bytes --]

Re: [PATCH 2/4] staging: isdn: gigaset: Use pr_warn instead of pr_warning

[Petr Mladek]

On Thu 2019-11-28 08:47:50, Kefeng Wang wrote:
> Use pr_warn() instead of the remaining pr_warning() calls.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/staging/isdn/gigaset/interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/isdn/gigaset/interface.c b/drivers/staging/isdn/gigaset/interface.c
> index 17fa615a8c68..9ddadd07e707 100644
> --- a/drivers/staging/isdn/gigaset/interface.c
> +++ b/drivers/staging/isdn/gigaset/interface.c
> @@ -518,7 +518,7 @@ void gigaset_if_init(struct cardstate *cs)
>  	if (!IS_ERR(cs->tty_dev))
>  		dev_set_drvdata(cs->tty_dev, cs);
>  	else {
> -		pr_warning("could not register device to the tty subsystem\n");
> +		pr_warn("could not register device to the tty subsystem\n");

This patch has reached mainline via the staging tree in the meantime.

Best Regards,
Petr

Re: [PATCH 3/4] printk: Drop pr_warning definition

[Petr Mladek]

On Thu 2019-11-28 15:14:36, kbuild test robot wrote:
> Hi Kefeng,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on wq/for-next]
> [cannot apply to pmladek/for-next v5.4 next-20191127]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/Kefeng-Wang/part2-kill-pr_warning-from-kernel/20191128-085343
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next
> config: i386-defconfig (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/platform/x86/eeepc-laptop.c: In function 'eeepc_rfkill_hotplug':
> >> drivers/platform/x86/eeepc-laptop.c:581:3: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
>       pr_warning("Unable to find port\n");
>       ^~~~~~~~~~
>       acpi_warning
>    cc1: some warnings being treated as errors

[...]

These are false positives. These pr_warning() calls have already been
removed in mainline via a pull request from printk.git.

Best Regards.
Petr


tj/wq.git for-next branch is outdated.
This branch is outdated. The 

Re: [PATCH 0/4] part2: kill pr_warning from kernel

[Petr Mladek]

On Thu 2019-11-28 08:47:48, Kefeng Wang wrote:
> This is the part2 of kill pr_warning, as most pr_warning conversion merged
> into v5.5, let's cleanup the last two stragglers. Then, completely drop
> pr_warning defination in printk.h and check in checkpatch.pl.
> 
> Part1: https://lore.kernel.org/lkml/20190920062544.180997-1-wangkefeng.wang@huawei.com
> 
> Kefeng Wang (4):
>   workqueue: Use pr_warn instead of pr_warning
>   staging: isdn: gigaset: Use pr_warn instead of pr_warning

This one is already in mainline via staging tree.

>   printk: Drop pr_warning definition
>   checkpatch: Drop pr_warning check

The other patches are committed in printk.git, branch
for-5.5-pr-warning-removal.

I am going to sent pull request after 5.5-rc1 is tagged.
It is should be fine according to linux-next. But I am not
sure if all coming changes are really tested in linux-next.

Best Regards,
Petr

Re: [PATCH 0/4] part2: kill pr_warning from kernel

[Kefeng Wang]

On 2019/11/29 19:58, Petr Mladek wrote:
> On Thu 2019-11-28 08:47:48, Kefeng Wang wrote:
>> This is the part2 of kill pr_warning, as most pr_warning conversion merged
>> into v5.5, let's cleanup the last two stragglers. Then, completely drop
>> pr_warning defination in printk.h and check in checkpatch.pl.
>>
>> Part1: https://lore.kernel.org/lkml/20190920062544.180997-1-wangkefeng.wang@huawei.com
>>
>> Kefeng Wang (4):
>>   workqueue: Use pr_warn instead of pr_warning
>>   staging: isdn: gigaset: Use pr_warn instead of pr_warning
> 
> This one is already in mainline via staging tree.
> 
>>   printk: Drop pr_warning definition
>>   checkpatch: Drop pr_warning check
> 
> The other patches are committed in printk.git, branch
> for-5.5-pr-warning-removal.
> 
> I am going to sent pull request after 5.5-rc1 is tagged.
> It is should be fine according to linux-next. But I am not
> sure if all coming changes are really tested in linux-next.
> 
Hi Petr, thanks, the issue will always be there, so let's remove
the definition ASAP, and we can fix the follow-up possible use :)


> Best Regards,
> Petr
> 
> .
> 

Re: [kbuild-all] Re: [PATCH 3/4] printk: Drop pr_warning definition

[Philip Li]

On Fri, Nov 29, 2019 at 12:53:47PM +0100, Petr Mladek wrote:
> On Thu 2019-11-28 15:14:36, kbuild test robot wrote:
> > Hi Kefeng,
> > 
> > Thank you for the patch! Yet something to improve:
> > 
> > [auto build test ERROR on wq/for-next]
> > [cannot apply to pmladek/for-next v5.4 next-20191127]
> > [if your patch is applied to the wrong git tree, please drop us a note to help
> > improve the system. BTW, we also suggest to use '--base' option to specify the
> > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Kefeng-Wang/part2-kill-pr_warning-from-kernel/20191128-085343
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next
> > config: i386-defconfig (attached as .config)
> > compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
> > reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386 
> > 
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    drivers/platform/x86/eeepc-laptop.c: In function 'eeepc_rfkill_hotplug':
> > >> drivers/platform/x86/eeepc-laptop.c:581:3: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
> >       pr_warning("Unable to find port\n");
> >       ^~~~~~~~~~
> >       acpi_warning
> >    cc1: some warnings being treated as errors
> 
> [...]
> 
> These are false positives. These pr_warning() calls have already been
> removed in mainline via a pull request from printk.git.
thanks, we will check this to improve.

> 
> Best Regards.
> Petr
> 
> 
> tj/wq.git for-next branch is outdated.
> This branch is outdated. The 
Thanks for the info Petr, we will look into this to resolve the out of
dated base. In this case, do you have any recommended base to use?

> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org

Re: [PATCH 1/4] workqueue: Use pr_warn instead of pr_warning

[Tejun Heo]

On Thu, Nov 28, 2019 at 08:47:49AM +0800, Kefeng Wang wrote:
> Use pr_warn() instead of the remaining pr_warning() calls.
> 
> Cc: Tejun Heo <tj@kernel.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Acked-by: Tejun Heo <tj@kernel.org>

Please feel free to route however you see fit.

Thanks.

-- 
tejun

Re: [kbuild-all] Re: [PATCH 3/4] printk: Drop pr_warning definition

[Petr Mladek]

On Sat 2019-11-30 17:03:16, Philip Li wrote:
> On Fri, Nov 29, 2019 at 12:53:47PM +0100, Petr Mladek wrote:
> > On Thu 2019-11-28 15:14:36, kbuild test robot wrote:
> > > Hi Kefeng,
> > > 
> > > Thank you for the patch! Yet something to improve:
> > > 
> > > [auto build test ERROR on wq/for-next]
> > > [cannot apply to pmladek/for-next v5.4 next-20191127]
> > > [if your patch is applied to the wrong git tree, please drop us a note to help
> > > improve the system. BTW, we also suggest to use '--base' option to specify the
> > > base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> > > 
> > > url:    https://github.com/0day-ci/linux/commits/Kefeng-Wang/part2-kill-pr_warning-from-kernel/20191128-085343
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-next
> > > config: i386-defconfig (attached as .config)
> > > compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
> > > reproduce:
> > >         # save the attached .config to linux build tree
> > >         make ARCH=i386 
> > > 
> > > If you fix the issue, kindly add following tag
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > >    drivers/platform/x86/eeepc-laptop.c: In function 'eeepc_rfkill_hotplug':
> > > >> drivers/platform/x86/eeepc-laptop.c:581:3: error: implicit declaration of function 'pr_warning'; did you mean 'acpi_warning'? [-Werror=implicit-function-declaration]
> > >       pr_warning("Unable to find port\n");
> > >       ^~~~~~~~~~
> > >       acpi_warning
> > >    cc1: some warnings being treated as errors
> > 
> > [...]
> > 
> > These are false positives. These pr_warning() calls have already been
> > removed in mainline via a pull request from printk.git.
> thanks, we will check this to improve.
> 
> > 
> > Best Regards.
> > Petr
> > 
> > 
> > tj/wq.git for-next branch is outdated.
> > This branch is outdated. The 
> Thanks for the info Petr, we will look into this to resolve the out of
> dated base. In this case, do you have any recommended base to use?

Good question. These kind of problems should be solved in linux-next
git tree.

Well, I am not sure how often you see these false positives. I think
that they happen only where there is some global change that affects
many subsystems and is done in more stages.

In this case, we removed most pr_warning() users in one patchset. Then
we removed the remaining (new) users and the function definition
in another patchset. It might be a corner case that does not need
any changes on your side.

Best Regards,
Petr
most