* [PATCH 0/4] interconnect fixes for 5.5
@ 2019-12-12 7:53 Georgi Djakov
2019-12-12 7:53 ` [PATCH 1/4] interconnect: qcom: Fix Kconfig indentation Georgi Djakov
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Georgi Djakov @ 2019-12-12 7:53 UTC (permalink / raw)
To: gregkh; +Cc: linux-pm, linux-kernel, Georgi Djakov
Hi Greg,
Here are some fixes for 5.5-rc. This includes fixing a linked list
corruption in some drivers and a Kconfig indentation fix. Two of
the patches are tagged for stable. Please apply to char-misc when
possible.
Thanks,
Georgi
Georgi Djakov (3):
interconnect: qcom: sdm845: Walk the list safely on node removal
interconnect: qcom: qcs404: Walk the list safely on node removal
interconnect: qcom: msm8974: Walk the list safely on node removal
Krzysztof Kozlowski (1):
interconnect: qcom: Fix Kconfig indentation
drivers/interconnect/qcom/Kconfig | 14 +++++++-------
drivers/interconnect/qcom/msm8974.c | 8 ++++----
drivers/interconnect/qcom/qcs404.c | 8 ++++----
drivers/interconnect/qcom/sdm845.c | 4 ++--
4 files changed, 17 insertions(+), 17 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/4] interconnect: qcom: Fix Kconfig indentation
2019-12-12 7:53 [PATCH 0/4] interconnect fixes for 5.5 Georgi Djakov
@ 2019-12-12 7:53 ` Georgi Djakov
2019-12-12 7:53 ` [PATCH 2/4] interconnect: qcom: sdm845: Walk the list safely on node removal Georgi Djakov
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Georgi Djakov @ 2019-12-12 7:53 UTC (permalink / raw)
To: gregkh; +Cc: linux-pm, linux-kernel, Krzysztof Kozlowski, Georgi Djakov
From: Krzysztof Kozlowski <krzk@kernel.org>
Adjust indentation from spaces to tab (+optional two spaces) as in
coding style with command like:
$ sed -e 's/^ /\t/' -i */Kconfig
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
drivers/interconnect/qcom/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
index c49afbea3458..2f9304d1db49 100644
--- a/drivers/interconnect/qcom/Kconfig
+++ b/drivers/interconnect/qcom/Kconfig
@@ -6,13 +6,13 @@ config INTERCONNECT_QCOM
Support for Qualcomm's Network-on-Chip interconnect hardware.
config INTERCONNECT_QCOM_MSM8974
- tristate "Qualcomm MSM8974 interconnect driver"
- depends on INTERCONNECT_QCOM
- depends on QCOM_SMD_RPM
- select INTERCONNECT_QCOM_SMD_RPM
- help
- This is a driver for the Qualcomm Network-on-Chip on msm8974-based
- platforms.
+ tristate "Qualcomm MSM8974 interconnect driver"
+ depends on INTERCONNECT_QCOM
+ depends on QCOM_SMD_RPM
+ select INTERCONNECT_QCOM_SMD_RPM
+ help
+ This is a driver for the Qualcomm Network-on-Chip on msm8974-based
+ platforms.
config INTERCONNECT_QCOM_QCS404
tristate "Qualcomm QCS404 interconnect driver"
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/4] interconnect: qcom: sdm845: Walk the list safely on node removal
2019-12-12 7:53 [PATCH 0/4] interconnect fixes for 5.5 Georgi Djakov
2019-12-12 7:53 ` [PATCH 1/4] interconnect: qcom: Fix Kconfig indentation Georgi Djakov
@ 2019-12-12 7:53 ` Georgi Djakov
2019-12-12 7:53 ` [PATCH 3/4] interconnect: qcom: qcs404: " Georgi Djakov
2019-12-12 7:53 ` [PATCH 4/4] interconnect: qcom: msm8974: " Georgi Djakov
3 siblings, 0 replies; 5+ messages in thread
From: Georgi Djakov @ 2019-12-12 7:53 UTC (permalink / raw)
To: gregkh
Cc: linux-pm, linux-kernel, Georgi Djakov, Dmitry Osipenko,
Bjorn Andersson, stable
As we will remove items off the list using list_del(), we need to use the
safe version of list_for_each_entry().
Fixes: b5d2f741077a ("interconnect: qcom: Add sdm845 interconnect provider driver")
Reported-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Cc: <stable@vger.kernel.org> # v5.3+
---
drivers/interconnect/qcom/sdm845.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
index 502a6c22b41e..387267ee9648 100644
--- a/drivers/interconnect/qcom/sdm845.c
+++ b/drivers/interconnect/qcom/sdm845.c
@@ -868,9 +868,9 @@ static int qnoc_remove(struct platform_device *pdev)
{
struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
struct icc_provider *provider = &qp->provider;
- struct icc_node *n;
+ struct icc_node *n, *tmp;
- list_for_each_entry(n, &provider->nodes, node_list) {
+ list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
icc_node_del(n);
icc_node_destroy(n->id);
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/4] interconnect: qcom: qcs404: Walk the list safely on node removal
2019-12-12 7:53 [PATCH 0/4] interconnect fixes for 5.5 Georgi Djakov
2019-12-12 7:53 ` [PATCH 1/4] interconnect: qcom: Fix Kconfig indentation Georgi Djakov
2019-12-12 7:53 ` [PATCH 2/4] interconnect: qcom: sdm845: Walk the list safely on node removal Georgi Djakov
@ 2019-12-12 7:53 ` Georgi Djakov
2019-12-12 7:53 ` [PATCH 4/4] interconnect: qcom: msm8974: " Georgi Djakov
3 siblings, 0 replies; 5+ messages in thread
From: Georgi Djakov @ 2019-12-12 7:53 UTC (permalink / raw)
To: gregkh
Cc: linux-pm, linux-kernel, Georgi Djakov, Dmitry Osipenko,
Bjorn Andersson, stable
As we will remove items off the list using list_del(), we need to use the
safe version of list_for_each_entry().
Fixes: 5e4e6c4d3ae0 ("interconnect: qcom: Add QCS404 interconnect provider driver")
Reported-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Cc: <stable@vger.kernel.org> # v5.4
---
drivers/interconnect/qcom/qcs404.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/interconnect/qcom/qcs404.c b/drivers/interconnect/qcom/qcs404.c
index b4966d8f3348..8e0735a87040 100644
--- a/drivers/interconnect/qcom/qcs404.c
+++ b/drivers/interconnect/qcom/qcs404.c
@@ -414,7 +414,7 @@ static int qnoc_probe(struct platform_device *pdev)
struct icc_provider *provider;
struct qcom_icc_node **qnodes;
struct qcom_icc_provider *qp;
- struct icc_node *node;
+ struct icc_node *node, *tmp;
size_t num_nodes, i;
int ret;
@@ -494,7 +494,7 @@ static int qnoc_probe(struct platform_device *pdev)
return 0;
err:
- list_for_each_entry(node, &provider->nodes, node_list) {
+ list_for_each_entry_safe(node, tmp, &provider->nodes, node_list) {
icc_node_del(node);
icc_node_destroy(node->id);
}
@@ -508,9 +508,9 @@ static int qnoc_remove(struct platform_device *pdev)
{
struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
struct icc_provider *provider = &qp->provider;
- struct icc_node *n;
+ struct icc_node *n, *tmp;
- list_for_each_entry(n, &provider->nodes, node_list) {
+ list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
icc_node_del(n);
icc_node_destroy(n->id);
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 4/4] interconnect: qcom: msm8974: Walk the list safely on node removal
2019-12-12 7:53 [PATCH 0/4] interconnect fixes for 5.5 Georgi Djakov
` (2 preceding siblings ...)
2019-12-12 7:53 ` [PATCH 3/4] interconnect: qcom: qcs404: " Georgi Djakov
@ 2019-12-12 7:53 ` Georgi Djakov
3 siblings, 0 replies; 5+ messages in thread
From: Georgi Djakov @ 2019-12-12 7:53 UTC (permalink / raw)
To: gregkh
Cc: linux-pm, linux-kernel, Georgi Djakov, Dmitry Osipenko, Bjorn Andersson
As we will remove items off the list using list_del(), we need to use the
safe version of list_for_each_entry().
Fixes: 4e60a9568dc6 ("interconnect: qcom: add msm8974 driver")
Reported-by: Dmitry Osipenko <digetx@gmail.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
drivers/interconnect/qcom/msm8974.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/interconnect/qcom/msm8974.c b/drivers/interconnect/qcom/msm8974.c
index ce599a0c83d9..bf8bd1aee358 100644
--- a/drivers/interconnect/qcom/msm8974.c
+++ b/drivers/interconnect/qcom/msm8974.c
@@ -652,7 +652,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct icc_onecell_data *data;
struct icc_provider *provider;
- struct icc_node *node;
+ struct icc_node *node, *tmp;
size_t num_nodes, i;
int ret;
@@ -732,7 +732,7 @@ static int msm8974_icc_probe(struct platform_device *pdev)
return 0;
err_del_icc:
- list_for_each_entry(node, &provider->nodes, node_list) {
+ list_for_each_entry_safe(node, tmp, &provider->nodes, node_list) {
icc_node_del(node);
icc_node_destroy(node->id);
}
@@ -748,9 +748,9 @@ static int msm8974_icc_remove(struct platform_device *pdev)
{
struct msm8974_icc_provider *qp = platform_get_drvdata(pdev);
struct icc_provider *provider = &qp->provider;
- struct icc_node *n;
+ struct icc_node *n, *tmp;
- list_for_each_entry(n, &provider->nodes, node_list) {
+ list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
icc_node_del(n);
icc_node_destroy(n->id);
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-12 7:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 7:53 [PATCH 0/4] interconnect fixes for 5.5 Georgi Djakov
2019-12-12 7:53 ` [PATCH 1/4] interconnect: qcom: Fix Kconfig indentation Georgi Djakov
2019-12-12 7:53 ` [PATCH 2/4] interconnect: qcom: sdm845: Walk the list safely on node removal Georgi Djakov
2019-12-12 7:53 ` [PATCH 3/4] interconnect: qcom: qcs404: " Georgi Djakov
2019-12-12 7:53 ` [PATCH 4/4] interconnect: qcom: msm8974: " Georgi Djakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).