linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Simon Horman <horms@verge.net.au>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	"open list:DRM DRIVERS FOR RENESAS"
	<dri-devel@lists.freedesktop.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: rcar-du: Add r8a77980 support
Date: Wed, 18 Dec 2019 01:11:38 +0200	[thread overview]
Message-ID: <20191217231138.GF4874@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAMuHMdWuGxy8WH9ts7iKPsRW0fUjQ3c7jdDOb9KpViwcvXC14A@mail.gmail.com>

On Mon, Dec 16, 2019 at 11:37:00AM +0100, Geert Uytterhoeven wrote:
> On Mon, Dec 16, 2019 at 10:47 AM Kieran Bingham wrote:
> > On 13/12/2019 00:48, Laurent Pinchart wrote:
> >> On Mon, Dec 09, 2019 at 12:41:07PM +0000, Kieran Bingham wrote:
> >>> On 13/09/2019 10:03, Laurent Pinchart wrote:
> >>>> On Fri, Sep 13, 2019 at 10:21:29AM +0200, Simon Horman wrote:
> >>>>> On Thu, Sep 12, 2019 at 01:00:41PM +0300, Sergei Shtylyov wrote:
> >>>>>> On 11.09.2019 22:25, Kieran Bingham wrote:
> >>>>>>
> >>>>>>> Add direct support for the r8a77980 (V3H).
> >>>>>>>
> >>>>>>> The V3H shares a common, compatible configuration with the r8a77970
> >>>>>>> (V3M) so that device info structure is reused.
> >>>>>>
> >>>>>>    Do we really need to add yet another compatible in this case?
> >>>>>> I just added r8a77970 to the compatible prop in the r8a77980 DT. That's why
> >>>>>> a patch like this one didn't get posted by me.
> >>>>>
> >>>>> The reason for having per-SoC compat strings is that the IP blocks
> >>>>> are not versioned and while we can observe that there are similarities
> >>>>> between, f.e. the DU on the r8a77970 and r8a77980, we can't be certain that
> >>>>> differences may not emerge at some point. By having per-SoC compat strings
> >>>>> we have the flexibility for the driver to address any such differences as
> >>>>> the need arises.
> >>>>>
> >>>>> My recollection is that this scheme has been adopted for non-versioned
> >>>>> Renesas IP blocks since June 2015 and uses of this scheme well before that.
> >>>>
> >>>> Sure, but we could use
> >>>>
> >>>>     compatible = "renesas,du-r8a77980", "renesas,du-r8a77970";
> >
> > We already do in arch/arm64/boot/dts/renesas/r8a77980.dtsi.
> >
> > However that is the *only* non r8a77980 reference in the file so it,
> > itself looks *very* much out of place.
> >
> >
> > Furthermore, the main purpose of this patch is that we clearly document
> > the driver as supporting the r8a77980 in the bindings (No mention that
> > you must use the ..970 binding), yet in actual fact - the driver could
> > not currently support loading a device with the following compatible:
> >
> >         compatible = "renesas,du-r8a77980";
> >
> >
> >>>> in DT without updating the driver. If the r8a77980 turns out to be
> >>>> different, we'll then update the driver without a need to modify DT. I'm
> >>>> fine either way, so
> >>>>
> >>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >>>
> >>> Thanks,
> >>>
> >>> This patch has an RB tag from you, and Simon, but alas I don't believe
> >>> it has been picked up in your drm/du/next branch.
> >>>
> >>> Is this patch acceptable? Or do I need to repost?
> >>
> >> Could you just confirm I should apply this patch, and not go for the
> >> alternative proposal above ?
> >
> > I believe the alternative proposal above is what we have today isn't it?
> >
> >
> > Yes, I do believe we should apply this patch.
> 
> +1.
> 
> I'm waiting for the driver part to go upstream, so I can apply the DTS patch.
> Note that this will lead to a messy situation in LTS, as the DTS patch will
> likely be backported, so the driver part must be backported, too.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and taken in my tree.

> > I'm going to assume you haven't read the other arguments on this thread
> > so I'll paste them here:
> 
> Thanks for recollecting! ;-)

-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2019-12-17 23:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 19:25 Kieran Bingham
2019-09-12 10:00 ` Sergei Shtylyov
2019-09-12 10:26   ` Kieran Bingham
2019-09-12 10:45     ` Kieran Bingham
2019-09-12 12:03     ` Geert Uytterhoeven
2019-09-12 12:11       ` Kieran Bingham
2019-09-13  8:21   ` Simon Horman
2019-09-13  8:30     ` Geert Uytterhoeven
2019-09-13  8:57       ` Simon Horman
2019-09-13  9:03     ` Laurent Pinchart
2019-12-09 12:41       ` Kieran Bingham
2019-12-13  0:48         ` Laurent Pinchart
2019-12-16  9:47           ` Kieran Bingham
2019-12-16 10:37             ` Geert Uytterhoeven
2019-12-17 23:11               ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217231138.GF4874@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --subject='Re: [PATCH] drm: rcar-du: Add r8a77980 support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).