* [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()
@ 2019-12-19 0:58 Kees Cook
2019-12-19 16:18 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2019-12-19 0:58 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-kernel, linux-wireless, ath11k
The FIELD_SIZEOF() macro was redundant, and is being removed from the
kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
this is one of the last users of the old macro, so replace it.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
resend: https://lore.kernel.org/lkml/87d0cl8q46.fsf@kamboji.qca.qualcomm.com
---
drivers/net/wireless/ath/ath11k/wmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
index 4a518d406bc5..fd7cb07a9940 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.h
+++ b/drivers/net/wireless/ath/ath11k/wmi.h
@@ -44,7 +44,7 @@ struct wmi_tlv {
#define WMI_TLV_LEN GENMASK(15, 0)
#define WMI_TLV_TAG GENMASK(31, 16)
-#define TLV_HDR_SIZE FIELD_SIZEOF(struct wmi_tlv, header)
+#define TLV_HDR_SIZE sizeof_field(struct wmi_tlv, header)
#define WMI_CMD_HDR_CMD_ID GENMASK(23, 0)
#define WMI_MAX_MEM_REQS 32
--
2.17.1
--
Kees Cook
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()
2019-12-19 0:58 [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF() Kees Cook
@ 2019-12-19 16:18 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2019-12-19 16:18 UTC (permalink / raw)
To: Kees Cook; +Cc: linux-kernel, linux-wireless, ath11k
Kees Cook <keescook@chromium.org> wrote:
> The FIELD_SIZEOF() macro was redundant, and is being removed from the
> kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
> this is one of the last users of the old macro, so replace it.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
ca0e477931c5 ath11k: Use sizeof_field() instead of FIELD_SIZEOF()
--
https://patchwork.kernel.org/patch/11302533/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()
2019-12-18 18:07 ` Kalle Valo
@ 2019-12-19 0:56 ` Kees Cook
0 siblings, 0 replies; 5+ messages in thread
From: Kees Cook @ 2019-12-19 0:56 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-kernel, ath11k
On Wed, Dec 18, 2019 at 08:07:05PM +0200, Kalle Valo wrote:
> Kees Cook <keescook@chromium.org> writes:
>
> > The FIELD_SIZEOF() macro was redundant, and is being removed from the
> > kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
> > this is one of the last users of the old macro, so replace it.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Please also Cc linux-wireless so that the patchwork sees this.
Ah, okay. It wasn't listed in MAINTAINERS, so I didn't remember. Sorry;
I'll resend.
--
Kees Cook
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()
2019-12-18 17:19 Kees Cook
@ 2019-12-18 18:07 ` Kalle Valo
2019-12-19 0:56 ` Kees Cook
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2019-12-18 18:07 UTC (permalink / raw)
To: Kees Cook; +Cc: linux-kernel, ath11k
Kees Cook <keescook@chromium.org> writes:
> The FIELD_SIZEOF() macro was redundant, and is being removed from the
> kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
> this is one of the last users of the old macro, so replace it.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Please also Cc linux-wireless so that the patchwork sees this.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()
@ 2019-12-18 17:19 Kees Cook
2019-12-18 18:07 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2019-12-18 17:19 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-kernel, ath11k
The FIELD_SIZEOF() macro was redundant, and is being removed from the
kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
this is one of the last users of the old macro, so replace it.
Signed-off-by: Kees Cook <keescook@chromium.org>
---
drivers/net/wireless/ath/ath11k/wmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
index 4a518d406bc5..fd7cb07a9940 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.h
+++ b/drivers/net/wireless/ath/ath11k/wmi.h
@@ -44,7 +44,7 @@ struct wmi_tlv {
#define WMI_TLV_LEN GENMASK(15, 0)
#define WMI_TLV_TAG GENMASK(31, 16)
-#define TLV_HDR_SIZE FIELD_SIZEOF(struct wmi_tlv, header)
+#define TLV_HDR_SIZE sizeof_field(struct wmi_tlv, header)
#define WMI_CMD_HDR_CMD_ID GENMASK(23, 0)
#define WMI_MAX_MEM_REQS 32
--
2.17.1
--
Kees Cook
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-19 16:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-19 0:58 [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF() Kees Cook
2019-12-19 16:18 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2019-12-18 17:19 Kees Cook
2019-12-18 18:07 ` Kalle Valo
2019-12-19 0:56 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).