[PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()

[PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()

[Kees Cook]

The FIELD_SIZEOF() macro was redundant, and is being removed from the
kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
this is one of the last users of the old macro, so replace it.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/net/wireless/ath/ath11k/wmi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
index 4a518d406bc5..fd7cb07a9940 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.h
+++ b/drivers/net/wireless/ath/ath11k/wmi.h
@@ -44,7 +44,7 @@ struct wmi_tlv {
 
 #define WMI_TLV_LEN	GENMASK(15, 0)
 #define WMI_TLV_TAG	GENMASK(31, 16)
-#define TLV_HDR_SIZE	FIELD_SIZEOF(struct wmi_tlv, header)
+#define TLV_HDR_SIZE	sizeof_field(struct wmi_tlv, header)
 
 #define WMI_CMD_HDR_CMD_ID      GENMASK(23, 0)
 #define WMI_MAX_MEM_REQS        32
-- 
2.17.1


-- 
Kees Cook

Re: [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()

[Kalle Valo]

Kees Cook <keescook@chromium.org> writes:

> The FIELD_SIZEOF() macro was redundant, and is being removed from the
> kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
> this is one of the last users of the old macro, so replace it.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>

Please also Cc linux-wireless so that the patchwork sees this.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()

[Kees Cook]

On Wed, Dec 18, 2019 at 08:07:05PM +0200, Kalle Valo wrote:
> Kees Cook <keescook@chromium.org> writes:
> 
> > The FIELD_SIZEOF() macro was redundant, and is being removed from the
> > kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
> > this is one of the last users of the old macro, so replace it.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
> 
> Please also Cc linux-wireless so that the patchwork sees this.

Ah, okay. It wasn't listed in MAINTAINERS, so I didn't remember. Sorry;
I'll resend.

-- 
Kees Cook

[PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()

[Kees Cook]

The FIELD_SIZEOF() macro was redundant, and is being removed from the
kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
this is one of the last users of the old macro, so replace it.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
resend: https://lore.kernel.org/lkml/87d0cl8q46.fsf@kamboji.qca.qualcomm.com
---
 drivers/net/wireless/ath/ath11k/wmi.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h
index 4a518d406bc5..fd7cb07a9940 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.h
+++ b/drivers/net/wireless/ath/ath11k/wmi.h
@@ -44,7 +44,7 @@ struct wmi_tlv {
 
 #define WMI_TLV_LEN	GENMASK(15, 0)
 #define WMI_TLV_TAG	GENMASK(31, 16)
-#define TLV_HDR_SIZE	FIELD_SIZEOF(struct wmi_tlv, header)
+#define TLV_HDR_SIZE	sizeof_field(struct wmi_tlv, header)
 
 #define WMI_CMD_HDR_CMD_ID      GENMASK(23, 0)
 #define WMI_MAX_MEM_REQS        32
-- 
2.17.1


-- 
Kees Cook

Re: [PATCH] ath11k: Use sizeof_field() instead of FIELD_SIZEOF()

[Kalle Valo]

Kees Cook <keescook@chromium.org> wrote:

> The FIELD_SIZEOF() macro was redundant, and is being removed from the
> kernel. Since commit c593642c8be0 ("treewide: Use sizeof_field() macro")
> this is one of the last users of the old macro, so replace it.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

ca0e477931c5 ath11k: Use sizeof_field() instead of FIELD_SIZEOF()

-- 
https://patchwork.kernel.org/patch/11302533/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches