[PATCH v2] locking/qspinlock: Fix inaccessible URL of MCS lock paper

[PATCH v2] locking/qspinlock: Fix inaccessible URL of MCS lock paper

[Waiman Long]

It turns out that the URL of the MCS lock paper listed in the source
code is no longer accessible. I did got question about where the paper
was. This patch updates the URL to BZ 206115 which contains a copy of
the paper from

  https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf

Signed-off-by: Waiman Long <longman@redhat.com>
---
 kernel/locking/qspinlock.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c
index 2473f10c6956..ce75b2270b58 100644
--- a/kernel/locking/qspinlock.c
+++ b/kernel/locking/qspinlock.c
@@ -31,10 +31,9 @@
 /*
  * The basic principle of a queue-based spinlock can best be understood
  * by studying a classic queue-based spinlock implementation called the
- * MCS lock. The paper below provides a good description for this kind
- * of lock.
+ * MCS lock. A copy of the original MCS lock papaer is available at
  *
- * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf
+ * https://bugzilla.kernel.org/show_bug.cgi?id=206115
  *
  * This queued spinlock implementation is based on the MCS lock, however to make
  * it fit the 4 bytes we assume spinlock_t to be, and preserve its existing
-- 
2.18.1

Re: [PATCH v2] locking/qspinlock: Fix inaccessible URL of MCS lock paper

[Will Deacon]

On Tue, Jan 07, 2020 at 10:16:19AM -0500, Waiman Long wrote:
> It turns out that the URL of the MCS lock paper listed in the source
> code is no longer accessible. I did got question about where the paper
> was. This patch updates the URL to BZ 206115 which contains a copy of
> the paper from
> 
>   https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf
> 
> Signed-off-by: Waiman Long <longman@redhat.com>
> ---
>  kernel/locking/qspinlock.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c
> index 2473f10c6956..ce75b2270b58 100644
> --- a/kernel/locking/qspinlock.c
> +++ b/kernel/locking/qspinlock.c
> @@ -31,10 +31,9 @@
>  /*
>   * The basic principle of a queue-based spinlock can best be understood
>   * by studying a classic queue-based spinlock implementation called the
> - * MCS lock. The paper below provides a good description for this kind
> - * of lock.
> + * MCS lock. A copy of the original MCS lock papaer is available at

s/papaer/paper/

I think I reviewed the previous patch as you sent this version, but please
could you reword as suggested here [1]?

Cheers,

Will

[1] https://lore.kernel.org/lkml/20200107172343.GA32009@willie-the-truck/T/#m0f9eaf53e509b87d0f6378e35514c9b120d8edc2

Re: [PATCH v2] locking/qspinlock: Fix inaccessible URL of MCS lock paper

[Waiman Long]

On 1/7/20 12:34 PM, Will Deacon wrote:
> On Tue, Jan 07, 2020 at 10:16:19AM -0500, Waiman Long wrote:
>> It turns out that the URL of the MCS lock paper listed in the source
>> code is no longer accessible. I did got question about where the paper
>> was. This patch updates the URL to BZ 206115 which contains a copy of
>> the paper from
>>
>>   https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf
>>
>> Signed-off-by: Waiman Long <longman@redhat.com>
>> ---
>>  kernel/locking/qspinlock.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c
>> index 2473f10c6956..ce75b2270b58 100644
>> --- a/kernel/locking/qspinlock.c
>> +++ b/kernel/locking/qspinlock.c
>> @@ -31,10 +31,9 @@
>>  /*
>>   * The basic principle of a queue-based spinlock can best be understood
>>   * by studying a classic queue-based spinlock implementation called the
>> - * MCS lock. The paper below provides a good description for this kind
>> - * of lock.
>> + * MCS lock. A copy of the original MCS lock papaer is available at
> s/papaer/paper/
>
> I think I reviewed the previous patch as you sent this version, but please
> could you reword as suggested here [1]?
>
> Cheers,
>
> Will
>
> [1] https://lore.kernel.org/lkml/20200107172343.GA32009@willie-the-truck/T/#m0f9eaf53e509b87d0f6378e35514c9b120d8edc2
>
Sure. I will send out v3 shortly.

Cheers,
Longman