* Re: linux-next: build failure after merge of the btrfs-fixes tree
[not found] <20200107082431.2b83a8ac@canb.auug.org.au>
@ 2020-01-07 15:22 ` David Sterba
0 siblings, 0 replies; 5+ messages in thread
From: David Sterba @ 2020-01-07 15:22 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Linux Next Mailing List, Linux Kernel Mailing List, Josef
On Tue, Jan 07, 2020 at 08:24:31AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/btrfs/inode.c: In function 'btrfs_unlink_subvol':
> fs/btrfs/inode.c:4283:16: error: 'inode' undeclared (first use in this function)
> 4283 | if (btrfs_ino(inode) == BTRFS_EMPTY_SUBVOL_DIR_OBJECTID) {
> | ^~~~~
>
> Caused by commit
>
> b225d1cb20cc ("btrfs: fix invalid removal of root ref")
>
> I have reverted that commit for today.
Updated next-fixes branch pushed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-fixes tree
2024-03-17 22:17 Stephen Rothwell
2024-03-18 4:50 ` Anand Jain
2024-03-18 17:31 ` David Sterba
@ 2024-03-18 18:58 ` David Sterba
2 siblings, 0 replies; 5+ messages in thread
From: David Sterba @ 2024-03-18 18:58 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Anand Jain, David Sterba, Linux Kernel Mailing List,
Linux Next Mailing List, Christian Brauner
On Mon, Mar 18, 2024 at 09:17:55AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
> fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
> 1413 | if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
> | ^~~~~~~~~~~
> fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in
I've updated the for-next snapshot so it contains the updated version
that is based on top of the required changes. The same patch will be
also sent for merge.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-fixes tree
2024-03-17 22:17 Stephen Rothwell
2024-03-18 4:50 ` Anand Jain
@ 2024-03-18 17:31 ` David Sterba
2024-03-18 18:58 ` David Sterba
2 siblings, 0 replies; 5+ messages in thread
From: David Sterba @ 2024-03-18 17:31 UTC (permalink / raw)
To: Stephen Rothwell, Christian Brauner
Cc: Anand Jain, David Sterba, Linux Kernel Mailing List,
Linux Next Mailing List, Christian Brauner
On Mon, Mar 18, 2024 at 09:17:55AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
> fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
> 1413 | if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
> | ^~~~~~~~~~~
> fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
> cc019bc0d55b ("btrfs: do not skip re-registration for the mounted device")
>
> I have used the btrfs-fixes tree from next-20240315 for today.
>
> This is actually caused by an interaction with commit
>
> 9ae061cf2a46 ("btrfs: port device access to file")
>
> which has been in Linus' tree since March 12 (and linux-next since Feb 26).
I would really appreciate if all infrastructure changes to btrfs code
have CC:linux-btrfs@, the whole series "Open block devices as files" has
never been CCed so the build breakage is noticed only by accident. Also
I wonder why I have to repeatedly ask for that and why people think that
doing broad changes to code maintained by somebody else is ok.
There are 26 patches in linux-next intersecting fs/btrfs most of which I
see for the first time now. I don't have time to read fsdevel@ regularly
and act rather on events (i.e. CC or mails).
VFS is in the center of many other subsystems I understand that adding
the CC: manually is not feasible but scripting "if $path add CC:$subsys"
should be doable, namely when it's not just one-time job. Please try to
find some middle ground between efforts and patch workflow sanity.
Thanks for understanding.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the btrfs-fixes tree
2024-03-17 22:17 Stephen Rothwell
@ 2024-03-18 4:50 ` Anand Jain
2024-03-18 17:31 ` David Sterba
2024-03-18 18:58 ` David Sterba
2 siblings, 0 replies; 5+ messages in thread
From: Anand Jain @ 2024-03-18 4:50 UTC (permalink / raw)
To: Stephen Rothwell, David Sterba
Cc: David Sterba, Linux Kernel Mailing List, Linux Next Mailing List,
Christian Brauner
On 3/18/24 03:47, Stephen Rothwell wrote:
> Hi all,
>
> After merging the btrfs-fixes tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
> fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
> 1413 | if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
> | ^~~~~~~~~~~
> fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in
>
> Caused by commit
>
> cc019bc0d55b ("btrfs: do not skip re-registration for the mounted device")
>
> I have used the btrfs-fixes tree from next-20240315 for today.
>
> This is actually caused by an interaction with commit
>
> 9ae061cf2a46 ("btrfs: port device access to file")
>
Ah, unaware of this change. Thanks for the report.
A new fix, built on top of this change, has now been sent out.
As the Linux-next branch no longer has the commit cc019bc0d55b,
I've sent out the entire patch again.
https://lore.kernel.org/linux-btrfs/57a63f9905549f22618a85991b775fba76104412.1710732026.git.anand.jain@oracle.com/
Thanks, Anand
> which has been in Linus' tree since March 12 (and linux-next since Feb 26).
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: build failure after merge of the btrfs-fixes tree
@ 2024-03-17 22:17 Stephen Rothwell
2024-03-18 4:50 ` Anand Jain
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Stephen Rothwell @ 2024-03-17 22:17 UTC (permalink / raw)
To: David Sterba
Cc: Anand Jain, David Sterba, Linux Kernel Mailing List,
Linux Next Mailing List, Christian Brauner
[-- Attachment #1: Type: text/plain, Size: 939 bytes --]
Hi all,
After merging the btrfs-fixes tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/btrfs/volumes.c: In function 'btrfs_scan_one_device':
fs/btrfs/volumes.c:1413:55: error: 'bdev_handle' undeclared (first use in this function)
1413 | if (btrfs_skip_registration(disk_super, path, bdev_handle->bdev->bd_dev,
| ^~~~~~~~~~~
fs/btrfs/volumes.c:1413:55: note: each undeclared identifier is reported only once for each function it appears in
Caused by commit
cc019bc0d55b ("btrfs: do not skip re-registration for the mounted device")
I have used the btrfs-fixes tree from next-20240315 for today.
This is actually caused by an interaction with commit
9ae061cf2a46 ("btrfs: port device access to file")
which has been in Linus' tree since March 12 (and linux-next since Feb 26).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-18 19:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200107082431.2b83a8ac@canb.auug.org.au>
2020-01-07 15:22 ` linux-next: build failure after merge of the btrfs-fixes tree David Sterba
2024-03-17 22:17 Stephen Rothwell
2024-03-18 4:50 ` Anand Jain
2024-03-18 17:31 ` David Sterba
2024-03-18 18:58 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).