* [PATCH v2 -next] drivers/net: netdevsim depends on INET
@ 2020-01-16 13:14 Hongbo Yao
2020-01-16 13:31 ` Jakub Kicinski
2020-01-17 10:28 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Hongbo Yao @ 2020-01-16 13:14 UTC (permalink / raw)
To: kuba; +Cc: yaohongbo, chenzhou10, davem, netdev, linux-kernel
If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
Building drivers/net/netdevsim/fib.o will get the following error:
drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
fib.c:(.text+0xb11): undefined reference to `free_fib_info'
Correct the Kconfig for netdevsim.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 77ee9afad038..25a8f9387d5a 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -549,6 +549,7 @@ source "drivers/net/hyperv/Kconfig"
config NETDEVSIM
tristate "Simulated networking device"
depends on DEBUG_FS
+ depends on INET
depends on IPV6 || IPV6=n
select NET_DEVLINK
help
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET
2020-01-16 13:14 [PATCH v2 -next] drivers/net: netdevsim depends on INET Hongbo Yao
@ 2020-01-16 13:31 ` Jakub Kicinski
2020-01-16 13:56 ` Jiri Pirko
2020-01-17 10:28 ` David Miller
1 sibling, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2020-01-16 13:31 UTC (permalink / raw)
To: Hongbo Yao; +Cc: chenzhou10, davem, netdev, linux-kernel
On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> Building drivers/net/netdevsim/fib.o will get the following error:
>
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>
> Correct the Kconfig for netdevsim.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
Looks better :) Still missing a space between the hash and the bracket,
but:
Acked-by: Jakub Kicinski <kuba@kernel.org>
While at it - does mlxsw have the same problem by any chance?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET
2020-01-16 13:31 ` Jakub Kicinski
@ 2020-01-16 13:56 ` Jiri Pirko
2020-01-16 14:04 ` Ido Schimmel
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Pirko @ 2020-01-16 13:56 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: Hongbo Yao, chenzhou10, davem, netdev, linux-kernel, mlxsw
Thu, Jan 16, 2020 at 02:31:37PM CET, kuba@kernel.org wrote:
>On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
>> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
>> Building drivers/net/netdevsim/fib.o will get the following error:
>>
>> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
>> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
>> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
>> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>>
>> Correct the Kconfig for netdevsim.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
>
>Looks better :) Still missing a space between the hash and the bracket,
>but:
>
>Acked-by: Jakub Kicinski <kuba@kernel.org>
>
>While at it - does mlxsw have the same problem by any chance?
Looks like it does.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET
2020-01-16 13:56 ` Jiri Pirko
@ 2020-01-16 14:04 ` Ido Schimmel
0 siblings, 0 replies; 5+ messages in thread
From: Ido Schimmel @ 2020-01-16 14:04 UTC (permalink / raw)
To: Jiri Pirko
Cc: Jakub Kicinski, Hongbo Yao, chenzhou10, davem, netdev,
linux-kernel, mlxsw
On Thu, Jan 16, 2020 at 02:56:50PM +0100, Jiri Pirko wrote:
> Thu, Jan 16, 2020 at 02:31:37PM CET, kuba@kernel.org wrote:
> >On Thu, 16 Jan 2020 21:14:04 +0800, Hongbo Yao wrote:
> >> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> >> Building drivers/net/netdevsim/fib.o will get the following error:
> >>
> >> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> >> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> >> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> >> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
> >>
> >> Correct the Kconfig for netdevsim.
> >>
> >> Reported-by: Hulk Robot <hulkci@huawei.com>
> >> Fixes: 48bb9eb47b270("netdevsim: fib: Add dummy implementation for FIB offload")
> >
> >Looks better :) Still missing a space between the hash and the bracket,
> >but:
> >
> >Acked-by: Jakub Kicinski <kuba@kernel.org>
> >
> >While at it - does mlxsw have the same problem by any chance?
>
> Looks like it does.
MLXSW_SPECTRUM depends on NET_SWITCHDEV which in turn depends on INET
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 -next] drivers/net: netdevsim depends on INET
2020-01-16 13:14 [PATCH v2 -next] drivers/net: netdevsim depends on INET Hongbo Yao
2020-01-16 13:31 ` Jakub Kicinski
@ 2020-01-17 10:28 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: David Miller @ 2020-01-17 10:28 UTC (permalink / raw)
To: yaohongbo; +Cc: kuba, chenzhou10, netdev, linux-kernel
From: Hongbo Yao <yaohongbo@huawei.com>
Date: Thu, 16 Jan 2020 21:14:04 +0800
> If CONFIG_INET is not set and CONFIG_NETDEVSIM=y.
> Building drivers/net/netdevsim/fib.o will get the following error:
>
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_hw_flags_set':
> fib.c:(.text+0x12b): undefined reference to `fib_alias_hw_flags_set'
> drivers/net/netdevsim/fib.o: In function `nsim_fib4_rt_destroy':
> fib.c:(.text+0xb11): undefined reference to `free_fib_info'
>
> Correct the Kconfig for netdevsim.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 48bb9eb47b270 ("netdevsim: fib: Add dummy implementation for FIB offload")
> Signed-off-by: Hongbo Yao <yaohongbo@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-17 10:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 13:14 [PATCH v2 -next] drivers/net: netdevsim depends on INET Hongbo Yao
2020-01-16 13:31 ` Jakub Kicinski
2020-01-16 13:56 ` Jiri Pirko
2020-01-16 14:04 ` Ido Schimmel
2020-01-17 10:28 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).