linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc
@ 2020-01-15 19:34 Jernej Skrabec
  2020-01-16 12:27 ` Maxime Ripard
  2020-01-17 18:14 ` Maxime Ripard
  0 siblings, 2 replies; 6+ messages in thread
From: Jernej Skrabec @ 2020-01-15 19:34 UTC (permalink / raw)
  To: mripard, wens
  Cc: robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel

Tanix TX6 has 32 GiB eMMC. Add a node for it.

Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
 .../dts/allwinner/sun50i-h6-tanix-tx6.dts     | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
index 83e6cb0e59ce..8cbf4e4a761e 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
@@ -31,6 +31,13 @@ hdmi_con_in: endpoint {
 		};
 	};
 
+	reg_vcc1v8: vcc1v8 {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc1v8";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	reg_vcc3v3: vcc3v3 {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc3v3";
@@ -78,6 +85,15 @@ &mmc0 {
 	status = "okay";
 };
 
+&mmc2 {
+	vmmc-supply = <&reg_vcc3v3>;
+	vqmmc-supply = <&reg_vcc1v8>;
+	non-removable;
+	cap-mmc-hw-reset;
+	bus-width = <8>;
+	status = "okay";
+};
+
 &ohci0 {
 	status = "okay";
 };
@@ -86,6 +102,10 @@ &ohci3 {
 	status = "okay";
 };
 
+&pio {
+	vcc-pc-supply = <&reg_vcc1v8>;
+};
+
 &r_ir {
 	linux,rc-map-name = "rc-tanix-tx5max";
 	status = "okay";
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc
  2020-01-15 19:34 [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc Jernej Skrabec
@ 2020-01-16 12:27 ` Maxime Ripard
  2020-01-16 16:29   ` Jernej Škrabec
  2020-01-17 18:14 ` Maxime Ripard
  1 sibling, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2020-01-16 12:27 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Hi Jernej,

On Wed, Jan 15, 2020 at 08:34:41PM +0100, Jernej Skrabec wrote:
> Tanix TX6 has 32 GiB eMMC. Add a node for it.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

Did you forget to send the other two patches?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc
  2020-01-16 12:27 ` Maxime Ripard
@ 2020-01-16 16:29   ` Jernej Škrabec
  0 siblings, 0 replies; 6+ messages in thread
From: Jernej Škrabec @ 2020-01-16 16:29 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel

Hi!

Dne četrtek, 16. januar 2020 ob 13:27:00 CET je Maxime Ripard napisal(a):
> Hi Jernej,
> 
> On Wed, Jan 15, 2020 at 08:34:41PM +0100, Jernej Skrabec wrote:
> > Tanix TX6 has 32 GiB eMMC. Add a node for it.
> > 
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> 
> Did you forget to send the other two patches?

There are none. This is just mistake with "git format-patch -3".

This patch was tested separately and it works.

Best regards,
Jernej



^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc
  2020-01-15 19:34 [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc Jernej Skrabec
  2020-01-16 12:27 ` Maxime Ripard
@ 2020-01-17 18:14 ` Maxime Ripard
  2020-01-17 18:18   ` Jernej Škrabec
  1 sibling, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2020-01-17 18:14 UTC (permalink / raw)
  To: Jernej Skrabec
  Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

On Wed, Jan 15, 2020 at 08:34:41PM +0100, Jernej Skrabec wrote:
> Tanix TX6 has 32 GiB eMMC. Add a node for it.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
>  .../dts/allwinner/sun50i-h6-tanix-tx6.dts     | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> index 83e6cb0e59ce..8cbf4e4a761e 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> @@ -31,6 +31,13 @@ hdmi_con_in: endpoint {
>  		};
>  	};
>
> +	reg_vcc1v8: vcc1v8 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc1v8";
> +		regulator-min-microvolt = <1800000>;
> +		regulator-max-microvolt = <1800000>;
> +	};
> +
>  	reg_vcc3v3: vcc3v3 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vcc3v3";
> @@ -78,6 +85,15 @@ &mmc0 {
>  	status = "okay";
>  };
>
> +&mmc2 {
> +	vmmc-supply = <&reg_vcc3v3>;
> +	vqmmc-supply = <&reg_vcc1v8>;
> +	non-removable;
> +	cap-mmc-hw-reset;
> +	bus-width = <8>;
> +	status = "okay";
> +};
> +
>  &ohci0 {
>  	status = "okay";
>  };
> @@ -86,6 +102,10 @@ &ohci3 {
>  	status = "okay";
>  };
>
> +&pio {
> +	vcc-pc-supply = <&reg_vcc1v8>;
> +};
> +

Can you list all of the regulators for the H6 while you're at it (in a
preliminary patch, ideally)?

Thanks!
Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc
  2020-01-17 18:14 ` Maxime Ripard
@ 2020-01-17 18:18   ` Jernej Škrabec
  2020-01-22 17:42     ` Maxime Ripard
  0 siblings, 1 reply; 6+ messages in thread
From: Jernej Škrabec @ 2020-01-17 18:18 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel

Dne petek, 17. januar 2020 ob 19:14:27 CET je Maxime Ripard napisal(a):
> On Wed, Jan 15, 2020 at 08:34:41PM +0100, Jernej Skrabec wrote:
> > Tanix TX6 has 32 GiB eMMC. Add a node for it.
> > 
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> > 
> >  .../dts/allwinner/sun50i-h6-tanix-tx6.dts     | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts index
> > 83e6cb0e59ce..8cbf4e4a761e 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > @@ -31,6 +31,13 @@ hdmi_con_in: endpoint {
> > 
> >  		};
> >  	
> >  	};
> > 
> > +	reg_vcc1v8: vcc1v8 {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc1v8";
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-max-microvolt = <1800000>;
> > +	};
> > +
> > 
> >  	reg_vcc3v3: vcc3v3 {
> >  	
> >  		compatible = "regulator-fixed";
> >  		regulator-name = "vcc3v3";
> > 
> > @@ -78,6 +85,15 @@ &mmc0 {
> > 
> >  	status = "okay";
> >  
> >  };
> > 
> > +&mmc2 {
> > +	vmmc-supply = <&reg_vcc3v3>;
> > +	vqmmc-supply = <&reg_vcc1v8>;
> > +	non-removable;
> > +	cap-mmc-hw-reset;
> > +	bus-width = <8>;
> > +	status = "okay";
> > +};
> > +
> > 
> >  &ohci0 {
> >  
> >  	status = "okay";
> >  
> >  };
> > 
> > @@ -86,6 +102,10 @@ &ohci3 {
> > 
> >  	status = "okay";
> >  
> >  };
> > 
> > +&pio {
> > +	vcc-pc-supply = <&reg_vcc1v8>;
> > +};
> > +
> 
> Can you list all of the regulators for the H6 while you're at it (in a
> preliminary patch, ideally)?

Not sure what you mean. This box has only fixed regulators. I deducted above 
from the fact that port C is mostly dedicated to eMMC, so it has to use same 
regulator as vqmmc. Other than that, I don't know.

Best regards,
Jernej





^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc
  2020-01-17 18:18   ` Jernej Škrabec
@ 2020-01-22 17:42     ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2020-01-22 17:42 UTC (permalink / raw)
  To: Jernej Škrabec
  Cc: wens, robh+dt, mark.rutland, linux-arm-kernel, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2270 bytes --]

Hi,

On Fri, Jan 17, 2020 at 07:18:58PM +0100, Jernej Škrabec wrote:
> Dne petek, 17. januar 2020 ob 19:14:27 CET je Maxime Ripard napisal(a):
> > On Wed, Jan 15, 2020 at 08:34:41PM +0100, Jernej Skrabec wrote:
> > > Tanix TX6 has 32 GiB eMMC. Add a node for it.
> > >
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > > ---
> > >
> > >  .../dts/allwinner/sun50i-h6-tanix-tx6.dts     | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > > b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts index
> > > 83e6cb0e59ce..8cbf4e4a761e 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > > @@ -31,6 +31,13 @@ hdmi_con_in: endpoint {
> > >
> > >  		};
> > >
> > >  	};
> > >
> > > +	reg_vcc1v8: vcc1v8 {
> > > +		compatible = "regulator-fixed";
> > > +		regulator-name = "vcc1v8";
> > > +		regulator-min-microvolt = <1800000>;
> > > +		regulator-max-microvolt = <1800000>;
> > > +	};
> > > +
> > >
> > >  	reg_vcc3v3: vcc3v3 {
> > >
> > >  		compatible = "regulator-fixed";
> > >  		regulator-name = "vcc3v3";
> > >
> > > @@ -78,6 +85,15 @@ &mmc0 {
> > >
> > >  	status = "okay";
> > >
> > >  };
> > >
> > > +&mmc2 {
> > > +	vmmc-supply = <&reg_vcc3v3>;
> > > +	vqmmc-supply = <&reg_vcc1v8>;
> > > +	non-removable;
> > > +	cap-mmc-hw-reset;
> > > +	bus-width = <8>;
> > > +	status = "okay";
> > > +};
> > > +
> > >
> > >  &ohci0 {
> > >
> > >  	status = "okay";
> > >
> > >  };
> > >
> > > @@ -86,6 +102,10 @@ &ohci3 {
> > >
> > >  	status = "okay";
> > >
> > >  };
> > >
> > > +&pio {
> > > +	vcc-pc-supply = <&reg_vcc1v8>;
> > > +};
> > > +
> >
> > Can you list all of the regulators for the H6 while you're at it (in a
> > preliminary patch, ideally)?
>
> Not sure what you mean. This box has only fixed regulators. I deducted above
> from the fact that port C is mostly dedicated to eMMC, so it has to use same
> regulator as vqmmc. Other than that, I don't know.

If you don't really know, then setting all of them to 3.3v makes the
most sense. It should be described anyway.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-22 17:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 19:34 [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc Jernej Skrabec
2020-01-16 12:27 ` Maxime Ripard
2020-01-16 16:29   ` Jernej Škrabec
2020-01-17 18:14 ` Maxime Ripard
2020-01-17 18:18   ` Jernej Škrabec
2020-01-22 17:42     ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).