* [PATCH] iio: ad5755: fix spelling mistake "to" -> "too"
@ 2020-01-22 23:58 Colin King
2020-01-23 7:03 ` Ardelean, Alexandru
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2020-01-22 23:58 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
linux-iio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is a spelling mistake in a dev_err message. Fix it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/iio/dac/ad5755.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
index b9175fb4c8ab..dad0b26228a2 100644
--- a/drivers/iio/dac/ad5755.c
+++ b/drivers/iio/dac/ad5755.c
@@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev)
for_each_child_of_node(np, pp) {
if (devnr >= AD5755_NUM_CHANNELS) {
dev_err(dev,
- "There is to many channels defined in DT\n");
+ "There is too many channels defined in DT\n");
goto error_out;
}
--
2.24.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: ad5755: fix spelling mistake "to" -> "too"
2020-01-22 23:58 [PATCH] iio: ad5755: fix spelling mistake "to" -> "too" Colin King
@ 2020-01-23 7:03 ` Ardelean, Alexandru
2020-01-23 14:55 ` David Laight
0 siblings, 1 reply; 4+ messages in thread
From: Ardelean, Alexandru @ 2020-01-23 7:03 UTC (permalink / raw)
To: zzzzPopa, zzzzStefan Serban, linux-iio, jic23, colin.king,
Hennerich, Michael, lars, knaack.h, pmeerw
Cc: kernel-janitors, linux-kernel
On Wed, 2020-01-22 at 23:58 +0000, Colin King wrote:
> [External]
>
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a dev_err message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/iio/dac/ad5755.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> index b9175fb4c8ab..dad0b26228a2 100644
> --- a/drivers/iio/dac/ad5755.c
> +++ b/drivers/iio/dac/ad5755.c
> @@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct
> device *dev)
> for_each_child_of_node(np, pp) {
> if (devnr >= AD5755_NUM_CHANNELS) {
> dev_err(dev,
> - "There is to many channels defined in DT\n");
> + "There is too many channels defined in DT\n");
If going for the spelling stuff, maybe also change "is" to "are":
'There are too many channels defined in DT\n'
> goto error_out;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] iio: ad5755: fix spelling mistake "to" -> "too"
2020-01-23 7:03 ` Ardelean, Alexandru
@ 2020-01-23 14:55 ` David Laight
2020-01-24 20:22 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: David Laight @ 2020-01-23 14:55 UTC (permalink / raw)
To: 'Ardelean, Alexandru',
zzzzPopa, zzzzStefan Serban, linux-iio, jic23, colin.king,
Hennerich, Michael, lars, knaack.h, pmeerw
Cc: kernel-janitors, linux-kernel
From Ardelean, Alexandru
> Sent: 23 January 2020 07:03
>
> On Wed, 2020-01-22 at 23:58 +0000, Colin King wrote:
> > [External]
> >
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is a spelling mistake in a dev_err message. Fix it.
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/iio/dac/ad5755.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> > index b9175fb4c8ab..dad0b26228a2 100644
> > --- a/drivers/iio/dac/ad5755.c
> > +++ b/drivers/iio/dac/ad5755.c
> > @@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct
> > device *dev)
> > for_each_child_of_node(np, pp) {
> > if (devnr >= AD5755_NUM_CHANNELS) {
> > dev_err(dev,
> > - "There is to many channels defined in DT\n");
> > + "There is too many channels defined in DT\n");
>
> If going for the spelling stuff, maybe also change "is" to "are":
> 'There are too many channels defined in DT\n'
Probably better still: "The DT defines too many channels\n"
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: ad5755: fix spelling mistake "to" -> "too"
2020-01-23 14:55 ` David Laight
@ 2020-01-24 20:22 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2020-01-24 20:22 UTC (permalink / raw)
To: David Laight, 'Ardelean, Alexandru',
zzzzPopa, zzzzStefan Serban, linux-iio, jic23, colin.king,
Hennerich, Michael, lars, knaack.h, pmeerw
Cc: kernel-janitors, linux-kernel
On Thu, 2020-01-23 at 14:55 +0000, David Laight wrote:
> From Ardelean, Alexandru
> > Sent: 23 January 2020 07:03
> >
> > On Wed, 2020-01-22 at 23:58 +0000, Colin King wrote:
> > > [External]
> > >
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > There is a spelling mistake in a dev_err message. Fix it.
> > >
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > ---
> > > drivers/iio/dac/ad5755.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> > > index b9175fb4c8ab..dad0b26228a2 100644
> > > --- a/drivers/iio/dac/ad5755.c
> > > +++ b/drivers/iio/dac/ad5755.c
> > > @@ -655,7 +655,7 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct
> > > device *dev)
> > > for_each_child_of_node(np, pp) {
> > > if (devnr >= AD5755_NUM_CHANNELS) {
> > > dev_err(dev,
> > > - "There is to many channels defined in DT\n");
> > > + "There is too many channels defined in DT\n");
> >
> > If going for the spelling stuff, maybe also change "is" to "are":
> > 'There are too many channels defined in DT\n'
>
> Probably better still: "The DT defines too many channels\n"
bikeshedding:
How about fixing:
o missing newlines
o odd indentation
o unnecessary braces
o message grammar
at the same time?
---
drivers/iio/dac/ad5755.c | 25 ++++++++++---------------
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
index b9175f..f6e4cf92 100644
--- a/drivers/iio/dac/ad5755.c
+++ b/drivers/iio/dac/ad5755.c
@@ -631,10 +631,9 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev)
}
}
- if (i == ARRAY_SIZE(ad5755_dcdc_freq_table)) {
+ if (i == ARRAY_SIZE(ad5755_dcdc_freq_table))
dev_err(dev,
- "adi,dc-dc-freq out of range selecting 410kHz");
- }
+ "adi,dc-dc-freq out of range selecting 410kHz\n");
}
pdata->dc_dc_maxv = AD5755_DC_DC_MAXV_23V;
@@ -645,17 +644,15 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev)
break;
}
}
- if (i == ARRAY_SIZE(ad5755_dcdc_maxv_table)) {
- dev_err(dev,
- "adi,dc-dc-maxv out of range selecting 23V");
- }
+ if (i == ARRAY_SIZE(ad5755_dcdc_maxv_table))
+ dev_err(dev,
+ "adi,dc-dc-maxv out of range selecting 23V\n");
}
devnr = 0;
for_each_child_of_node(np, pp) {
if (devnr >= AD5755_NUM_CHANNELS) {
- dev_err(dev,
- "There is to many channels defined in DT\n");
+ dev_err(dev, "Too many channels defined in DT\n");
goto error_out;
}
@@ -681,11 +678,10 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev)
break;
}
}
- if (i == ARRAY_SIZE(ad5755_slew_rate_table)) {
+ if (i == ARRAY_SIZE(ad5755_slew_rate_table))
dev_err(dev,
- "channel %d slew rate out of range selecting 64kHz",
+ "channel %d slew rate out of range selecting 64kHz\n",
devnr);
- }
pdata->dac[devnr].slew.step_size = AD5755_SLEW_STEP_SIZE_1;
for (i = 0; i < ARRAY_SIZE(ad5755_slew_step_table); i++) {
@@ -695,11 +691,10 @@ static struct ad5755_platform_data *ad5755_parse_dt(struct device *dev)
break;
}
}
- if (i == ARRAY_SIZE(ad5755_slew_step_table)) {
+ if (i == ARRAY_SIZE(ad5755_slew_step_table))
dev_err(dev,
- "channel %d slew step size out of range selecting 1 LSB",
+ "channel %d slew step size out of range selecting 1 LSB\n",
devnr);
- }
} else {
pdata->dac[devnr].slew.enable = false;
pdata->dac[devnr].slew.rate = AD5755_SLEW_RATE_64k;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-24 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22 23:58 [PATCH] iio: ad5755: fix spelling mistake "to" -> "too" Colin King
2020-01-23 7:03 ` Ardelean, Alexandru
2020-01-23 14:55 ` David Laight
2020-01-24 20:22 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).