From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
"Sridharan, Ranjani" <ranjani.sridharan@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Support Opensource <Support.Opensource@diasemi.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Chiang, Mac" <mac.chiang@intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
"Lu, Brent" <brent.lu@intel.com>,
"cychiang@google.com" <cychiang@google.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback
Date: Wed, 12 Feb 2020 11:59:15 +0000 [thread overview]
Message-ID: <20200212115915.GC4028@sirena.org.uk> (raw)
In-Reply-To: <AM6PR10MB22630C79D08CE74878A6A096801B0@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On Wed, Feb 12, 2020 at 10:16:54AM +0000, Adam Thomson wrote:
> So far I've not found a way in the codec driver to be able to get around this.
> I spent a very long time with Sathya in the early days (Apollo Lake) looking at
> options but nothing would fit which is why I have the solution that's in place
> right now. We could probably reduce the number of rechecks before timeout in the
> driver but that's really just papering over the crack and there's still the
> possibility of noise later when SRM finally does lock.
This really needs the componentisation refactoring I think, that way we
can annotate individual devices and links with what they need rather
than essentially guessing about what works most of the time which is
more or less what we do at the minute. Like you say as things are at
the minute there's a lot of crack papering going on.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-12 11:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 8:16 [PATCH] ASoC: da7219: check SRM lock in trigger callback Brent Lu
2020-02-10 14:18 ` [alsa-devel] " Pierre-Louis Bossart
[not found] ` <CAOReqxhHfTuj6mxeX2e_ejMY8N4u+BFLfzKDgn=y5EbWLL_joA@mail.gmail.com>
2020-02-10 16:07 ` Pierre-Louis Bossart
[not found] ` <CAOReqxiNomQ7OOoE8LHWKH_LkaerSgsO-Yr4918Az2e_50THaA@mail.gmail.com>
2020-02-11 4:00 ` Fletcher Woodruff
2020-02-10 14:32 ` Adam Thomson
2020-02-11 10:08 ` Lu, Brent
2020-02-11 16:30 ` [alsa-devel] " Pierre-Louis Bossart
[not found] ` <CAFQqKeWHDyyd_YBBaD6P2sCL5OCNEsiUU6B7eUwtiLv8GZU0yg@mail.gmail.com>
2020-02-11 21:12 ` Pierre-Louis Bossart
[not found] ` <CAFQqKeXK3OG7KXaHGUuC75sxWrdf11xJooC7XsDCOyd6KUgPTQ@mail.gmail.com>
2020-02-11 21:49 ` Pierre-Louis Bossart
2020-02-12 10:16 ` Adam Thomson
2020-02-12 11:59 ` Mark Brown [this message]
2020-02-12 15:48 ` Pierre-Louis Bossart
2020-02-12 17:01 ` Adam Thomson
2020-02-19 5:57 ` Lu, Brent
2020-02-19 10:05 ` Adam Thomson
2020-02-10 18:59 ` Mark Brown
2020-02-11 10:19 ` Lu, Brent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212115915.GC4028@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=cychiang@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).