From: Fletcher Woodruff <fletcherw@google.com>
To: Curtis Malainey <cujomalainey@google.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
ALSA development <alsa-devel@alsa-project.org>,
Support Opensource <support.opensource@diasemi.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
"Chiang, Mac" <mac.chiang@intel.com>,
Mark Brown <broonie@kernel.org>, Brent Lu <brent.lu@intel.com>,
Jimmy Cheng-Yi Chiang <cychiang@google.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: da7219: check SRM lock in trigger callback
Date: Tue, 11 Feb 2020 13:00:33 +0900 [thread overview]
Message-ID: <CAMSu_6F5N27KY822uL8_ZD7iHDhiBYLrrFfNJe3QXtb9RNyogw@mail.gmail.com> (raw)
In-Reply-To: <CAOReqxiNomQ7OOoE8LHWKH_LkaerSgsO-Yr4918Az2e_50THaA@mail.gmail.com>
On Tue, Feb 11, 2020 at 1:18 AM Curtis Malainey <cujomalainey@google.com> wrote:
>
> +Fletcher Woodruff
> See comment #3 in the bug. This is not a GLK specific issue. If I remember correctly Fletcher found that this was occurring on 2-3 platforms.
Yes, I tested this and saw the same bug on a Pixelbook Go which I
believe is Comet Lake.
>SST has the ability to turn on clocks on demand which is why this has not been an issue previously from what I understand on the bug.
>
> And that is a fair point, we do need to consider other users of the codec.
>
>
> On Mon, Feb 10, 2020 at 8:07 AM Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> wrote:
>>
>>
>>
>> On 2/10/20 9:44 AM, Curtis Malainey wrote:
>> > +Jimmy Cheng-Yi Chiang <cychiang@google.com>
>> >
>> > This error is causing pcm_open commands to fail timing requirements,
>> > sometimes taking +500ms to open the PCM as a result. This work around is
>> > required so we can meet the timing requirements. The bug is explained in
>> > detail here https://github.com/thesofproject/sof/issues/2124
>>
>> Ah, thanks for the pointer, but this still does not tell me if it's a
>> GLK-only issue or not. And if yes, there are alternate proposals
>> discussed in that issue #2124, which has been idle since November 25.
>>
>> What I am really worried is side effects on unrelated platforms.
next prev parent reply other threads:[~2020-02-11 4:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 8:16 [PATCH] ASoC: da7219: check SRM lock in trigger callback Brent Lu
2020-02-10 14:18 ` [alsa-devel] " Pierre-Louis Bossart
[not found] ` <CAOReqxhHfTuj6mxeX2e_ejMY8N4u+BFLfzKDgn=y5EbWLL_joA@mail.gmail.com>
2020-02-10 16:07 ` Pierre-Louis Bossart
[not found] ` <CAOReqxiNomQ7OOoE8LHWKH_LkaerSgsO-Yr4918Az2e_50THaA@mail.gmail.com>
2020-02-11 4:00 ` Fletcher Woodruff [this message]
2020-02-10 14:32 ` Adam Thomson
2020-02-11 10:08 ` Lu, Brent
2020-02-11 16:30 ` [alsa-devel] " Pierre-Louis Bossart
[not found] ` <CAFQqKeWHDyyd_YBBaD6P2sCL5OCNEsiUU6B7eUwtiLv8GZU0yg@mail.gmail.com>
2020-02-11 21:12 ` Pierre-Louis Bossart
[not found] ` <CAFQqKeXK3OG7KXaHGUuC75sxWrdf11xJooC7XsDCOyd6KUgPTQ@mail.gmail.com>
2020-02-11 21:49 ` Pierre-Louis Bossart
2020-02-12 10:16 ` Adam Thomson
2020-02-12 11:59 ` Mark Brown
2020-02-12 15:48 ` Pierre-Louis Bossart
2020-02-12 17:01 ` Adam Thomson
2020-02-19 5:57 ` Lu, Brent
2020-02-19 10:05 ` Adam Thomson
2020-02-10 18:59 ` Mark Brown
2020-02-11 10:19 ` Lu, Brent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMSu_6F5N27KY822uL8_ZD7iHDhiBYLrrFfNJe3QXtb9RNyogw@mail.gmail.com \
--to=fletcherw@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=cychiang@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).